You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Michael Ho (Code Review)" <ge...@cloudera.org> on 2016/06/09 00:38:40 UTC
[Impala-CR](cdh5-trunk) Undo the removal of build thirdparty.sh.
Michael Ho has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3342
Change subject: Undo the removal of build_thirdparty.sh.
......................................................................
Undo the removal of build_thirdparty.sh.
Apparently, some pre-historic packaging script still relies
on build_thirdparty.sh to work around some problem related to
snappy. The build team cannot quite tell me why they cannot
use the toolchain instead so let's just revert the removal
of this precious script for now.
Change-Id: I5e6f9d3b86623ddeac6c4a1632c26ac50c555684
---
A bin/build_thirdparty.sh
1 file changed, 241 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/42/3342/1
--
To view, visit http://gerrit.cloudera.org:8080/3342
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5e6f9d3b86623ddeac6c4a1632c26ac50c555684
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
[Impala-CR](cdh5-trunk) Undo the removal of build thirdparty.sh.
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has submitted this change and it was merged.
Change subject: Undo the removal of build_thirdparty.sh.
......................................................................
Undo the removal of build_thirdparty.sh.
Apparently, some pre-historic packaging script still relies
on build_thirdparty.sh to work around some problem related to
snappy. The build team cannot quite tell me why they cannot
use the toolchain instead so let's just revert the removal
of this precious script for now.
Change-Id: I5e6f9d3b86623ddeac6c4a1632c26ac50c555684
Reviewed-on: http://gerrit.cloudera.org:8080/3342
Reviewed-by: Dan Hecht <dh...@cloudera.com>
Tested-by: Michael Ho <kw...@cloudera.com>
---
A bin/build_thirdparty.sh
1 file changed, 241 insertions(+), 0 deletions(-)
Approvals:
Michael Ho: Verified
Dan Hecht: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/3342
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5e6f9d3b86623ddeac6c4a1632c26ac50c555684
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
[Impala-CR](cdh5-trunk) Undo the removal of build thirdparty.sh.
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: Undo the removal of build_thirdparty.sh.
......................................................................
Patch Set 1:
Is the diff you posted not going to be committed? Otherwise, why do we need this commit?
--
To view, visit http://gerrit.cloudera.org:8080/3342
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e6f9d3b86623ddeac6c4a1632c26ac50c555684
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) Undo the removal of build thirdparty.sh.
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change.
Change subject: Undo the removal of build_thirdparty.sh.
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/3342
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e6f9d3b86623ddeac6c4a1632c26ac50c555684
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) Undo the removal of build thirdparty.sh.
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change.
Change subject: Undo the removal of build_thirdparty.sh.
......................................................................
Patch Set 1:
Please see the following diff in the packaging script which relies on it.
https://review.infra.cloudera.com/r/62412/diff/1#index_header
--
To view, visit http://gerrit.cloudera.org:8080/3342
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e6f9d3b86623ddeac6c4a1632c26ac50c555684
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) Undo the removal of build thirdparty.sh.
Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has posted comments on this change.
Change subject: Undo the removal of build_thirdparty.sh.
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3342
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e6f9d3b86623ddeac6c4a1632c26ac50c555684
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) Undo the removal of build thirdparty.sh.
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change.
Change subject: Undo the removal of build_thirdparty.sh.
......................................................................
Patch Set 1:
Henry, they are not sure if that will fix all the problem.
--
To view, visit http://gerrit.cloudera.org:8080/3342
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e6f9d3b86623ddeac6c4a1632c26ac50c555684
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-HasComments: No