You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "zhilinli123 (via GitHub)" <gi...@apache.org> on 2023/03/23 01:58:40 UTC
[GitHub] [incubator-seatunnel] zhilinli123 opened a new pull request, #4400: [Bug] [Writer] hdfs temp folder has not been cleaned up #4321
zhilinli123 opened a new pull request, #4400:
URL: https://github.com/apache/incubator-seatunnel/pull/4400
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
close: https://github.com/apache/incubator-seatunnel/issues/4321
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
* [ ] If you are contributing the connector code, please check that the following files are updated:
1. Update change log that in connector document. For more details you can refer to [connector-v2](https://github.com/apache/incubator-seatunnel/tree/dev/docs/en/connector-v2)
2. Update [plugin-mapping.properties](https://github.com/apache/incubator-seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it
3. Update the pom file of [seatunnel-dist](https://github.com/apache/incubator-seatunnel/blob/dev/seatunnel-dist/pom.xml)
* [ ] Update the [`release-note`](https://github.com/apache/incubator-seatunnel/blob/dev/release-note.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] zhilinli123 closed pull request #4400: [Bug] [Writer] hdfs temp folder has not been cleaned up #4321
Posted by "zhilinli123 (via GitHub)" <gi...@apache.org>.
zhilinli123 closed pull request #4400: [Bug] [Writer] hdfs temp folder has not been cleaned up #4321
URL: https://github.com/apache/incubator-seatunnel/pull/4400
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] zhilinli123 commented on pull request #4400: [Bug] [Writer] hdfs temp folder has not been cleaned up #4321
Posted by "zhilinli123 (via GitHub)" <gi...@apache.org>.
zhilinli123 commented on PR #4400:
URL: https://github.com/apache/incubator-seatunnel/pull/4400#issuecomment-1481101747
> commit结束后才删除
> > > 这只是提交时删除目录，任务退出后目录应还存在。
> >
> >
> > 你的意思是它不应该被删除？
>
> commit结合后才删除，面会创建，但任务结合后该目录仍然存在，任务退出时应删除该临时目录。
> > > This is just to delete the directory when commit, and the directory should still exist after the task exits.
> >
> >
> > You mean it shouldn't be deleted?
>
> It is only deleted after the commit end, and will be created later, but the directory still exists after the task end, and the temporary directory should be deleted when the task exit.
Can you give me some implementation hints I don't see how to tell if this task is over
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] zhilinli123 commented on pull request #4400: [Bug] [Writer] hdfs temp folder has not been cleaned up #4321
Posted by "zhilinli123 (via GitHub)" <gi...@apache.org>.
zhilinli123 commented on PR #4400:
URL: https://github.com/apache/incubator-seatunnel/pull/4400#issuecomment-1480896499
> This is just to delete the directory when commit, and the directory should still exist after the task exits.
You mean it shouldn't be deleted?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer closed pull request #4400: [Bug] [Writer] hdfs temp folder has not been cleaned up #4321
Posted by "TyrantLucifer (via GitHub)" <gi...@apache.org>.
TyrantLucifer closed pull request #4400: [Bug] [Writer] hdfs temp folder has not been cleaned up #4321
URL: https://github.com/apache/incubator-seatunnel/pull/4400
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] lightzhao commented on pull request #4400: [Bug] [Writer] hdfs temp folder has not been cleaned up #4321
Posted by "lightzhao (via GitHub)" <gi...@apache.org>.
lightzhao commented on PR #4400:
URL: https://github.com/apache/incubator-seatunnel/pull/4400#issuecomment-1482145262
> > > > This is just to delete the directory when commit, and the directory should still exist after the task exits.
> > >
> > >
> > > You mean it shouldn't be deleted?
> >
> >
> > It is only deleted after the commit end, and will be created later, but the directory still exists after the task end, and the temporary directory should be deleted when the task exit.
>
> Can you give me some implementation hints I don't see how to tell if this task is over
I tried to delete the temporary directory in the close method before, but found that the close method will not be called when the task exits. The engine use flink. I have not thought of a better way to solve it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] lightzhao commented on pull request #4400: [Bug] [Writer] hdfs temp folder has not been cleaned up #4321
Posted by "lightzhao (via GitHub)" <gi...@apache.org>.
lightzhao commented on PR #4400:
URL: https://github.com/apache/incubator-seatunnel/pull/4400#issuecomment-1480910303
> > This is just to delete the directory when commit, and the directory should still exist after the task exits.
>
> You mean it shouldn't be deleted?
It is only deleted after the commit end, and will be created later, but the directory still exists after the task end, and the temporary directory should be deleted when the task exit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] zhilinli123 commented on pull request #4400: [Bug] [Writer] hdfs temp folder has not been cleaned up #4321
Posted by "zhilinli123 (via GitHub)" <gi...@apache.org>.
zhilinli123 commented on PR #4400:
URL: https://github.com/apache/incubator-seatunnel/pull/4400#issuecomment-1481109438
> > > This is just to delete the directory when commit, and the directory should still exist after the task exits.
> >
> >
> > You mean it shouldn't be deleted?
>
> It is only deleted after the commit end, and will be created later, but the directory still exists after the task end, and the temporary directory should be deleted when the task exit.
Can you give me some implementation hints I don't see how to tell if this task is over
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer commented on pull request #4400: [Bug] [Writer] hdfs temp folder has not been cleaned up #4321
Posted by "TyrantLucifer (via GitHub)" <gi...@apache.org>.
TyrantLucifer commented on PR #4400:
URL: https://github.com/apache/incubator-seatunnel/pull/4400#issuecomment-1482201767
This pull request not make sense, I will close it, if you have any other questions, please reopen it and send an email to dev@seatunnel.apache.org
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org