You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "AngersZhuuuu (via GitHub)" <gi...@apache.org> on 2023/04/23 07:14:26 UTC

[GitHub] [incubator-celeborn] AngersZhuuuu opened a new pull request, #1452: [CELEBORN-547] Refactor request related API

AngersZhuuuu opened a new pull request, #1452:
URL: https://github.com/apache/incubator-celeborn/pull/1452

   ### What changes were proposed in this pull request?
   Refactor request related API
   
   
   ### Why are the changes needed?
   
   
   
   ### Does this PR introduce _any_ user-facing change?
   
   
   
   ### How was this patch tested?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-celeborn] AngersZhuuuu merged pull request #1452: [CELEBORN-547] Refactor request related API

Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu merged PR #1452:
URL: https://github.com/apache/incubator-celeborn/pull/1452


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-celeborn] FMX commented on a diff in pull request #1452: [CELEBORN-547] Refactor request related API

Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX commented on code in PR #1452:
URL: https://github.com/apache/incubator-celeborn/pull/1452#discussion_r1178586095


##########
client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala:
##########
@@ -1059,7 +1053,7 @@ class LifecycleManager(appId: String, val conf: CelebornConf) extends RpcEndpoin
     }
   }
 
-  private def requestDestroy(endpoint: RpcEndpointRef, message: Destroy): DestroyResponse = {
+  private def requestWorkerDestroy(endpoint: RpcEndpointRef, message: Destroy): DestroyResponse = {

Review Comment:
   I think it should be renamed to 'requestWorkerDestroySlots' and the Destroy message should also be renamed.
   The name 'WorkerDestroy' is misleading.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1452: [CELEBORN-547] Refactor request related API

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1452:
URL: https://github.com/apache/incubator-celeborn/pull/1452#issuecomment-1518978816

   ## [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1452?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1452](https://codecov.io/gh/apache/incubator-celeborn/pull/1452?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (61d73a4) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/e3ae2f0e17939ed7f765edea248b55d641603600?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e3ae2f0) will **decrease** coverage by `0.06%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@            Coverage Diff             @@
   ##             main    #1452      +/-   ##
   ==========================================
   - Coverage   44.87%   44.80%   -0.06%     
   ==========================================
     Files         156      155       -1     
     Lines        9596     9586      -10     
     Branches      956      955       -1     
   ==========================================
   - Hits         4305     4294      -11     
     Misses       5008     5008              
   - Partials      283      284       +1     
   ```
   
   
   [see 3 files with indirect coverage changes](https://codecov.io/gh/apache/incubator-celeborn/pull/1452/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-celeborn] AngersZhuuuu commented on a diff in pull request #1452: [CELEBORN-547] Refactor request related API

Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on code in PR #1452:
URL: https://github.com/apache/incubator-celeborn/pull/1452#discussion_r1178587412


##########
client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala:
##########
@@ -1059,7 +1053,7 @@ class LifecycleManager(appId: String, val conf: CelebornConf) extends RpcEndpoin
     }
   }
 
-  private def requestDestroy(endpoint: RpcEndpointRef, message: Destroy): DestroyResponse = {
+  private def requestWorkerDestroy(endpoint: RpcEndpointRef, message: Destroy): DestroyResponse = {

Review Comment:
   Year, should do like this. Let me do this first.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-celeborn] FMX commented on a diff in pull request #1452: [CELEBORN-547] Refactor request related API

Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX commented on code in PR #1452:
URL: https://github.com/apache/incubator-celeborn/pull/1452#discussion_r1178595019


##########
client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala:
##########
@@ -1059,7 +1053,7 @@ class LifecycleManager(appId: String, val conf: CelebornConf) extends RpcEndpoin
     }
   }
 
-  private def requestDestroy(endpoint: RpcEndpointRef, message: Destroy): DestroyResponse = {
+  private def requestWorkerDestroy(endpoint: RpcEndpointRef, message: Destroy): DestroyResponse = {

Review Comment:
   OK.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org