You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by be...@apache.org on 2026/02/04 14:58:41 UTC

(superset) 11/13: Fix poolclass check

This is an automated email from the ASF dual-hosted git repository.

beto pushed a commit to branch engine-manager
in repository https://gitbox.apache.org/repos/asf/superset.git

commit d06ccf51524dfe34596cad26ca330473c4e7add4
Author: Beto Dealmeida <ro...@dealmeida.net>
AuthorDate: Thu Dec 4 09:40:04 2025 -0500

    Fix poolclass check
---
 superset/engines/manager.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/superset/engines/manager.py b/superset/engines/manager.py
index 452882108aa..ed6700d4884 100644
--- a/superset/engines/manager.py
+++ b/superset/engines/manager.py
@@ -323,7 +323,7 @@ class EngineManager:
         kwargs = extra.get("engine_params", {})
 
         # get pool class
-        if self.mode == EngineModes.NEW or "poolclass" not in extra:
+        if self.mode == EngineModes.NEW or "poolclass" not in kwargs:
             kwargs["poolclass"] = pool.NullPool
         else:
             pools = {