[GitHub] [flink-kubernetes-operator] asardaes edited a comment on pull request #1: [FLINK-26078] Kubernetes Operator Prototype

[GitBox <gi...@apache.org>]

asardaes edited a comment on pull request #1:
URL: https://github.com/apache/flink-kubernetes-operator/pull/1#issuecomment-1041166014


   I don't know if you already considered how to allow users to specify logging configuration, but even if you did, I think it would be counterproductive to redeploy a cluster every time log configuration changes. I personally would like to mount a `logback-console.xml` file from a place I control, but I can't mount it directly into `$FLINK_HOME/conf` because the controller would already mount things there.
   
   I imagine a simple solution would be for me to mount my conf file somewhere else and then inject an environment variable in my template that instructs Flink to use it, and as far as I can tell that only requires a small change [here]( https://github.com/apache/flink/blob/1d564a95581f5b4b1d8ae343676474a4fa570ffa/flink-dist/src/main/flink-bin/bin/flink-console.sh#L101). If that line uses something like `FLINK_LOG_CONF_DIR` and defaults to `$FLINK_HOME/conf` when it's unset, I think that would suffice. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org