You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhay Kulkarni <ak...@hortonworks.com> on 2018/08/05 00:20:24 UTC
Re: Review Request 68101: RANGER-2173: Optimize Trie constuction and
Policy lookup
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68101/
-----------------------------------------------------------
(Updated Aug. 5, 2018, 12:20 a.m.)
Review request for ranger, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, and Velmurugan Periasamy.
Changes
-------
A string comparison needs to case-insensitive if optIgnoreCase condition is true for the resource.
Bugs: RANGER-2173
https://issues.apache.org/jira/browse/RANGER-2173
Repository: ranger
Description
-------
Ranger uses Trie data structure to look up policy resources for efficient access. Trie tree may be optimized to contain fewer nodes and can be made less deep. This will allow faster construction of Trie tree and faster lookup for a resource. This is done by using longest common prefix strings instead of single character to organize Trie tree. Also added instrumentation to measure performance.
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerResourceTrie.java 1723d1416
Diff: https://reviews.apache.org/r/68101/diff/5/
Changes: https://reviews.apache.org/r/68101/diff/4-5/
Testing
-------
Passes all unit tests
Thanks,
Abhay Kulkarni
Re: Review Request 68101: RANGER-2173: Optimize Trie constuction and
Policy lookup
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68101/#review206866
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Aug. 5, 2018, 12:20 a.m., Abhay Kulkarni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68101/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2018, 12:20 a.m.)
>
>
> Review request for ranger, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2173
> https://issues.apache.org/jira/browse/RANGER-2173
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Ranger uses Trie data structure to look up policy resources for efficient access. Trie tree may be optimized to contain fewer nodes and can be made less deep. This will allow faster construction of Trie tree and faster lookup for a resource. This is done by using longest common prefix strings instead of single character to organize Trie tree. Also added instrumentation to measure performance.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerResourceTrie.java 1723d1416
>
>
> Diff: https://reviews.apache.org/r/68101/diff/5/
>
>
> Testing
> -------
>
> Passes all unit tests
>
>
> Thanks,
>
> Abhay Kulkarni
>
>