[jira] Commented: (TAP5-1032) Reporting validation exceptions by throwing an exception is bad form: allow for returning a value instead

["Howard M. Lewis Ship (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAP5-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838036#action_12838036 ] 

Howard M. Lewis Ship commented on TAP5-1032:
--------------------------------------------

Hm. The APIs are entrenched, and they make sense in some circumstances, i.e.:

public interface Translator<T> {
 ...
  T parseClient(Field field, String clientValue, String message) throws ValidationException;
 ...

Once you have that, it's nice for the Validator methods to throw the exception (for consistency) even they they are void methods.  In addition, the horse has left the barn in some ways w.r.t. changing such a central API.

> Reporting validation exceptions by throwing an exception is bad form: allow for returning a value instead
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1032
>                 URL: https://issues.apache.org/jira/browse/TAP5-1032
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.2.0
>            Reporter: Howard M. Lewis Ship
>
> From the Dept. Of "We did this in T4 and didn't know it was brain damaged then." ... various APIs related to translation and validation work by throwing a ValidationException which is nothing more than a wrapper around an error message string. It would be nice to allow, in some compatible way, allow methods to simply return the exception, or even just the string for the exception, rather than throwing an exception, which is very inefficient.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.