[GitHub] [ozone] kerneltime commented on a diff in pull request #4920: HDDS-8878. When renaming a file with s3 presign url, special characters appear in garbled code

["kerneltime (via GitHub)" <gi...@apache.org>]

kerneltime commented on code in PR #4920:
URL: https://github.com/apache/ozone/pull/4920#discussion_r1296492086


##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/ObjectEndpoint.java:
##########
@@ -386,7 +386,7 @@ public Response get(
       // http://localhost:9878/bucket/key?response-expires=1&response-expires=2
       // only response-expires=1 is valid
       MultivaluedMap<String, String> queryParams = context
-          .getUriInfo().getQueryParameters();
+          .getUriInfo().getQueryParameters(false);

Review Comment:
   This looks fine, but I would like to know if we need a more thorough approach to handle Unicode values in the query params and how we process it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org