You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "hutiefang76 (via GitHub)" <gi...@apache.org> on 2026/07/01 18:27:34 UTC
[PR] Kafka Connect: Include connector name in commit thread names [iceberg]
hutiefang76 opened a new pull request, #17033:
URL: https://github.com/apache/iceberg/pull/17033
Fixes #16354.
This updates the Kafka Connect sink commit thread names to include the connector name:
- coordinator threads now use `iceberg-coord-<connector-name>` when started by a committer
- committer worker pool threads now use `iceberg-committer-<connector-name>-%d`
This makes thread dumps and worker logs easier to attribute when multiple Iceberg sink connectors run in the same Kafka Connect worker. The existing package-private `CoordinatorThread(Coordinator)` constructor is kept unchanged for existing tests/internal callers.
Validation:
- `JAVA_HOME=$(/usr/libexec/java_home -v 17) ./gradlew :iceberg-kafka-connect:iceberg-kafka-connect:test --tests org.apache.iceberg.connect.channel.TestCoordinatorThread --tests org.apache.iceberg.connect.channel.TestCommitterImpl --no-daemon`
- `JAVA_HOME=$(/usr/libexec/java_home -v 17) ./gradlew :iceberg-kafka-connect:iceberg-kafka-connect:spotlessCheck --no-daemon`
- `git diff --check`
---
**AI Disclosure**
- Model: GPT-5
- Platform/Tool: Codex
- Human Oversight: fully reviewed
- Prompt Summary: Implement a small Kafka Connect thread naming fix for Apache Iceberg issue #16354 with local tests and project-style checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Kafka Connect: Include connector name in commit thread names [iceberg]
Posted by "hutiefang76 (via GitHub)" <gi...@apache.org>.
hutiefang76 commented on PR #17033:
URL: https://github.com/apache/iceberg/pull/17033#issuecomment-5149955903
This is still relevant: #16354 remains open, and this PR is the only linked fix. All existing CI checks are green. A review when someone has time would be appreciated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Kafka Connect: Include connector name in commit thread names [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #17033: Kafka Connect: Include connector name in commit thread names
URL: https://github.com/apache/iceberg/pull/17033
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Kafka Connect: Include connector name in commit thread names [iceberg]
Posted by "hutiefang76 (via GitHub)" <gi...@apache.org>.
hutiefang76 commented on PR #17033:
URL: https://github.com/apache/iceberg/pull/17033#issuecomment-5614635502
Rechecked current main after the stale closure: the coordinator still uses `iceberg-coord`, and the committer pool still uses `iceberg-committer-%d`, without the connector name. #16354 is still open.
Reopening for review. The existing PR head has 27 successful checks; those are the original CI results, not a fresh run against today's main. This remains scoped to thread naming and its regression tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Kafka Connect: Include connector name in commit thread names [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17033:
URL: https://github.com/apache/iceberg/pull/17033#issuecomment-5610717056
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Kafka Connect: Include connector name in commit thread names [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17033:
URL: https://github.com/apache/iceberg/pull/17033#issuecomment-5502479857
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Kafka Connect: Include connector name in commit thread names [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17033:
URL: https://github.com/apache/iceberg/pull/17033#issuecomment-5148614220
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org