You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by venkat sairam <ve...@gmail.com> on 2017/01/02 14:26:01 UTC
Review Request 55123: Need to highlight XML tags in preview xml viewer
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55123/
-----------------------------------------------------------
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, Prabhjyot Singh, and Renjith Kamath.
Bugs: AMBARI-19334
https://issues.apache.org/jira/browse/AMBARI-19334
Repository: ambari
Description
-------
Added codemirror configuration for XML preview
Diffs
-----
contrib/views/wfmanager/src/main/resources/ui/ember-cli-build.js 5dfb87c
Diff: https://reviews.apache.org/r/55123/diff/
Testing
-------
We have checked the XML formatting and syntax higlighting by creating sample workflows.
Thanks,
venkat sairam
Re: Review Request 55123: Need to highlight XML tags in preview xml
viewer
Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55123/#review160336
-----------------------------------------------------------
Ship it!
Ship It!
- Pallav Kulshreshtha
On Jan. 2, 2017, 2:26 p.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55123/
> -----------------------------------------------------------
>
> (Updated Jan. 2, 2017, 2:26 p.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, Prabhjyot Singh, and Renjith Kamath.
>
>
> Bugs: AMBARI-19334
> https://issues.apache.org/jira/browse/AMBARI-19334
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added codemirror configuration for XML preview
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/ember-cli-build.js 5dfb87c
>
> Diff: https://reviews.apache.org/r/55123/diff/
>
>
> Testing
> -------
>
> We have checked the XML formatting and syntax higlighting by creating sample workflows.
>
>
> Thanks,
>
> venkat sairam
>
>
Re: Review Request 55123: Need to highlight XML tags in preview xml
viewer
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55123/#review160326
-----------------------------------------------------------
Ship it!
Ship It!
- Gaurav Nagar
On Jan. 2, 2017, 2:26 p.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55123/
> -----------------------------------------------------------
>
> (Updated Jan. 2, 2017, 2:26 p.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, Prabhjyot Singh, and Renjith Kamath.
>
>
> Bugs: AMBARI-19334
> https://issues.apache.org/jira/browse/AMBARI-19334
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added codemirror configuration for XML preview
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/ember-cli-build.js 5dfb87c
>
> Diff: https://reviews.apache.org/r/55123/diff/
>
>
> Testing
> -------
>
> We have checked the XML formatting and syntax higlighting by creating sample workflows.
>
>
> Thanks,
>
> venkat sairam
>
>
Re: Review Request 55123: Need to highlight XML tags in preview xml
viewer
Posted by venkat sairam <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55123/
-----------------------------------------------------------
(Updated Jan. 2, 2017, 2:26 p.m.)
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, Prabhjyot Singh, and Renjith Kamath.
Bugs: AMBARI-19334
https://issues.apache.org/jira/browse/AMBARI-19334
Repository: ambari
Description
-------
Added codemirror configuration for XML preview
Diffs
-----
contrib/views/wfmanager/src/main/resources/ui/ember-cli-build.js 5dfb87c
Diff: https://reviews.apache.org/r/55123/diff/
Testing
-------
We have checked the XML formatting and syntax higlighting by creating sample workflows.
Thanks,
venkat sairam