You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@reef.apache.org by yu...@apache.org on 2017/01/12 16:28:25 UTC
reef git commit: [REEF-1711] Better toString() and logging in Wake
components
Repository: reef
Updated Branches:
refs/heads/master 559f489c6 -> a85effcb1
[REEF-1711] Better toString() and logging in Wake components
Implement better `.toString()` method in the `RemoteManager` and `HandlerContainer` classes
JIRA: [REEF-1711](https://issues.apache.org/jira/browse/REEF-1711)
Closes #1225
Project: http://git-wip-us.apache.org/repos/asf/reef/repo
Commit: http://git-wip-us.apache.org/repos/asf/reef/commit/a85effcb
Tree: http://git-wip-us.apache.org/repos/asf/reef/tree/a85effcb
Diff: http://git-wip-us.apache.org/repos/asf/reef/diff/a85effcb
Branch: refs/heads/master
Commit: a85effcb138319692571c5abed205fdb0ffc434a
Parents: 559f489
Author: Sergiy Matusevych <mo...@apache.org>
Authored: Wed Jan 11 17:37:55 2017 -0800
Committer: Yunseong Lee <yu...@apache.org>
Committed: Fri Jan 13 01:27:25 2017 +0900
----------------------------------------------------------------------
.../remote/impl/DefaultRemoteManagerImplementation.java | 3 +--
.../org/apache/reef/wake/remote/impl/HandlerContainer.java | 9 +++++++--
2 files changed, 8 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/reef/blob/a85effcb/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/DefaultRemoteManagerImplementation.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/DefaultRemoteManagerImplementation.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/DefaultRemoteManagerImplementation.java
index 243fa31..28681de 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/DefaultRemoteManagerImplementation.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/DefaultRemoteManagerImplementation.java
@@ -235,7 +235,6 @@ public final class DefaultRemoteManagerImplementation implements RemoteManager {
@Override
public String toString() {
- return String.format("RemoteManager: { class:%s, name:%s, id:%s }",
- this.getClass().getCanonicalName(), this.name, this.myIdentifier);
+ return String.format("RemoteManager: { id:%s handler:%s }", this.myIdentifier, this.handlerContainer);
}
}
http://git-wip-us.apache.org/repos/asf/reef/blob/a85effcb/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/HandlerContainer.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/HandlerContainer.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/HandlerContainer.java
index 26a7747..ebe8906 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/HandlerContainer.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/HandlerContainer.java
@@ -56,8 +56,13 @@ final class HandlerContainer<T> implements EventHandler<RemoteEvent<byte[]>> {
this.name = name;
this.codec = codec;
- LOG.log(Level.FINER, "Instantiated HandlerContainer {0} with codec {1}",
- new String[] {this.name, this.codec.getClass().getCanonicalName()});
+ LOG.log(Level.FINER, "Instantiated {0}", this);
+ }
+
+ @Override
+ public String toString() {
+ return String.format("HandlerContainer: {name:%s codec:%s}",
+ this.name, this.codec.getClass().getCanonicalName());
}
void setTransport(final Transport transport) {