You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@bahir.apache.org by ckadner <gi...@git.apache.org> on 2017/12/10 11:19:07 UTC

[GitHub] bahir pull request #58: [BAHIR-152] Enforce License Header in Java Sources

GitHub user ckadner opened a pull request:

    https://github.com/apache/bahir/pull/58

    [BAHIR-152] Enforce License Header in Java Sources

    [BAHIR-152: License header not enforced for Java sources](https://issues.apache.org/jira/browse/BAHIR-152)
    
    Add a `Header` rule to the `checkstyle` configuration to enforce proper
    Apache license headers in `*.java` source files.
    
    A similar `HeaderMatchesChecker` rule already exists in the `scalastyle`
    configuration to enforce the license headers in `*.scala` source files.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ckadner/bahir BAHIR-152_java_license_header

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/bahir/pull/58.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #58
    
----
commit 245db8fc6b45ede6a4a2d3be9740e50a20a29a33
Author: Christian Kadner <ck...@apache.org>
Date:   2017-12-10T11:15:04Z

    [BAHIR-152] Enforce License Header in Java Sources
    
    Add a "Header" rule to the checkstyle configuration to enforce proper
    Apache license headers in Java source files.
    A similar rule ("HeaderMatchesChecker") already exists in the scalastyle
    configuration.
    
    Closes #58

----


---

[GitHub] bahir pull request #58: [BAHIR-152] Enforce License Header in Java Sources

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/bahir/pull/58


---

[GitHub] bahir issue #58: [BAHIR-152] Enforce License Header in Java Sources

Posted by ApacheBahir <gi...@git.apache.org>.

Github user ApacheBahir commented on the issue:

    https://github.com/apache/bahir/pull/58
  
    :white_check_mark: Build successful
     



---

[GitHub] bahir issue #58: [BAHIR-152] Enforce License Header in Java Sources

Posted by ApacheBahir <gi...@git.apache.org>.

Github user ApacheBahir commented on the issue:

    https://github.com/apache/bahir/pull/58
  
    
    Refer to this link for build results (access rights to CI server needed): 
    http://169.45.79.58:8080/job/bahir_spark_pr_builder/121/



---

[GitHub] bahir issue #58: [BAHIR-152] Enforce License Header in Java Sources

Posted by ckadner <gi...@git.apache.org>.

Github user ckadner commented on the issue:

    https://github.com/apache/bahir/pull/58
  
    ok to test


---

[GitHub] bahir issue #58: [BAHIR-152] Enforce License Header in Java Sources

Posted by tedyu <gi...@git.apache.org>.

Github user tedyu commented on the issue:

    https://github.com/apache/bahir/pull/58
  
    lgtm


---

[GitHub] bahir issue #58: [BAHIR-152] Enforce License Header in Java Sources

Posted by ckadner <gi...@git.apache.org>.

Github user ckadner commented on the issue:

    https://github.com/apache/bahir/pull/58
  
    Thanks @tedyu for review and @lresende for merging.


---