You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2015/08/20 13:00:05 UTC
[GitHub] incubator-brooklyn pull request: [BROOKLYN-162] move packages
GitHub user aledsage opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/856
[BROOKLYN-162] move packages
As discussed in https://github.com/apache/incubator-brooklyn/pull/854
See individual commits descriptions for details of changes. Copy-pasted below for your convenience.
commit e7420b1e4194cbe597a9d467bddc1a197804af50
Author: Aled Sage <al...@gmail.com>
Date: Thu Aug 20 11:32:42 2015 +0100
move WindowsPerformanceCounterSensors to o.a.b.core.sensor.windows
- Was previously in software-base, in o.a.b.sensor.winrm.
- Renamed to .windows to be consistent with .feed.windows
- Moved to core to be consistent with .sensor.ssh and .sensor.http
commit 1dde632fe624e1efec91573715c9470e12fd18e9
Author: Aled Sage <al...@gmail.com>
Date: Thu Aug 20 11:27:20 2015 +0100
Move HttpRequestSensor to o.a.b.core.sensor.http
commit 080d2de0806f5524886b4d6d8bfea7c71a45dbc7
Author: Aled Sage <al...@gmail.com>
Date: Thu Aug 20 11:24:20 2015 +0100
Move o.a.b.sensor.ssh contents to core
- Moved SshCommandEffector (which strangely was in .sensor.ssh) to
o.a.b.core.effector.ssh
- Moved SshCommandSensor (which strangely was in .sensor.ssh) to
o.a.b.core.sensor.ssh
- Changed these classes to reference config in BrooklynConfigKeys,
rather than in SoftwareProcess.*
- Added BrooklynConfigKeys.SHELL_ENVIRONMENT, which SoftwareProcess
now uses.
- Made SshCommandSensor.makeCommandExecutingInDirectory public and
marked as @Beta (was previously static package-private, for use
by SshCommandEffector as well).
- Split SshCommandIntegrationTest into two:
- SshCommandEffectorIntegrationTest (and removed unnecessary tempFile
creation)
- SshCommandSensorIntegrationTest (and moved tempFile creation/deletion
into setUp/tearDown)
commit 8e439bdb398e12d12c4c7d5aeff31497207be742
Author: Aled Sage <al...@gmail.com>
Date: Thu Aug 20 10:47:38 2015 +0100
Move HasBrooklynManagementContext to o.a.b.core.mgmt
- Was previously in o.a.b.camp.brooklyn.api, in the core module
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/incubator-brooklyn refactor/move-packages-20150820
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/856.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #856
----
commit 8e439bdb398e12d12c4c7d5aeff31497207be742
Author: Aled Sage <al...@gmail.com>
Date: 2015-08-20T09:47:38Z
Move HasBrooklynManagementContext to o.a.b.core.mgmt
- Was previously in o.a.b.camp.brooklyn.api, in the core module
commit 080d2de0806f5524886b4d6d8bfea7c71a45dbc7
Author: Aled Sage <al...@gmail.com>
Date: 2015-08-20T10:24:20Z
Move o.a.b.sensor.ssh contents to core
- Moved SshCommandEffector (which strangely was in .sensor.ssh) to
o.a.b.core.effector.ssh
- Moved SshCommandSensor (which strangely was in .sensor.ssh) to
o.a.b.core.sensor.ssh
- Changed these classes to reference config in BrooklynConfigKeys,
rather than in SoftwareProcess.*
- Added BrooklynConfigKeys.SHELL_ENVIRONMENT, which SoftwareProcess
now uses.
- Made SshCommandSensor.makeCommandExecutingInDirectory public and
marked as @Beta (was previously static package-private, for use
by SshCommandEffector as well).
- Split SshCommandIntegrationTest into two:
- SshCommandEffectorIntegrationTest (and removed unnecessary tempFile
creation)
- SshCommandSensorIntegrationTest (and moved tempFile creation/deletion
into setUp/tearDown)
commit 1dde632fe624e1efec91573715c9470e12fd18e9
Author: Aled Sage <al...@gmail.com>
Date: 2015-08-20T10:27:20Z
Move HttpRequestSensor to o.a.b.core.sensor.http
commit e7420b1e4194cbe597a9d467bddc1a197804af50
Author: Aled Sage <al...@gmail.com>
Date: 2015-08-20T10:32:42Z
move WindowsPerformanceCounterSensors to o.a.b.core.sensor.windows
- Was previously in software-base, in o.a.b.sensor.winrm.
- Renamed to .windows to be consistent with .feed.windows
- Moved to core to be consistent with .sensor.ssh and .sensor.http
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: [BROOKLYN-162] move packages
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/856#issuecomment-132986626
looks great, merging.
i don't like the way related items are split up e.g. `Windows*` spread across a sub-package `windows` in different parents `o.a.b.feed` and `o.a.b.core.sensor`.
however rather than resolving this with higher-level `windows` namespace inside `core` (which i was doing, but you've talked me out of it) i think we should resolve this with finer granular projects, so there is e.g. `o.a.b.ecosystem.windows` which contains windows-specific things. this would justify osgi hierarchy dominating most things as osgi project and product area become more closely aligned. (somehow we'll have to manage the package transition but we will find a way!)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: [BROOKLYN-162] move packages
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/856
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: [BROOKLYN-162] move packages
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/856#issuecomment-132987110
not immediately btw -- the osgi project expansion can wait for a while, maybe after 1.0. @hzbarcea tells me we can have multiple repos at apache within this project (that is distinct from *apache* sub-projects), so we could e.g. move things like chef and windows etc into a `brooklyn-ecosystems` repo.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---