[GitHub] [flume] busbey commented on a diff in pull request #351: FLUME-3415 - Provide Docker image for Flume

[GitBox <gi...@apache.org>]

busbey commented on code in PR #351:
URL: https://github.com/apache/flume/pull/351#discussion_r1009529057


##########
.github/workflows/build.yml:
##########
@@ -65,14 +65,34 @@ jobs:
       - name: Show disk usage before maven
         run: df -kh
 
-      - name: Build with Maven
-        timeout-minutes: 120
+      - name: Build with Maven (Linux)
+        if: runner.os == 'Linux'
+        timeout-minutes: 90
         shell: bash
         run: |
           ./mvnw clean verify -DredirectTestOutput=true \
           --show-version --batch-mode --errors --no-transfer-progress \
           -DtrimStackTrace=false \
           -Dsurefire.rerunFailingTestsCount=2
+
+      - name: Deploy Docker (Linux)
+        if: runner.os == 'Linux' && github.ref == 'refs/heads/trunk'
+        timeout-minutes: 90
+        shell: bash
+        run: |
+          ./mvnw deploy -Ddockerfile.username=$${{ secrets.DOCKERHUB_USER }} \
+           -Ddockerfile.password=... $${{ secrets.DOCKERHUB_TOKEN }}
+

Review Comment:
   We shouldn't be publishing snapshot builds of trunk to DockerHub. Can we make sure we're only publishing released artifacts?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@flume.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org