[GitHub] [spark] HyukjinKwon commented on a diff in pull request #41947: [SPARK-44217][PYTHON] Allow custom precision for fp approx equality

["HyukjinKwon (via GitHub)" <gi...@apache.org>]

HyukjinKwon commented on code in PR #41947:
URL: https://github.com/apache/spark/pull/41947#discussion_r1261940266


##########
python/pyspark/testing/utils.py:
##########
@@ -221,7 +221,13 @@ def check_error(
         )
 
 
-def assertDataFrameEqual(df: DataFrame, expected: DataFrame, check_row_order: bool = False):
+def assertDataFrameEqual(
+    df: DataFrame,
+    expected: DataFrame,
+    check_row_order: bool = False,

Review Comment:
   While we're here, I think we should remove `check_row_order`. We don't really guarantee the order in Spark Dataframe.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org