You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2025/03/25 02:52:42 UTC

[kudu-CR] [tserver] fix result status handling

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22660


Change subject: [tserver] fix result status handling
......................................................................

[tserver] fix result status handling

This patch addresses sloppy result handling of functions/methods
that return Status under the src/kudu/tserver directory.

Change-Id: If40eb0a273b13dc3b91817fc74a95a0dd99569a1
---
M src/kudu/tserver/heartbeater.cc
M src/kudu/tserver/tablet_copy_client-test.cc
M src/kudu/tserver/tablet_copy_source_session-test.cc
M src/kudu/tserver/tablet_server-test-base.cc
M src/kudu/tserver/tablet_server-test-base.h
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/tablet_server_authorization-test.cc
M src/kudu/tserver/ts_tablet_manager.cc
8 files changed, 79 insertions(+), 53 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/22660/1
-- 
To view, visit http://gerrit.cloudera.org:8080/22660
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If40eb0a273b13dc3b91817fc74a95a0dd99569a1
Gerrit-Change-Number: 22660
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR] [tserver] fix result status handling

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22660 )

Change subject: [tserver] fix result status handling
......................................................................


Patch Set 2:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1201/


-- 
To view, visit http://gerrit.cloudera.org:8080/22660
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If40eb0a273b13dc3b91817fc74a95a0dd99569a1
Gerrit-Change-Number: 22660
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 25 Mar 2025 17:26:50 +0000
Gerrit-HasComments: No

[kudu-CR] [tserver] fix result status handling

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22660 )

Change subject: [tserver] fix result status handling
......................................................................

[tserver] fix result status handling

This patch addresses sloppy result handling of functions/methods
that return Status under the src/kudu/tserver directory.

Change-Id: If40eb0a273b13dc3b91817fc74a95a0dd99569a1
Reviewed-on: http://gerrit.cloudera.org:8080/22660
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Marton Greber <gr...@gmail.com>
---
M src/kudu/tserver/heartbeater.cc
M src/kudu/tserver/tablet_copy_client-test.cc
M src/kudu/tserver/tablet_copy_source_session-test.cc
M src/kudu/tserver/tablet_server-test-base.cc
M src/kudu/tserver/tablet_server-test-base.h
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/tablet_server_authorization-test.cc
M src/kudu/tserver/ts_tablet_manager.cc
8 files changed, 80 insertions(+), 53 deletions(-)

Approvals:
  Alexey Serbin: Verified
  Marton Greber: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/22660
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If40eb0a273b13dc3b91817fc74a95a0dd99569a1
Gerrit-Change-Number: 22660
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>

[kudu-CR] [tserver] fix result status handling

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22660 )

Change subject: [tserver] fix result status handling
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1200/


-- 
To view, visit http://gerrit.cloudera.org:8080/22660
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If40eb0a273b13dc3b91817fc74a95a0dd99569a1
Gerrit-Change-Number: 22660
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 25 Mar 2025 02:52:52 +0000
Gerrit-HasComments: No

[kudu-CR] [tserver] fix result status handling

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22660 )

Change subject: [tserver] fix result status handling
......................................................................


Patch Set 2: Verified+1

unrelated test failures:
  * ASAN: KUDU-3065
  * TSAN: RemoteKsckTest.TestLeaderMasterDown


-- 
To view, visit http://gerrit.cloudera.org:8080/22660
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If40eb0a273b13dc3b91817fc74a95a0dd99569a1
Gerrit-Change-Number: 22660
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 25 Mar 2025 19:41:06 +0000
Gerrit-HasComments: No

[kudu-CR] [tserver] fix result status handling

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: [tserver] fix result status handling
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/22660
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: If40eb0a273b13dc3b91817fc74a95a0dd99569a1
Gerrit-Change-Number: 22660
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>

[kudu-CR] [tserver] fix result status handling

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Kudu Jenkins, Abhishek Chennaka, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22660

to look at the new patch set (#2).

Change subject: [tserver] fix result status handling
......................................................................

[tserver] fix result status handling

This patch addresses sloppy result handling of functions/methods
that return Status under the src/kudu/tserver directory.

Change-Id: If40eb0a273b13dc3b91817fc74a95a0dd99569a1
---
M src/kudu/tserver/heartbeater.cc
M src/kudu/tserver/tablet_copy_client-test.cc
M src/kudu/tserver/tablet_copy_source_session-test.cc
M src/kudu/tserver/tablet_server-test-base.cc
M src/kudu/tserver/tablet_server-test-base.h
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/tablet_server_authorization-test.cc
M src/kudu/tserver/ts_tablet_manager.cc
8 files changed, 80 insertions(+), 53 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/22660/2
-- 
To view, visit http://gerrit.cloudera.org:8080/22660
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If40eb0a273b13dc3b91817fc74a95a0dd99569a1
Gerrit-Change-Number: 22660
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>

[kudu-CR] [tserver] fix result status handling

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22660 )

Change subject: [tserver] fix result status handling
......................................................................


Patch Set 2: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1201/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/22660
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If40eb0a273b13dc3b91817fc74a95a0dd99569a1
Gerrit-Change-Number: 22660
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 25 Mar 2025 18:47:50 +0000
Gerrit-HasComments: No

[kudu-CR] [tserver] fix result status handling

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22660 )

Change subject: [tserver] fix result status handling
......................................................................


Patch Set 1: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1200/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/22660
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If40eb0a273b13dc3b91817fc74a95a0dd99569a1
Gerrit-Change-Number: 22660
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 25 Mar 2025 03:03:24 +0000
Gerrit-HasComments: No

[kudu-CR] [tserver] fix result status handling

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/22660 )

Change subject: [tserver] fix result status handling
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/22660
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If40eb0a273b13dc3b91817fc74a95a0dd99569a1
Gerrit-Change-Number: 22660
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Wed, 26 Mar 2025 10:33:57 +0000
Gerrit-HasComments: No