You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kevin Klues <kl...@gmail.com> on 2016/04/05 01:41:43 UTC
Re: Review Request 44364: Added tests for the Nvidia GPU isolator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44364/
-----------------------------------------------------------
(Updated April 4, 2016, 11:41 p.m.)
Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya.
Changes
-------
Added a more complete test to actually test that GPUs can be added to a container and accessed via 'nvidia-smi'
Summary (updated)
-----------------
Added tests for the Nvidia GPU isolator.
Bugs: MESOS-4863
https://issues.apache.org/jira/browse/MESOS-4863
Repository: mesos
Description (updated)
-------
This commit also includes a test filter called 'NvidiaGpuFilter' that
checks for the existence of 'nvidia-smi' before running any tests that
contain the 'NVIDIA_GPU_' prefix.
Diffs (updated)
-----
src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2
src/tests/containerizer/nvidia_gpu_isolator_tests.cpp PRE-CREATION
src/tests/environment.cpp 90dbe9488bda6af26143934e196aab0d69dccec3
Diff: https://reviews.apache.org/r/44364/diff/
Testing (updated)
-------
On an Nvidia GPU equipped machine:
```
sudo GTEST_FILTER="NvidiaGpuTest.ROOT_CGROUPS_NVIDIA_GPU_VerifyDeviceAccess" bin/mesos-tests.sh
SUCCESS
```
On a **non** Nvidia GPU equipped machine:
```
sudo GTEST_FILTER="NvidiaGpuTest.ROOT_CGROUPS_NVIDIA_GPU_VerifyDeviceAccess" bin/mesos-tests.sh
which: no nvidia-smi in (/sbin:/bin:/usr/sbin:/usr/bin)
--------------------------------------------------------------
No 'nvidia-smi' command found so no 'NvidiaGpu' tests will run
--------------------------------------------------------------
```
Thanks,
Kevin Klues
Re: Review Request 44364: Added tests for the Nvidia GPU isolator.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44364/
-----------------------------------------------------------
(Updated April 6, 2016, 12:38 a.m.)
Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya.
Changes
-------
Addressed all of bmahler's comments.
Bugs: MESOS-4863
https://issues.apache.org/jira/browse/MESOS-4863
Repository: mesos
Description
-------
This commit also includes a test filter called 'NvidiaGpuFilter' that
checks for the existence of 'nvidia-smi' before running any tests that
contain the 'NVIDIA_GPU_' prefix.
Diffs (updated)
-----
src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2
src/tests/containerizer/nvidia_gpu_isolator_tests.cpp PRE-CREATION
src/tests/environment.cpp 90dbe9488bda6af26143934e196aab0d69dccec3
Diff: https://reviews.apache.org/r/44364/diff/
Testing
-------
On an Nvidia GPU equipped machine:
```
sudo GTEST_FILTER="NvidiaGpuTest.ROOT_CGROUPS_NVIDIA_GPU_VerifyDeviceAccess" bin/mesos-tests.sh
SUCCESS
```
On a **non** Nvidia GPU equipped machine:
```
sudo GTEST_FILTER="NvidiaGpuTest.ROOT_CGROUPS_NVIDIA_GPU_VerifyDeviceAccess" bin/mesos-tests.sh
which: no nvidia-smi in (/sbin:/bin:/usr/sbin:/usr/bin)
--------------------------------------------------------------
No 'nvidia-smi' command found so no 'NvidiaGpu' tests will run
--------------------------------------------------------------
```
Thanks,
Kevin Klues
Re: Review Request 44364: Added tests for the Nvidia GPU isolator.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44364/#review127243
-----------------------------------------------------------
Fix it, then Ship it!
Nice test!
src/tests/containerizer/nvidia_gpu_isolator_tests.cpp (line 62)
<https://reviews.apache.org/r/44364/#comment190434>
Could we have a summary comment?
src/tests/containerizer/nvidia_gpu_isolator_tests.cpp (line 70)
<https://reviews.apache.org/r/44364/#comment190441>
s/std:://
src/tests/containerizer/nvidia_gpu_isolator_tests.cpp (lines 73 - 79)
<https://reviews.apache.org/r/44364/#comment190459>
We shouldn't need the fetcher and containerizer here.
src/tests/containerizer/nvidia_gpu_isolator_tests.cpp (lines 137 - 140)
<https://reviews.apache.org/r/44364/#comment190465>
Could we put newlines in the string so that it prints pretty?
src/tests/containerizer/nvidia_gpu_isolator_tests.cpp (line 150)
<https://reviews.apache.org/r/44364/#comment190450>
Can you sweep for s/.get()./->/ ?
src/tests/environment.cpp (lines 254 - 276)
<https://reviews.apache.org/r/44364/#comment190433>
It's unfortunate that the curl filter used "error" to express existence, could we do a s/error/exists/ here? I'd also be ok shipping a patch for the curl filter if you want to take that on.
- Ben Mahler
On April 4, 2016, 11:41 p.m., Kevin Klues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44364/
> -----------------------------------------------------------
>
> (Updated April 4, 2016, 11:41 p.m.)
>
>
> Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya.
>
>
> Bugs: MESOS-4863
> https://issues.apache.org/jira/browse/MESOS-4863
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit also includes a test filter called 'NvidiaGpuFilter' that
> checks for the existence of 'nvidia-smi' before running any tests that
> contain the 'NVIDIA_GPU_' prefix.
>
>
> Diffs
> -----
>
> src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2
> src/tests/containerizer/nvidia_gpu_isolator_tests.cpp PRE-CREATION
> src/tests/environment.cpp 90dbe9488bda6af26143934e196aab0d69dccec3
>
> Diff: https://reviews.apache.org/r/44364/diff/
>
>
> Testing
> -------
>
> On an Nvidia GPU equipped machine:
>
> ```
> sudo GTEST_FILTER="NvidiaGpuTest.ROOT_CGROUPS_NVIDIA_GPU_VerifyDeviceAccess" bin/mesos-tests.sh
>
> SUCCESS
> ```
>
> On a **non** Nvidia GPU equipped machine:
>
> ```
> sudo GTEST_FILTER="NvidiaGpuTest.ROOT_CGROUPS_NVIDIA_GPU_VerifyDeviceAccess" bin/mesos-tests.sh
>
> which: no nvidia-smi in (/sbin:/bin:/usr/sbin:/usr/bin)
> --------------------------------------------------------------
> No 'nvidia-smi' command found so no 'NvidiaGpu' tests will run
> --------------------------------------------------------------
> ```
>
>
> Thanks,
>
> Kevin Klues
>
>