You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by Sean Mackrory <ma...@gmail.com> on 2013/02/01 22:53:42 UTC
Review Request: BIGTOP-805: Upgrading to Sqoop 2 (and using a generic init
script template adapted from Hadoop's services)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9264/
-----------------------------------------------------------
Review request for bigtop and Jarek Cecho.
Description
-------
This patch upgrades Sqoop from the 1.x series to the 2.x series (that is currently actually at 1.99.1). The new architecture consists of a lightweight client and a centralized server. I've also adapted the init script template used by the Hadoop services and used it for sqoop-server. It's available for all subsequent components that want to make use of it - should make it easier to solve common bugs and be consistent.
This addresses bug BIGTOP-805.
https://issues.apache.org/jira/browse/BIGTOP-805
Diffs
-----
bigtop-packages/src/common/sqoop/catalina.properties PRE-CREATION
bigtop-packages/src/common/sqoop/catalina.properties.mr1 PRE-CREATION
bigtop-packages/src/common/sqoop/do-component-build 42a2442
bigtop-packages/src/common/sqoop/install_sqoop.sh e752c4e
bigtop-packages/src/common/sqoop/setenv.sh PRE-CREATION
bigtop-packages/src/common/sqoop/sqoop-env.sh PRE-CREATION
bigtop-packages/src/common/sqoop/sqoop-metastore.sh ab22ef3
bigtop-packages/src/common/sqoop/sqoop-metastore.sh.suse bcc1fef
bigtop-packages/src/common/sqoop/sqoop-server.svc PRE-CREATION
bigtop-packages/src/common/sqoop/sqoop.properties PRE-CREATION
bigtop-packages/src/common/sqoop/sqoop.sh PRE-CREATION
bigtop-packages/src/deb/sqoop/compat 7f8f011
bigtop-packages/src/deb/sqoop/control dcc6106
bigtop-packages/src/deb/sqoop/copyright ec176a9
bigtop-packages/src/deb/sqoop/rules 7992dcd
bigtop-packages/src/deb/sqoop/sqoop-client.install PRE-CREATION
bigtop-packages/src/deb/sqoop/sqoop-metastore.postinst b8b6635
bigtop-packages/src/deb/sqoop/sqoop-metastore.preinst 76cfb26
bigtop-packages/src/deb/sqoop/sqoop-server.install PRE-CREATION
bigtop-packages/src/deb/sqoop/sqoop-server.postinst PRE-CREATION
bigtop-packages/src/deb/sqoop/sqoop.install PRE-CREATION
bigtop-packages/src/deb/sqoop/sqoop.postinst 37cae7e
bigtop-packages/src/deb/sqoop/sqoop.preinst PRE-CREATION
bigtop-packages/src/deb/sqoop/sqoop.prerm b9a25a5
bigtop-packages/src/rpm/sqoop/SPECS/sqoop.spec 9774326
bigtop-packages/src/templates/init.d.tmpl PRE-CREATION
bigtop.mk 96f2257
package.mk 8e45771
Diff: https://reviews.apache.org/r/9264/diff/
Testing
-------
I've tested this exact patch on Fedora 17 and Ubuntu Precise, and previous iterations (without significant differences) on RHEL 5, RHEL 6, and Ubuntu Lucid.
Thanks,
Sean Mackrory
Re: Review Request: BIGTOP-805: Upgrading to Sqoop 2 (and using a generic
init script template adapted from Hadoop's services)
Posted by Sean Mackrory <ma...@gmail.com>.
> On Feb. 2, 2013, 1:27 a.m., Jarek Cecho wrote:
> > bigtop-packages/src/common/sqoop/setenv.sh, line 17
> > <https://reviews.apache.org/r/9264/diff/1/?file=254771#file254771line17>
> >
> > I'm wondering where is this script being executed? I did not found it's reference anywhere other than installation files.
Tomcat checks for a file with this name and executes it if it exists on start up.
> On Feb. 2, 2013, 1:27 a.m., Jarek Cecho wrote:
> > bigtop-packages/src/common/sqoop/do-component-build, line 19
> > <https://reviews.apache.org/r/9264/diff/1/?file=254769#file254769line19>
> >
> > Calling the "site" target should not be necessary here. Also we might want to explicitly add -Dhadoop.profile=200 so that it will build against Hadoop 2.0.0. I know that it's current default, but that might change and cause unnecessary issues.
Will incorporate both suggestions in the next patch. I believe something is messed up with sphinx in my environment because it's working fine without site on a couple of VMs.
- Sean
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9264/#review16034
-----------------------------------------------------------
On Feb. 1, 2013, 9:53 p.m., Sean Mackrory wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9264/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2013, 9:53 p.m.)
>
>
> Review request for bigtop and Jarek Cecho.
>
>
> Description
> -------
>
> This patch upgrades Sqoop from the 1.x series to the 2.x series (that is currently actually at 1.99.1). The new architecture consists of a lightweight client and a centralized server. I've also adapted the init script template used by the Hadoop services and used it for sqoop-server. It's available for all subsequent components that want to make use of it - should make it easier to solve common bugs and be consistent.
>
>
> This addresses bug BIGTOP-805.
> https://issues.apache.org/jira/browse/BIGTOP-805
>
>
> Diffs
> -----
>
> bigtop-packages/src/common/sqoop/catalina.properties PRE-CREATION
> bigtop-packages/src/common/sqoop/catalina.properties.mr1 PRE-CREATION
> bigtop-packages/src/common/sqoop/do-component-build 42a2442
> bigtop-packages/src/common/sqoop/install_sqoop.sh e752c4e
> bigtop-packages/src/common/sqoop/setenv.sh PRE-CREATION
> bigtop-packages/src/common/sqoop/sqoop-env.sh PRE-CREATION
> bigtop-packages/src/common/sqoop/sqoop-metastore.sh ab22ef3
> bigtop-packages/src/common/sqoop/sqoop-metastore.sh.suse bcc1fef
> bigtop-packages/src/common/sqoop/sqoop-server.svc PRE-CREATION
> bigtop-packages/src/common/sqoop/sqoop.properties PRE-CREATION
> bigtop-packages/src/common/sqoop/sqoop.sh PRE-CREATION
> bigtop-packages/src/deb/sqoop/compat 7f8f011
> bigtop-packages/src/deb/sqoop/control dcc6106
> bigtop-packages/src/deb/sqoop/copyright ec176a9
> bigtop-packages/src/deb/sqoop/rules 7992dcd
> bigtop-packages/src/deb/sqoop/sqoop-client.install PRE-CREATION
> bigtop-packages/src/deb/sqoop/sqoop-metastore.postinst b8b6635
> bigtop-packages/src/deb/sqoop/sqoop-metastore.preinst 76cfb26
> bigtop-packages/src/deb/sqoop/sqoop-server.install PRE-CREATION
> bigtop-packages/src/deb/sqoop/sqoop-server.postinst PRE-CREATION
> bigtop-packages/src/deb/sqoop/sqoop.install PRE-CREATION
> bigtop-packages/src/deb/sqoop/sqoop.postinst 37cae7e
> bigtop-packages/src/deb/sqoop/sqoop.preinst PRE-CREATION
> bigtop-packages/src/deb/sqoop/sqoop.prerm b9a25a5
> bigtop-packages/src/rpm/sqoop/SPECS/sqoop.spec 9774326
> bigtop-packages/src/templates/init.d.tmpl PRE-CREATION
> bigtop.mk 96f2257
> package.mk 8e45771
>
> Diff: https://reviews.apache.org/r/9264/diff/
>
>
> Testing
> -------
>
> I've tested this exact patch on Fedora 17 and Ubuntu Precise, and previous iterations (without significant differences) on RHEL 5, RHEL 6, and Ubuntu Lucid.
>
>
> Thanks,
>
> Sean Mackrory
>
>
Re: Review Request: BIGTOP-805: Upgrading to Sqoop 2 (and using a generic
init script template adapted from Hadoop's services)
Posted by Jarek Cecho <ja...@apache.org>.
> On Feb. 2, 2013, 1:27 a.m., Jarek Cecho wrote:
> > bigtop-packages/src/common/sqoop/do-component-build, line 19
> > <https://reviews.apache.org/r/9264/diff/1/?file=254769#file254769line19>
> >
> > Calling the "site" target should not be necessary here. Also we might want to explicitly add -Dhadoop.profile=200 so that it will build against Hadoop 2.0.0. I know that it's current default, but that might change and cause unnecessary issues.
>
> Sean Mackrory wrote:
> Will incorporate both suggestions in the next patch. I believe something is messed up with sphinx in my environment because it's working fine without site on a couple of VMs.
> On Feb. 2, 2013, 1:27 a.m., Jarek Cecho wrote:
> > bigtop-packages/src/common/sqoop/setenv.sh, line 17
> > <https://reviews.apache.org/r/9264/diff/1/?file=254771#file254771line17>
> >
> > I'm wondering where is this script being executed? I did not found it's reference anywhere other than installation files.
>
> Sean Mackrory wrote:
> Tomcat checks for a file with this name and executes it if it exists on start up.
I see, thank you for explanation sir.
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9264/#review16034
-----------------------------------------------------------
On Feb. 4, 2013, 7:32 p.m., Sean Mackrory wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9264/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2013, 7:32 p.m.)
>
>
> Review request for bigtop and Jarek Cecho.
>
>
> Description
> -------
>
> This patch upgrades Sqoop from the 1.x series to the 2.x series (that is currently actually at 1.99.1). The new architecture consists of a lightweight client and a centralized server. I've also adapted the init script template used by the Hadoop services and used it for sqoop-server. It's available for all subsequent components that want to make use of it - should make it easier to solve common bugs and be consistent.
>
>
> This addresses bug BIGTOP-805.
> https://issues.apache.org/jira/browse/BIGTOP-805
>
>
> Diffs
> -----
>
> bigtop-packages/src/common/sqoop/catalina.properties PRE-CREATION
> bigtop-packages/src/common/sqoop/catalina.properties.mr1 PRE-CREATION
> bigtop-packages/src/common/sqoop/do-component-build 42a2442
> bigtop-packages/src/common/sqoop/install_sqoop.sh e752c4e
> bigtop-packages/src/common/sqoop/setenv.sh PRE-CREATION
> bigtop-packages/src/common/sqoop/sqoop-env.sh PRE-CREATION
> bigtop-packages/src/common/sqoop/sqoop-metastore.sh ab22ef3
> bigtop-packages/src/common/sqoop/sqoop-metastore.sh.suse bcc1fef
> bigtop-packages/src/common/sqoop/sqoop-server.svc PRE-CREATION
> bigtop-packages/src/common/sqoop/sqoop.properties PRE-CREATION
> bigtop-packages/src/common/sqoop/sqoop.sh PRE-CREATION
> bigtop-packages/src/deb/sqoop/compat 7f8f011
> bigtop-packages/src/deb/sqoop/control dcc6106
> bigtop-packages/src/deb/sqoop/copyright ec176a9
> bigtop-packages/src/deb/sqoop/rules 7992dcd
> bigtop-packages/src/deb/sqoop/sqoop-client.install PRE-CREATION
> bigtop-packages/src/deb/sqoop/sqoop-metastore.postinst b8b6635
> bigtop-packages/src/deb/sqoop/sqoop-metastore.preinst 76cfb26
> bigtop-packages/src/deb/sqoop/sqoop-server.install PRE-CREATION
> bigtop-packages/src/deb/sqoop/sqoop-server.postinst PRE-CREATION
> bigtop-packages/src/deb/sqoop/sqoop.install PRE-CREATION
> bigtop-packages/src/deb/sqoop/sqoop.postinst 37cae7e
> bigtop-packages/src/deb/sqoop/sqoop.preinst PRE-CREATION
> bigtop-packages/src/deb/sqoop/sqoop.prerm b9a25a5
> bigtop-packages/src/rpm/sqoop/SPECS/sqoop.spec 9774326
> bigtop-packages/src/templates/init.d.tmpl PRE-CREATION
> bigtop.mk 96f2257
> package.mk 8e45771
>
> Diff: https://reviews.apache.org/r/9264/diff/
>
>
> Testing
> -------
>
> I've tested this exact patch on Fedora 17 and Ubuntu Precise, and previous iterations (without significant differences) on RHEL 5, RHEL 6, and Ubuntu Lucid.
>
>
> Thanks,
>
> Sean Mackrory
>
>
Re: Review Request: BIGTOP-805: Upgrading to Sqoop 2 (and using a generic
init script template adapted from Hadoop's services)
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9264/#review16034
-----------------------------------------------------------
Hi Sean,
thank you very much for putting this together. I would +1 from Sqoop side, though I won't hit the "Ship It" button as I do not understand all details well enough. I've noticed that there is a lot of trailing white space characters. Most of the projects I know don't like that - I'm not sure about BIGTOP, so just saying.
bigtop-packages/src/common/sqoop/do-component-build
<https://reviews.apache.org/r/9264/#comment34339>
Calling the "site" target should not be necessary here. Also we might want to explicitly add -Dhadoop.profile=200 so that it will build against Hadoop 2.0.0. I know that it's current default, but that might change and cause unnecessary issues.
bigtop-packages/src/common/sqoop/setenv.sh
<https://reviews.apache.org/r/9264/#comment34340>
I'm wondering where is this script being executed? I did not found it's reference anywhere other than installation files.
Jarcec
- Jarek Cecho
On Feb. 1, 2013, 9:53 p.m., Sean Mackrory wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9264/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2013, 9:53 p.m.)
>
>
> Review request for bigtop and Jarek Cecho.
>
>
> Description
> -------
>
> This patch upgrades Sqoop from the 1.x series to the 2.x series (that is currently actually at 1.99.1). The new architecture consists of a lightweight client and a centralized server. I've also adapted the init script template used by the Hadoop services and used it for sqoop-server. It's available for all subsequent components that want to make use of it - should make it easier to solve common bugs and be consistent.
>
>
> This addresses bug BIGTOP-805.
> https://issues.apache.org/jira/browse/BIGTOP-805
>
>
> Diffs
> -----
>
> bigtop-packages/src/common/sqoop/catalina.properties PRE-CREATION
> bigtop-packages/src/common/sqoop/catalina.properties.mr1 PRE-CREATION
> bigtop-packages/src/common/sqoop/do-component-build 42a2442
> bigtop-packages/src/common/sqoop/install_sqoop.sh e752c4e
> bigtop-packages/src/common/sqoop/setenv.sh PRE-CREATION
> bigtop-packages/src/common/sqoop/sqoop-env.sh PRE-CREATION
> bigtop-packages/src/common/sqoop/sqoop-metastore.sh ab22ef3
> bigtop-packages/src/common/sqoop/sqoop-metastore.sh.suse bcc1fef
> bigtop-packages/src/common/sqoop/sqoop-server.svc PRE-CREATION
> bigtop-packages/src/common/sqoop/sqoop.properties PRE-CREATION
> bigtop-packages/src/common/sqoop/sqoop.sh PRE-CREATION
> bigtop-packages/src/deb/sqoop/compat 7f8f011
> bigtop-packages/src/deb/sqoop/control dcc6106
> bigtop-packages/src/deb/sqoop/copyright ec176a9
> bigtop-packages/src/deb/sqoop/rules 7992dcd
> bigtop-packages/src/deb/sqoop/sqoop-client.install PRE-CREATION
> bigtop-packages/src/deb/sqoop/sqoop-metastore.postinst b8b6635
> bigtop-packages/src/deb/sqoop/sqoop-metastore.preinst 76cfb26
> bigtop-packages/src/deb/sqoop/sqoop-server.install PRE-CREATION
> bigtop-packages/src/deb/sqoop/sqoop-server.postinst PRE-CREATION
> bigtop-packages/src/deb/sqoop/sqoop.install PRE-CREATION
> bigtop-packages/src/deb/sqoop/sqoop.postinst 37cae7e
> bigtop-packages/src/deb/sqoop/sqoop.preinst PRE-CREATION
> bigtop-packages/src/deb/sqoop/sqoop.prerm b9a25a5
> bigtop-packages/src/rpm/sqoop/SPECS/sqoop.spec 9774326
> bigtop-packages/src/templates/init.d.tmpl PRE-CREATION
> bigtop.mk 96f2257
> package.mk 8e45771
>
> Diff: https://reviews.apache.org/r/9264/diff/
>
>
> Testing
> -------
>
> I've tested this exact patch on Fedora 17 and Ubuntu Precise, and previous iterations (without significant differences) on RHEL 5, RHEL 6, and Ubuntu Lucid.
>
>
> Thanks,
>
> Sean Mackrory
>
>
Re: Review Request: BIGTOP-805: Upgrading to Sqoop 2 (and using a generic
init script template adapted from Hadoop's services)
Posted by Mark Grover <gr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9264/#review16070
-----------------------------------------------------------
bigtop-packages/src/common/sqoop/catalina.properties.mr1
<https://reviews.apache.org/r/9264/#comment34382>
Do we need this file, given that bigtop only uses MR2/Yarn?
bigtop-packages/src/deb/sqoop/sqoop.prerm
<https://reviews.apache.org/r/9264/#comment34385>
zookeeper?
bigtop-packages/src/rpm/sqoop/SPECS/sqoop.spec
<https://reviews.apache.org/r/9264/#comment34386>
Update URL:-)
- Mark Grover
On Feb. 4, 2013, 8:55 p.m., Sean Mackrory wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9264/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2013, 8:55 p.m.)
>
>
> Review request for bigtop and Jarek Cecho.
>
>
> Description
> -------
>
> This patch upgrades Sqoop from the 1.x series to the 2.x series (that is currently actually at 1.99.1). The new architecture consists of a lightweight client and a centralized server. I've also adapted the init script template used by the Hadoop services and used it for sqoop-server. It's available for all subsequent components that want to make use of it - should make it easier to solve common bugs and be consistent.
>
>
> This addresses bug BIGTOP-805.
> https://issues.apache.org/jira/browse/BIGTOP-805
>
>
> Diffs
> -----
>
> bigtop-packages/src/common/sqoop/catalina.properties PRE-CREATION
> bigtop-packages/src/common/sqoop/catalina.properties.mr1 PRE-CREATION
> bigtop-packages/src/common/sqoop/do-component-build 42a2442
> bigtop-packages/src/common/sqoop/install_sqoop.sh e752c4e
> bigtop-packages/src/common/sqoop/setenv.sh PRE-CREATION
> bigtop-packages/src/common/sqoop/sqoop-env.sh PRE-CREATION
> bigtop-packages/src/common/sqoop/sqoop-metastore.sh ab22ef3
> bigtop-packages/src/common/sqoop/sqoop-metastore.sh.suse bcc1fef
> bigtop-packages/src/common/sqoop/sqoop-server.svc PRE-CREATION
> bigtop-packages/src/common/sqoop/sqoop.properties PRE-CREATION
> bigtop-packages/src/common/sqoop/sqoop.sh PRE-CREATION
> bigtop-packages/src/deb/sqoop/changelog 547ed02
> bigtop-packages/src/deb/sqoop/compat 7f8f011
> bigtop-packages/src/deb/sqoop/control dcc6106
> bigtop-packages/src/deb/sqoop/copyright ec176a9
> bigtop-packages/src/deb/sqoop/rules 7992dcd
> bigtop-packages/src/deb/sqoop/sqoop-client.install PRE-CREATION
> bigtop-packages/src/deb/sqoop/sqoop-metastore.postinst b8b6635
> bigtop-packages/src/deb/sqoop/sqoop-metastore.preinst 76cfb26
> bigtop-packages/src/deb/sqoop/sqoop-server.install PRE-CREATION
> bigtop-packages/src/deb/sqoop/sqoop-server.postinst PRE-CREATION
> bigtop-packages/src/deb/sqoop/sqoop.install PRE-CREATION
> bigtop-packages/src/deb/sqoop/sqoop.postinst 37cae7e
> bigtop-packages/src/deb/sqoop/sqoop.preinst PRE-CREATION
> bigtop-packages/src/deb/sqoop/sqoop.prerm b9a25a5
> bigtop-packages/src/rpm/sqoop/SPECS/sqoop.spec 9774326
> bigtop-packages/src/templates/init.d.tmpl PRE-CREATION
> bigtop.mk 96f2257
> package.mk 8e45771
>
> Diff: https://reviews.apache.org/r/9264/diff/
>
>
> Testing
> -------
>
> I've tested this exact patch on Fedora 17 and Ubuntu Precise, and previous iterations (without significant differences) on RHEL 5, RHEL 6, and Ubuntu Lucid.
>
>
> Thanks,
>
> Sean Mackrory
>
>
Re: Review Request: BIGTOP-805: Upgrading to Sqoop 2 (and using a generic
init script template adapted from Hadoop's services)
Posted by Sean Mackrory <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9264/
-----------------------------------------------------------
(Updated March 15, 2013, 9:04 p.m.)
Review request for bigtop and Jarek Cecho.
Changes
-------
Updating based on feedback from Jarcec and Roman
Description
-------
This patch upgrades Sqoop from the 1.x series to the 2.x series (that is currently actually at 1.99.1). The new architecture consists of a lightweight client and a centralized server. I've also adapted the init script template used by the Hadoop services and used it for sqoop-server. It's available for all subsequent components that want to make use of it - should make it easier to solve common bugs and be consistent.
This addresses bug BIGTOP-805.
https://issues.apache.org/jira/browse/BIGTOP-805
Diffs (updated)
-----
bigtop-packages/src/common/sqoop/catalina.properties PRE-CREATION
bigtop-packages/src/common/sqoop/do-component-build 42a2442
bigtop-packages/src/common/sqoop/install_sqoop.sh 771931a
bigtop-packages/src/common/sqoop/setenv.sh PRE-CREATION
bigtop-packages/src/common/sqoop/sqoop-metastore.sh ab22ef3
bigtop-packages/src/common/sqoop/sqoop-metastore.sh.suse bcc1fef
bigtop-packages/src/common/sqoop/sqoop-server.sh PRE-CREATION
bigtop-packages/src/common/sqoop/sqoop-server.svc PRE-CREATION
bigtop-packages/src/common/sqoop/sqoop.default PRE-CREATION
bigtop-packages/src/common/sqoop/sqoop.properties PRE-CREATION
bigtop-packages/src/common/sqoop/sqoop.sh PRE-CREATION
bigtop-packages/src/deb/sqoop/changelog 547ed02
bigtop-packages/src/deb/sqoop/compat 7f8f011
bigtop-packages/src/deb/sqoop/control dcc6106
bigtop-packages/src/deb/sqoop/copyright ec176a9
bigtop-packages/src/deb/sqoop/rules 7992dcd
bigtop-packages/src/deb/sqoop/sqoop-client.install PRE-CREATION
bigtop-packages/src/deb/sqoop/sqoop-metastore.postinst b8b6635
bigtop-packages/src/deb/sqoop/sqoop-metastore.preinst 76cfb26
bigtop-packages/src/deb/sqoop/sqoop-server.install PRE-CREATION
bigtop-packages/src/deb/sqoop/sqoop-server.postinst PRE-CREATION
bigtop-packages/src/deb/sqoop/sqoop.install PRE-CREATION
bigtop-packages/src/deb/sqoop/sqoop.postinst 37cae7e
bigtop-packages/src/deb/sqoop/sqoop.preinst PRE-CREATION
bigtop-packages/src/deb/sqoop/sqoop.prerm b9a25a5
bigtop-packages/src/rpm/sqoop/SPECS/sqoop.spec 9774326
bigtop-packages/src/templates/init.d.tmpl PRE-CREATION
bigtop.mk 96f2257
package.mk 8e45771
Diff: https://reviews.apache.org/r/9264/diff/
Testing
-------
I've tested this exact patch on Fedora 17 and Ubuntu Precise, and previous iterations (without significant differences) on RHEL 5, RHEL 6, and Ubuntu Lucid.
Thanks,
Sean Mackrory
Re: Review Request: BIGTOP-805: Upgrading to Sqoop 2 (and using a generic
init script template adapted from Hadoop's services)
Posted by Roman Shaposhnik <rv...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9264/#review17980
-----------------------------------------------------------
bigtop-packages/src/common/sqoop/do-component-build
<https://reviews.apache.org/r/9264/#comment37995>
Sean, would it be possible to make sure that all the versions of Hadoop, ZK, etc are bound to the values coming from the Bigtop BOM just like it used to be for the previous version of Sqoop?
- Roman Shaposhnik
On March 14, 2013, 11:55 p.m., Sean Mackrory wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9264/
> -----------------------------------------------------------
>
> (Updated March 14, 2013, 11:55 p.m.)
>
>
> Review request for bigtop and Jarek Cecho.
>
>
> Description
> -------
>
> This patch upgrades Sqoop from the 1.x series to the 2.x series (that is currently actually at 1.99.1). The new architecture consists of a lightweight client and a centralized server. I've also adapted the init script template used by the Hadoop services and used it for sqoop-server. It's available for all subsequent components that want to make use of it - should make it easier to solve common bugs and be consistent.
>
>
> This addresses bug BIGTOP-805.
> https://issues.apache.org/jira/browse/BIGTOP-805
>
>
> Diffs
> -----
>
> BIGTOP-805.3.patch PRE-CREATION
> bigtop-packages/src/common/sqoop/catalina.properties PRE-CREATION
> bigtop-packages/src/common/sqoop/do-component-build 42a2442
> bigtop-packages/src/common/sqoop/install_sqoop.sh 771931a
> bigtop-packages/src/common/sqoop/setenv.sh PRE-CREATION
> bigtop-packages/src/common/sqoop/sqoop-metastore.sh ab22ef3
> bigtop-packages/src/common/sqoop/sqoop-metastore.sh.suse bcc1fef
> bigtop-packages/src/common/sqoop/sqoop-server.sh PRE-CREATION
> bigtop-packages/src/common/sqoop/sqoop-server.svc PRE-CREATION
> bigtop-packages/src/common/sqoop/sqoop.default PRE-CREATION
> bigtop-packages/src/common/sqoop/sqoop.properties PRE-CREATION
> bigtop-packages/src/common/sqoop/sqoop.sh PRE-CREATION
> bigtop-packages/src/deb/sqoop/changelog 547ed02
> bigtop-packages/src/deb/sqoop/compat 7f8f011
> bigtop-packages/src/deb/sqoop/control dcc6106
> bigtop-packages/src/deb/sqoop/copyright ec176a9
> bigtop-packages/src/deb/sqoop/rules 7992dcd
> bigtop-packages/src/deb/sqoop/sqoop-client.install PRE-CREATION
> bigtop-packages/src/deb/sqoop/sqoop-metastore.postinst b8b6635
> bigtop-packages/src/deb/sqoop/sqoop-metastore.preinst 76cfb26
> bigtop-packages/src/deb/sqoop/sqoop-server.install PRE-CREATION
> bigtop-packages/src/deb/sqoop/sqoop-server.postinst PRE-CREATION
> bigtop-packages/src/deb/sqoop/sqoop.install PRE-CREATION
> bigtop-packages/src/deb/sqoop/sqoop.postinst 37cae7e
> bigtop-packages/src/deb/sqoop/sqoop.preinst PRE-CREATION
> bigtop-packages/src/deb/sqoop/sqoop.prerm b9a25a5
> bigtop-packages/src/rpm/sqoop/SPECS/sqoop.spec 9774326
> bigtop-packages/src/templates/init.d.tmpl PRE-CREATION
> bigtop.mk 96f2257
> package.mk 8e45771
>
> Diff: https://reviews.apache.org/r/9264/diff/
>
>
> Testing
> -------
>
> I've tested this exact patch on Fedora 17 and Ubuntu Precise, and previous iterations (without significant differences) on RHEL 5, RHEL 6, and Ubuntu Lucid.
>
>
> Thanks,
>
> Sean Mackrory
>
>
Re: Review Request: BIGTOP-805: Upgrading to Sqoop 2 (and using a generic
init script template adapted from Hadoop's services)
Posted by Sean Mackrory <ma...@gmail.com>.
> On March 15, 2013, 12:18 a.m., Jarek Cecho wrote:
> > BIGTOP-805.3.patch, line 1
> > <https://reviews.apache.org/r/9264/diff/7/?file=270862#file270862line1>
> >
> > Can we remove this entire file? :-)
It took me a little while to realize that I had added the previous patch, and that you weren't suggesting I remove catalina.properties :)
> On March 15, 2013, 12:18 a.m., Jarek Cecho wrote:
> > bigtop-packages/src/deb/sqoop/control, line 26
> > <https://reviews.apache.org/r/9264/diff/7/?file=270876#file270876line26>
> >
> > Can we say "...and Hadoop ecosystem"?
I like that - I changed the short descriptions in the .spec file for RPMs too (long descriptions still use the terms "HDFS" and "relational databases" for specificity).
- Sean
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9264/#review17930
-----------------------------------------------------------
On March 14, 2013, 11:55 p.m., Sean Mackrory wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9264/
> -----------------------------------------------------------
>
> (Updated March 14, 2013, 11:55 p.m.)
>
>
> Review request for bigtop and Jarek Cecho.
>
>
> Description
> -------
>
> This patch upgrades Sqoop from the 1.x series to the 2.x series (that is currently actually at 1.99.1). The new architecture consists of a lightweight client and a centralized server. I've also adapted the init script template used by the Hadoop services and used it for sqoop-server. It's available for all subsequent components that want to make use of it - should make it easier to solve common bugs and be consistent.
>
>
> This addresses bug BIGTOP-805.
> https://issues.apache.org/jira/browse/BIGTOP-805
>
>
> Diffs
> -----
>
> BIGTOP-805.3.patch PRE-CREATION
> bigtop-packages/src/common/sqoop/catalina.properties PRE-CREATION
> bigtop-packages/src/common/sqoop/do-component-build 42a2442
> bigtop-packages/src/common/sqoop/install_sqoop.sh 771931a
> bigtop-packages/src/common/sqoop/setenv.sh PRE-CREATION
> bigtop-packages/src/common/sqoop/sqoop-metastore.sh ab22ef3
> bigtop-packages/src/common/sqoop/sqoop-metastore.sh.suse bcc1fef
> bigtop-packages/src/common/sqoop/sqoop-server.sh PRE-CREATION
> bigtop-packages/src/common/sqoop/sqoop-server.svc PRE-CREATION
> bigtop-packages/src/common/sqoop/sqoop.default PRE-CREATION
> bigtop-packages/src/common/sqoop/sqoop.properties PRE-CREATION
> bigtop-packages/src/common/sqoop/sqoop.sh PRE-CREATION
> bigtop-packages/src/deb/sqoop/changelog 547ed02
> bigtop-packages/src/deb/sqoop/compat 7f8f011
> bigtop-packages/src/deb/sqoop/control dcc6106
> bigtop-packages/src/deb/sqoop/copyright ec176a9
> bigtop-packages/src/deb/sqoop/rules 7992dcd
> bigtop-packages/src/deb/sqoop/sqoop-client.install PRE-CREATION
> bigtop-packages/src/deb/sqoop/sqoop-metastore.postinst b8b6635
> bigtop-packages/src/deb/sqoop/sqoop-metastore.preinst 76cfb26
> bigtop-packages/src/deb/sqoop/sqoop-server.install PRE-CREATION
> bigtop-packages/src/deb/sqoop/sqoop-server.postinst PRE-CREATION
> bigtop-packages/src/deb/sqoop/sqoop.install PRE-CREATION
> bigtop-packages/src/deb/sqoop/sqoop.postinst 37cae7e
> bigtop-packages/src/deb/sqoop/sqoop.preinst PRE-CREATION
> bigtop-packages/src/deb/sqoop/sqoop.prerm b9a25a5
> bigtop-packages/src/rpm/sqoop/SPECS/sqoop.spec 9774326
> bigtop-packages/src/templates/init.d.tmpl PRE-CREATION
> bigtop.mk 96f2257
> package.mk 8e45771
>
> Diff: https://reviews.apache.org/r/9264/diff/
>
>
> Testing
> -------
>
> I've tested this exact patch on Fedora 17 and Ubuntu Precise, and previous iterations (without significant differences) on RHEL 5, RHEL 6, and Ubuntu Lucid.
>
>
> Thanks,
>
> Sean Mackrory
>
>
Re: Review Request: BIGTOP-805: Upgrading to Sqoop 2 (and using a generic
init script template adapted from Hadoop's services)
Posted by Jarek Cecho <ja...@apache.org>.
> On March 15, 2013, 12:18 a.m., Jarek Cecho wrote:
> > BIGTOP-805.3.patch, line 1
> > <https://reviews.apache.org/r/9264/diff/7/?file=270862#file270862line1>
> >
> > Can we remove this entire file? :-)
>
> Sean Mackrory wrote:
> It took me a little while to realize that I had added the previous patch, and that you weren't suggesting I remove catalina.properties :)
Och sorry, I should have been more specific.
> On March 15, 2013, 12:18 a.m., Jarek Cecho wrote:
> > bigtop-packages/src/deb/sqoop/control, line 26
> > <https://reviews.apache.org/r/9264/diff/7/?file=270876#file270876line26>
> >
> > Can we say "...and Hadoop ecosystem"?
>
> Sean Mackrory wrote:
> I like that - I changed the short descriptions in the .spec file for RPMs too (long descriptions still use the terms "HDFS" and "relational databases" for specificity).
Thank you!
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9264/#review17930
-----------------------------------------------------------
On March 14, 2013, 11:55 p.m., Sean Mackrory wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9264/
> -----------------------------------------------------------
>
> (Updated March 14, 2013, 11:55 p.m.)
>
>
> Review request for bigtop and Jarek Cecho.
>
>
> Description
> -------
>
> This patch upgrades Sqoop from the 1.x series to the 2.x series (that is currently actually at 1.99.1). The new architecture consists of a lightweight client and a centralized server. I've also adapted the init script template used by the Hadoop services and used it for sqoop-server. It's available for all subsequent components that want to make use of it - should make it easier to solve common bugs and be consistent.
>
>
> This addresses bug BIGTOP-805.
> https://issues.apache.org/jira/browse/BIGTOP-805
>
>
> Diffs
> -----
>
> BIGTOP-805.3.patch PRE-CREATION
> bigtop-packages/src/common/sqoop/catalina.properties PRE-CREATION
> bigtop-packages/src/common/sqoop/do-component-build 42a2442
> bigtop-packages/src/common/sqoop/install_sqoop.sh 771931a
> bigtop-packages/src/common/sqoop/setenv.sh PRE-CREATION
> bigtop-packages/src/common/sqoop/sqoop-metastore.sh ab22ef3
> bigtop-packages/src/common/sqoop/sqoop-metastore.sh.suse bcc1fef
> bigtop-packages/src/common/sqoop/sqoop-server.sh PRE-CREATION
> bigtop-packages/src/common/sqoop/sqoop-server.svc PRE-CREATION
> bigtop-packages/src/common/sqoop/sqoop.default PRE-CREATION
> bigtop-packages/src/common/sqoop/sqoop.properties PRE-CREATION
> bigtop-packages/src/common/sqoop/sqoop.sh PRE-CREATION
> bigtop-packages/src/deb/sqoop/changelog 547ed02
> bigtop-packages/src/deb/sqoop/compat 7f8f011
> bigtop-packages/src/deb/sqoop/control dcc6106
> bigtop-packages/src/deb/sqoop/copyright ec176a9
> bigtop-packages/src/deb/sqoop/rules 7992dcd
> bigtop-packages/src/deb/sqoop/sqoop-client.install PRE-CREATION
> bigtop-packages/src/deb/sqoop/sqoop-metastore.postinst b8b6635
> bigtop-packages/src/deb/sqoop/sqoop-metastore.preinst 76cfb26
> bigtop-packages/src/deb/sqoop/sqoop-server.install PRE-CREATION
> bigtop-packages/src/deb/sqoop/sqoop-server.postinst PRE-CREATION
> bigtop-packages/src/deb/sqoop/sqoop.install PRE-CREATION
> bigtop-packages/src/deb/sqoop/sqoop.postinst 37cae7e
> bigtop-packages/src/deb/sqoop/sqoop.preinst PRE-CREATION
> bigtop-packages/src/deb/sqoop/sqoop.prerm b9a25a5
> bigtop-packages/src/rpm/sqoop/SPECS/sqoop.spec 9774326
> bigtop-packages/src/templates/init.d.tmpl PRE-CREATION
> bigtop.mk 96f2257
> package.mk 8e45771
>
> Diff: https://reviews.apache.org/r/9264/diff/
>
>
> Testing
> -------
>
> I've tested this exact patch on Fedora 17 and Ubuntu Precise, and previous iterations (without significant differences) on RHEL 5, RHEL 6, and Ubuntu Lucid.
>
>
> Thanks,
>
> Sean Mackrory
>
>
Re: Review Request: BIGTOP-805: Upgrading to Sqoop 2 (and using a generic
init script template adapted from Hadoop's services)
Posted by Sean Mackrory <ma...@gmail.com>.
> On March 15, 2013, 12:18 a.m., Jarek Cecho wrote:
> > bigtop-packages/src/deb/sqoop/copyright, line 6
> > <https://reviews.apache.org/r/9264/diff/7/?file=270877#file270877line6>
> >
> > Nit: 2013
Fixed.
- Sean
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9264/#review17930
-----------------------------------------------------------
On March 14, 2013, 11:55 p.m., Sean Mackrory wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9264/
> -----------------------------------------------------------
>
> (Updated March 14, 2013, 11:55 p.m.)
>
>
> Review request for bigtop and Jarek Cecho.
>
>
> Description
> -------
>
> This patch upgrades Sqoop from the 1.x series to the 2.x series (that is currently actually at 1.99.1). The new architecture consists of a lightweight client and a centralized server. I've also adapted the init script template used by the Hadoop services and used it for sqoop-server. It's available for all subsequent components that want to make use of it - should make it easier to solve common bugs and be consistent.
>
>
> This addresses bug BIGTOP-805.
> https://issues.apache.org/jira/browse/BIGTOP-805
>
>
> Diffs
> -----
>
> BIGTOP-805.3.patch PRE-CREATION
> bigtop-packages/src/common/sqoop/catalina.properties PRE-CREATION
> bigtop-packages/src/common/sqoop/do-component-build 42a2442
> bigtop-packages/src/common/sqoop/install_sqoop.sh 771931a
> bigtop-packages/src/common/sqoop/setenv.sh PRE-CREATION
> bigtop-packages/src/common/sqoop/sqoop-metastore.sh ab22ef3
> bigtop-packages/src/common/sqoop/sqoop-metastore.sh.suse bcc1fef
> bigtop-packages/src/common/sqoop/sqoop-server.sh PRE-CREATION
> bigtop-packages/src/common/sqoop/sqoop-server.svc PRE-CREATION
> bigtop-packages/src/common/sqoop/sqoop.default PRE-CREATION
> bigtop-packages/src/common/sqoop/sqoop.properties PRE-CREATION
> bigtop-packages/src/common/sqoop/sqoop.sh PRE-CREATION
> bigtop-packages/src/deb/sqoop/changelog 547ed02
> bigtop-packages/src/deb/sqoop/compat 7f8f011
> bigtop-packages/src/deb/sqoop/control dcc6106
> bigtop-packages/src/deb/sqoop/copyright ec176a9
> bigtop-packages/src/deb/sqoop/rules 7992dcd
> bigtop-packages/src/deb/sqoop/sqoop-client.install PRE-CREATION
> bigtop-packages/src/deb/sqoop/sqoop-metastore.postinst b8b6635
> bigtop-packages/src/deb/sqoop/sqoop-metastore.preinst 76cfb26
> bigtop-packages/src/deb/sqoop/sqoop-server.install PRE-CREATION
> bigtop-packages/src/deb/sqoop/sqoop-server.postinst PRE-CREATION
> bigtop-packages/src/deb/sqoop/sqoop.install PRE-CREATION
> bigtop-packages/src/deb/sqoop/sqoop.postinst 37cae7e
> bigtop-packages/src/deb/sqoop/sqoop.preinst PRE-CREATION
> bigtop-packages/src/deb/sqoop/sqoop.prerm b9a25a5
> bigtop-packages/src/rpm/sqoop/SPECS/sqoop.spec 9774326
> bigtop-packages/src/templates/init.d.tmpl PRE-CREATION
> bigtop.mk 96f2257
> package.mk 8e45771
>
> Diff: https://reviews.apache.org/r/9264/diff/
>
>
> Testing
> -------
>
> I've tested this exact patch on Fedora 17 and Ubuntu Precise, and previous iterations (without significant differences) on RHEL 5, RHEL 6, and Ubuntu Lucid.
>
>
> Thanks,
>
> Sean Mackrory
>
>
Re: Review Request: BIGTOP-805: Upgrading to Sqoop 2 (and using a generic
init script template adapted from Hadoop's services)
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9264/#review17930
-----------------------------------------------------------
Hi Sean,
thank you for working on this ticket. I've took a look and the overal changes seems fine to me. I just have few nits. I'm not +1ing the issue as I do not have required insight.
BIGTOP-805.3.patch
<https://reviews.apache.org/r/9264/#comment37937>
Can we remove this entire file? :-)
bigtop-packages/src/deb/sqoop/control
<https://reviews.apache.org/r/9264/#comment37938>
Can we say "...and Hadoop ecosystem"?
bigtop-packages/src/deb/sqoop/copyright
<https://reviews.apache.org/r/9264/#comment37939>
Nit: 2013
Jarcec
- Jarek Cecho
On March 14, 2013, 11:55 p.m., Sean Mackrory wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9264/
> -----------------------------------------------------------
>
> (Updated March 14, 2013, 11:55 p.m.)
>
>
> Review request for bigtop and Jarek Cecho.
>
>
> Description
> -------
>
> This patch upgrades Sqoop from the 1.x series to the 2.x series (that is currently actually at 1.99.1). The new architecture consists of a lightweight client and a centralized server. I've also adapted the init script template used by the Hadoop services and used it for sqoop-server. It's available for all subsequent components that want to make use of it - should make it easier to solve common bugs and be consistent.
>
>
> This addresses bug BIGTOP-805.
> https://issues.apache.org/jira/browse/BIGTOP-805
>
>
> Diffs
> -----
>
> BIGTOP-805.3.patch PRE-CREATION
> bigtop-packages/src/common/sqoop/catalina.properties PRE-CREATION
> bigtop-packages/src/common/sqoop/do-component-build 42a2442
> bigtop-packages/src/common/sqoop/install_sqoop.sh 771931a
> bigtop-packages/src/common/sqoop/setenv.sh PRE-CREATION
> bigtop-packages/src/common/sqoop/sqoop-metastore.sh ab22ef3
> bigtop-packages/src/common/sqoop/sqoop-metastore.sh.suse bcc1fef
> bigtop-packages/src/common/sqoop/sqoop-server.sh PRE-CREATION
> bigtop-packages/src/common/sqoop/sqoop-server.svc PRE-CREATION
> bigtop-packages/src/common/sqoop/sqoop.default PRE-CREATION
> bigtop-packages/src/common/sqoop/sqoop.properties PRE-CREATION
> bigtop-packages/src/common/sqoop/sqoop.sh PRE-CREATION
> bigtop-packages/src/deb/sqoop/changelog 547ed02
> bigtop-packages/src/deb/sqoop/compat 7f8f011
> bigtop-packages/src/deb/sqoop/control dcc6106
> bigtop-packages/src/deb/sqoop/copyright ec176a9
> bigtop-packages/src/deb/sqoop/rules 7992dcd
> bigtop-packages/src/deb/sqoop/sqoop-client.install PRE-CREATION
> bigtop-packages/src/deb/sqoop/sqoop-metastore.postinst b8b6635
> bigtop-packages/src/deb/sqoop/sqoop-metastore.preinst 76cfb26
> bigtop-packages/src/deb/sqoop/sqoop-server.install PRE-CREATION
> bigtop-packages/src/deb/sqoop/sqoop-server.postinst PRE-CREATION
> bigtop-packages/src/deb/sqoop/sqoop.install PRE-CREATION
> bigtop-packages/src/deb/sqoop/sqoop.postinst 37cae7e
> bigtop-packages/src/deb/sqoop/sqoop.preinst PRE-CREATION
> bigtop-packages/src/deb/sqoop/sqoop.prerm b9a25a5
> bigtop-packages/src/rpm/sqoop/SPECS/sqoop.spec 9774326
> bigtop-packages/src/templates/init.d.tmpl PRE-CREATION
> bigtop.mk 96f2257
> package.mk 8e45771
>
> Diff: https://reviews.apache.org/r/9264/diff/
>
>
> Testing
> -------
>
> I've tested this exact patch on Fedora 17 and Ubuntu Precise, and previous iterations (without significant differences) on RHEL 5, RHEL 6, and Ubuntu Lucid.
>
>
> Thanks,
>
> Sean Mackrory
>
>
Re: Review Request: BIGTOP-805: Upgrading to Sqoop 2 (and using a generic
init script template adapted from Hadoop's services)
Posted by Sean Mackrory <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9264/
-----------------------------------------------------------
(Updated March 14, 2013, 11:55 p.m.)
Review request for bigtop and Jarek Cecho.
Changes
-------
This is BIGTOP-805.5.patch from the JIRA, which has incorporated all the feedback I've received and has been through a lot more testing.
Description
-------
This patch upgrades Sqoop from the 1.x series to the 2.x series (that is currently actually at 1.99.1). The new architecture consists of a lightweight client and a centralized server. I've also adapted the init script template used by the Hadoop services and used it for sqoop-server. It's available for all subsequent components that want to make use of it - should make it easier to solve common bugs and be consistent.
This addresses bug BIGTOP-805.
https://issues.apache.org/jira/browse/BIGTOP-805
Diffs (updated)
-----
BIGTOP-805.3.patch PRE-CREATION
bigtop-packages/src/common/sqoop/catalina.properties PRE-CREATION
bigtop-packages/src/common/sqoop/do-component-build 42a2442
bigtop-packages/src/common/sqoop/install_sqoop.sh 771931a
bigtop-packages/src/common/sqoop/setenv.sh PRE-CREATION
bigtop-packages/src/common/sqoop/sqoop-metastore.sh ab22ef3
bigtop-packages/src/common/sqoop/sqoop-metastore.sh.suse bcc1fef
bigtop-packages/src/common/sqoop/sqoop-server.sh PRE-CREATION
bigtop-packages/src/common/sqoop/sqoop-server.svc PRE-CREATION
bigtop-packages/src/common/sqoop/sqoop.default PRE-CREATION
bigtop-packages/src/common/sqoop/sqoop.properties PRE-CREATION
bigtop-packages/src/common/sqoop/sqoop.sh PRE-CREATION
bigtop-packages/src/deb/sqoop/changelog 547ed02
bigtop-packages/src/deb/sqoop/compat 7f8f011
bigtop-packages/src/deb/sqoop/control dcc6106
bigtop-packages/src/deb/sqoop/copyright ec176a9
bigtop-packages/src/deb/sqoop/rules 7992dcd
bigtop-packages/src/deb/sqoop/sqoop-client.install PRE-CREATION
bigtop-packages/src/deb/sqoop/sqoop-metastore.postinst b8b6635
bigtop-packages/src/deb/sqoop/sqoop-metastore.preinst 76cfb26
bigtop-packages/src/deb/sqoop/sqoop-server.install PRE-CREATION
bigtop-packages/src/deb/sqoop/sqoop-server.postinst PRE-CREATION
bigtop-packages/src/deb/sqoop/sqoop.install PRE-CREATION
bigtop-packages/src/deb/sqoop/sqoop.postinst 37cae7e
bigtop-packages/src/deb/sqoop/sqoop.preinst PRE-CREATION
bigtop-packages/src/deb/sqoop/sqoop.prerm b9a25a5
bigtop-packages/src/rpm/sqoop/SPECS/sqoop.spec 9774326
bigtop-packages/src/templates/init.d.tmpl PRE-CREATION
bigtop.mk 96f2257
package.mk 8e45771
Diff: https://reviews.apache.org/r/9264/diff/
Testing
-------
I've tested this exact patch on Fedora 17 and Ubuntu Precise, and previous iterations (without significant differences) on RHEL 5, RHEL 6, and Ubuntu Lucid.
Thanks,
Sean Mackrory
Re: Review Request: BIGTOP-805: Upgrading to Sqoop 2 (and using a generic
init script template adapted from Hadoop's services)
Posted by Sean Mackrory <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9264/
-----------------------------------------------------------
(Updated Feb. 13, 2013, 5:10 p.m.)
Review request for bigtop and Jarek Cecho.
Changes
-------
This is BIGTOP-805.3.patch from the JIRA, which I believe includes all feedback thus far and some additional fixes from more testing.
Description
-------
This patch upgrades Sqoop from the 1.x series to the 2.x series (that is currently actually at 1.99.1). The new architecture consists of a lightweight client and a centralized server. I've also adapted the init script template used by the Hadoop services and used it for sqoop-server. It's available for all subsequent components that want to make use of it - should make it easier to solve common bugs and be consistent.
This addresses bug BIGTOP-805.
https://issues.apache.org/jira/browse/BIGTOP-805
Diffs (updated)
-----
bigtop-packages/src/common/sqoop/catalina.properties PRE-CREATION
bigtop-packages/src/common/sqoop/do-component-build 42a2442
bigtop-packages/src/common/sqoop/install_sqoop.sh e752c4e
bigtop-packages/src/common/sqoop/setenv.sh PRE-CREATION
bigtop-packages/src/common/sqoop/sqoop-env.sh PRE-CREATION
bigtop-packages/src/common/sqoop/sqoop-metastore.sh ab22ef3
bigtop-packages/src/common/sqoop/sqoop-metastore.sh.suse bcc1fef
bigtop-packages/src/common/sqoop/sqoop-server.svc PRE-CREATION
bigtop-packages/src/common/sqoop/sqoop.properties PRE-CREATION
bigtop-packages/src/common/sqoop/sqoop.sh PRE-CREATION
bigtop-packages/src/deb/sqoop/changelog 547ed02
bigtop-packages/src/deb/sqoop/compat 7f8f011
bigtop-packages/src/deb/sqoop/control dcc6106
bigtop-packages/src/deb/sqoop/copyright ec176a9
bigtop-packages/src/deb/sqoop/rules 7992dcd
bigtop-packages/src/deb/sqoop/sqoop-client.install PRE-CREATION
bigtop-packages/src/deb/sqoop/sqoop-metastore.postinst b8b6635
bigtop-packages/src/deb/sqoop/sqoop-metastore.preinst 76cfb26
bigtop-packages/src/deb/sqoop/sqoop-server.install PRE-CREATION
bigtop-packages/src/deb/sqoop/sqoop-server.postinst PRE-CREATION
bigtop-packages/src/deb/sqoop/sqoop.install PRE-CREATION
bigtop-packages/src/deb/sqoop/sqoop.postinst 37cae7e
bigtop-packages/src/deb/sqoop/sqoop.preinst PRE-CREATION
bigtop-packages/src/deb/sqoop/sqoop.prerm b9a25a5
bigtop-packages/src/rpm/sqoop/SPECS/sqoop.spec 9774326
bigtop-packages/src/templates/init.d.tmpl PRE-CREATION
bigtop.mk 96f2257
package.mk 8e45771
Diff: https://reviews.apache.org/r/9264/diff/
Testing
-------
I've tested this exact patch on Fedora 17 and Ubuntu Precise, and previous iterations (without significant differences) on RHEL 5, RHEL 6, and Ubuntu Lucid.
Thanks,
Sean Mackrory
Re: Review Request: BIGTOP-805: Upgrading to Sqoop 2 (and using a generic
init script template adapted from Hadoop's services)
Posted by Sean Mackrory <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9264/
-----------------------------------------------------------
(Updated Feb. 4, 2013, 10:31 p.m.)
Review request for bigtop and Jarek Cecho.
Changes
-------
Actually incorporating Mark's feedback
Description
-------
This patch upgrades Sqoop from the 1.x series to the 2.x series (that is currently actually at 1.99.1). The new architecture consists of a lightweight client and a centralized server. I've also adapted the init script template used by the Hadoop services and used it for sqoop-server. It's available for all subsequent components that want to make use of it - should make it easier to solve common bugs and be consistent.
This addresses bug BIGTOP-805.
https://issues.apache.org/jira/browse/BIGTOP-805
Diffs (updated)
-----
bigtop-packages/src/common/sqoop/catalina.properties PRE-CREATION
bigtop-packages/src/common/sqoop/do-component-build 42a2442
bigtop-packages/src/common/sqoop/install_sqoop.sh e752c4e
bigtop-packages/src/common/sqoop/setenv.sh PRE-CREATION
bigtop-packages/src/common/sqoop/sqoop-env.sh PRE-CREATION
bigtop-packages/src/common/sqoop/sqoop-metastore.sh ab22ef3
bigtop-packages/src/common/sqoop/sqoop-metastore.sh.suse bcc1fef
bigtop-packages/src/common/sqoop/sqoop-server.svc PRE-CREATION
bigtop-packages/src/common/sqoop/sqoop.properties PRE-CREATION
bigtop-packages/src/common/sqoop/sqoop.sh PRE-CREATION
bigtop-packages/src/deb/sqoop/changelog 547ed02
bigtop-packages/src/deb/sqoop/compat 7f8f011
bigtop-packages/src/deb/sqoop/control dcc6106
bigtop-packages/src/deb/sqoop/copyright ec176a9
bigtop-packages/src/deb/sqoop/rules 7992dcd
bigtop-packages/src/deb/sqoop/sqoop-client.install PRE-CREATION
bigtop-packages/src/deb/sqoop/sqoop-metastore.postinst b8b6635
bigtop-packages/src/deb/sqoop/sqoop-metastore.preinst 76cfb26
bigtop-packages/src/deb/sqoop/sqoop-server.install PRE-CREATION
bigtop-packages/src/deb/sqoop/sqoop-server.postinst PRE-CREATION
bigtop-packages/src/deb/sqoop/sqoop.install PRE-CREATION
bigtop-packages/src/deb/sqoop/sqoop.postinst 37cae7e
bigtop-packages/src/deb/sqoop/sqoop.preinst PRE-CREATION
bigtop-packages/src/deb/sqoop/sqoop.prerm b9a25a5
bigtop-packages/src/rpm/sqoop/SPECS/sqoop.spec 9774326
bigtop-packages/src/templates/init.d.tmpl PRE-CREATION
bigtop.mk 96f2257
package.mk 8e45771
Diff: https://reviews.apache.org/r/9264/diff/
Testing
-------
I've tested this exact patch on Fedora 17 and Ubuntu Precise, and previous iterations (without significant differences) on RHEL 5, RHEL 6, and Ubuntu Lucid.
Thanks,
Sean Mackrory
Re: Review Request: BIGTOP-805: Upgrading to Sqoop 2 (and using a generic
init script template adapted from Hadoop's services)
Posted by Sean Mackrory <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9264/
-----------------------------------------------------------
(Updated Feb. 4, 2013, 10:27 p.m.)
Review request for bigtop and Jarek Cecho.
Changes
-------
Incorporating Mark's feedback
Description
-------
This patch upgrades Sqoop from the 1.x series to the 2.x series (that is currently actually at 1.99.1). The new architecture consists of a lightweight client and a centralized server. I've also adapted the init script template used by the Hadoop services and used it for sqoop-server. It's available for all subsequent components that want to make use of it - should make it easier to solve common bugs and be consistent.
This addresses bug BIGTOP-805.
https://issues.apache.org/jira/browse/BIGTOP-805
Diffs (updated)
-----
bigtop-packages/src/common/sqoop/catalina.properties PRE-CREATION
bigtop-packages/src/common/sqoop/do-component-build 42a2442
bigtop-packages/src/common/sqoop/install_sqoop.sh e752c4e
bigtop-packages/src/common/sqoop/setenv.sh PRE-CREATION
bigtop-packages/src/common/sqoop/sqoop-env.sh PRE-CREATION
bigtop-packages/src/common/sqoop/sqoop-metastore.sh ab22ef3
bigtop-packages/src/common/sqoop/sqoop-metastore.sh.suse bcc1fef
bigtop-packages/src/common/sqoop/sqoop-server.svc PRE-CREATION
bigtop-packages/src/common/sqoop/sqoop.properties PRE-CREATION
bigtop-packages/src/common/sqoop/sqoop.sh PRE-CREATION
bigtop-packages/src/deb/sqoop/changelog 547ed02
bigtop-packages/src/deb/sqoop/compat 7f8f011
bigtop-packages/src/deb/sqoop/control dcc6106
bigtop-packages/src/deb/sqoop/copyright ec176a9
bigtop-packages/src/deb/sqoop/rules 7992dcd
bigtop-packages/src/deb/sqoop/sqoop-client.install PRE-CREATION
bigtop-packages/src/deb/sqoop/sqoop-metastore.postinst b8b6635
bigtop-packages/src/deb/sqoop/sqoop-metastore.preinst 76cfb26
bigtop-packages/src/deb/sqoop/sqoop-server.install PRE-CREATION
bigtop-packages/src/deb/sqoop/sqoop-server.postinst PRE-CREATION
bigtop-packages/src/deb/sqoop/sqoop.install PRE-CREATION
bigtop-packages/src/deb/sqoop/sqoop.postinst 37cae7e
bigtop-packages/src/deb/sqoop/sqoop.preinst PRE-CREATION
bigtop-packages/src/deb/sqoop/sqoop.prerm b9a25a5
bigtop-packages/src/rpm/sqoop/SPECS/sqoop.spec 9774326
bigtop-packages/src/templates/init.d.tmpl PRE-CREATION
bigtop.mk 96f2257
package.mk 8e45771
Diff: https://reviews.apache.org/r/9264/diff/
Testing
-------
I've tested this exact patch on Fedora 17 and Ubuntu Precise, and previous iterations (without significant differences) on RHEL 5, RHEL 6, and Ubuntu Lucid.
Thanks,
Sean Mackrory
Re: Review Request: BIGTOP-805: Upgrading to Sqoop 2 (and using a generic
init script template adapted from Hadoop's services)
Posted by Sean Mackrory <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9264/
-----------------------------------------------------------
(Updated Feb. 4, 2013, 8:55 p.m.)
Review request for bigtop and Jarek Cecho.
Changes
-------
Removing trailing whitespace as suggested by jarcec.
Description
-------
This patch upgrades Sqoop from the 1.x series to the 2.x series (that is currently actually at 1.99.1). The new architecture consists of a lightweight client and a centralized server. I've also adapted the init script template used by the Hadoop services and used it for sqoop-server. It's available for all subsequent components that want to make use of it - should make it easier to solve common bugs and be consistent.
This addresses bug BIGTOP-805.
https://issues.apache.org/jira/browse/BIGTOP-805
Diffs (updated)
-----
bigtop-packages/src/common/sqoop/catalina.properties PRE-CREATION
bigtop-packages/src/common/sqoop/catalina.properties.mr1 PRE-CREATION
bigtop-packages/src/common/sqoop/do-component-build 42a2442
bigtop-packages/src/common/sqoop/install_sqoop.sh e752c4e
bigtop-packages/src/common/sqoop/setenv.sh PRE-CREATION
bigtop-packages/src/common/sqoop/sqoop-env.sh PRE-CREATION
bigtop-packages/src/common/sqoop/sqoop-metastore.sh ab22ef3
bigtop-packages/src/common/sqoop/sqoop-metastore.sh.suse bcc1fef
bigtop-packages/src/common/sqoop/sqoop-server.svc PRE-CREATION
bigtop-packages/src/common/sqoop/sqoop.properties PRE-CREATION
bigtop-packages/src/common/sqoop/sqoop.sh PRE-CREATION
bigtop-packages/src/deb/sqoop/changelog 547ed02
bigtop-packages/src/deb/sqoop/compat 7f8f011
bigtop-packages/src/deb/sqoop/control dcc6106
bigtop-packages/src/deb/sqoop/copyright ec176a9
bigtop-packages/src/deb/sqoop/rules 7992dcd
bigtop-packages/src/deb/sqoop/sqoop-client.install PRE-CREATION
bigtop-packages/src/deb/sqoop/sqoop-metastore.postinst b8b6635
bigtop-packages/src/deb/sqoop/sqoop-metastore.preinst 76cfb26
bigtop-packages/src/deb/sqoop/sqoop-server.install PRE-CREATION
bigtop-packages/src/deb/sqoop/sqoop-server.postinst PRE-CREATION
bigtop-packages/src/deb/sqoop/sqoop.install PRE-CREATION
bigtop-packages/src/deb/sqoop/sqoop.postinst 37cae7e
bigtop-packages/src/deb/sqoop/sqoop.preinst PRE-CREATION
bigtop-packages/src/deb/sqoop/sqoop.prerm b9a25a5
bigtop-packages/src/rpm/sqoop/SPECS/sqoop.spec 9774326
bigtop-packages/src/templates/init.d.tmpl PRE-CREATION
bigtop.mk 96f2257
package.mk 8e45771
Diff: https://reviews.apache.org/r/9264/diff/
Testing
-------
I've tested this exact patch on Fedora 17 and Ubuntu Precise, and previous iterations (without significant differences) on RHEL 5, RHEL 6, and Ubuntu Lucid.
Thanks,
Sean Mackrory
Re: Review Request: BIGTOP-805: Upgrading to Sqoop 2 (and using a generic
init script template adapted from Hadoop's services)
Posted by Sean Mackrory <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9264/
-----------------------------------------------------------
(Updated Feb. 4, 2013, 7:32 p.m.)
Review request for bigtop and Jarek Cecho.
Changes
-------
Omitting "site" target from maven execution and specifying Bigtop's Hadoop version.
Description
-------
This patch upgrades Sqoop from the 1.x series to the 2.x series (that is currently actually at 1.99.1). The new architecture consists of a lightweight client and a centralized server. I've also adapted the init script template used by the Hadoop services and used it for sqoop-server. It's available for all subsequent components that want to make use of it - should make it easier to solve common bugs and be consistent.
This addresses bug BIGTOP-805.
https://issues.apache.org/jira/browse/BIGTOP-805
Diffs (updated)
-----
bigtop-packages/src/common/sqoop/catalina.properties PRE-CREATION
bigtop-packages/src/common/sqoop/catalina.properties.mr1 PRE-CREATION
bigtop-packages/src/common/sqoop/do-component-build 42a2442
bigtop-packages/src/common/sqoop/install_sqoop.sh e752c4e
bigtop-packages/src/common/sqoop/setenv.sh PRE-CREATION
bigtop-packages/src/common/sqoop/sqoop-env.sh PRE-CREATION
bigtop-packages/src/common/sqoop/sqoop-metastore.sh ab22ef3
bigtop-packages/src/common/sqoop/sqoop-metastore.sh.suse bcc1fef
bigtop-packages/src/common/sqoop/sqoop-server.svc PRE-CREATION
bigtop-packages/src/common/sqoop/sqoop.properties PRE-CREATION
bigtop-packages/src/common/sqoop/sqoop.sh PRE-CREATION
bigtop-packages/src/deb/sqoop/compat 7f8f011
bigtop-packages/src/deb/sqoop/control dcc6106
bigtop-packages/src/deb/sqoop/copyright ec176a9
bigtop-packages/src/deb/sqoop/rules 7992dcd
bigtop-packages/src/deb/sqoop/sqoop-client.install PRE-CREATION
bigtop-packages/src/deb/sqoop/sqoop-metastore.postinst b8b6635
bigtop-packages/src/deb/sqoop/sqoop-metastore.preinst 76cfb26
bigtop-packages/src/deb/sqoop/sqoop-server.install PRE-CREATION
bigtop-packages/src/deb/sqoop/sqoop-server.postinst PRE-CREATION
bigtop-packages/src/deb/sqoop/sqoop.install PRE-CREATION
bigtop-packages/src/deb/sqoop/sqoop.postinst 37cae7e
bigtop-packages/src/deb/sqoop/sqoop.preinst PRE-CREATION
bigtop-packages/src/deb/sqoop/sqoop.prerm b9a25a5
bigtop-packages/src/rpm/sqoop/SPECS/sqoop.spec 9774326
bigtop-packages/src/templates/init.d.tmpl PRE-CREATION
bigtop.mk 96f2257
package.mk 8e45771
Diff: https://reviews.apache.org/r/9264/diff/
Testing
-------
I've tested this exact patch on Fedora 17 and Ubuntu Precise, and previous iterations (without significant differences) on RHEL 5, RHEL 6, and Ubuntu Lucid.
Thanks,
Sean Mackrory