You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2018/03/27 20:43:54 UTC
[kudu-CR] Add python release steps to RELEASING.adoc
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9824
Change subject: Add python release steps to RELEASING.adoc
......................................................................
Add python release steps to RELEASING.adoc
Change-Id: I1cf643b196b9fc324ee78617e2e8fcf664248e14
---
M RELEASING.adoc
1 file changed, 16 insertions(+), 16 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/9824/1
--
To view, visit http://gerrit.cloudera.org:8080/9824
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1cf643b196b9fc324ee78617e2e8fcf664248e14
Gerrit-Change-Number: 9824
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] Add python release steps to RELEASING.adoc
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9824 )
Change subject: Add python release steps to RELEASING.adoc
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/9824/2/RELEASING.adoc
File RELEASING.adoc:
http://gerrit.cloudera.org:8080/#/c/9824/2/RELEASING.adoc@250
PS2, Line 250: python
> Nit: Python
Done
http://gerrit.cloudera.org:8080/#/c/9824/2/RELEASING.adoc@254
PS2, Line 254: # Prepare and sign the python source distribution.
> Should these steps be done within a virtualenv?
I think it's fair to assume a python user will setup a virtualenv if they feel it's necessary. Other python docs don't mention this.
--
To view, visit http://gerrit.cloudera.org:8080/9824
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1cf643b196b9fc324ee78617e2e8fcf664248e14
Gerrit-Change-Number: 9824
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 27 Mar 2018 20:54:00 +0000
Gerrit-HasComments: Yes
[kudu-CR] Add python release steps to RELEASING.adoc
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9824 )
Change subject: Add python release steps to RELEASING.adoc
......................................................................
Add python release steps to RELEASING.adoc
Change-Id: I1cf643b196b9fc324ee78617e2e8fcf664248e14
Reviewed-on: http://gerrit.cloudera.org:8080/9824
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Grant Henke <gr...@apache.org>
---
M RELEASING.adoc
1 file changed, 16 insertions(+), 0 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Grant Henke: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9824
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1cf643b196b9fc324ee78617e2e8fcf664248e14
Gerrit-Change-Number: 9824
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Add python release steps to RELEASING.adoc
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9824 )
Change subject: Add python release steps to RELEASING.adoc
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9824
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1cf643b196b9fc324ee78617e2e8fcf664248e14
Gerrit-Change-Number: 9824
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 27 Mar 2018 21:00:16 +0000
Gerrit-HasComments: No
[kudu-CR] Add python release steps to RELEASING.adoc
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins, Adar Dembo, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9824
to look at the new patch set (#2).
Change subject: Add python release steps to RELEASING.adoc
......................................................................
Add python release steps to RELEASING.adoc
Change-Id: I1cf643b196b9fc324ee78617e2e8fcf664248e14
---
M RELEASING.adoc
1 file changed, 16 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/9824/2
--
To view, visit http://gerrit.cloudera.org:8080/9824
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1cf643b196b9fc324ee78617e2e8fcf664248e14
Gerrit-Change-Number: 9824
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Add python release steps to RELEASING.adoc
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins, Adar Dembo, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9824
to look at the new patch set (#3).
Change subject: Add python release steps to RELEASING.adoc
......................................................................
Add python release steps to RELEASING.adoc
Change-Id: I1cf643b196b9fc324ee78617e2e8fcf664248e14
---
M RELEASING.adoc
1 file changed, 16 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/9824/3
--
To view, visit http://gerrit.cloudera.org:8080/9824
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1cf643b196b9fc324ee78617e2e8fcf664248e14
Gerrit-Change-Number: 9824
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Add python release steps to RELEASING.adoc
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9824 )
Change subject: Add python release steps to RELEASING.adoc
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/9824/2/RELEASING.adoc
File RELEASING.adoc:
http://gerrit.cloudera.org:8080/#/c/9824/2/RELEASING.adoc@250
PS2, Line 250: python
Nit: Python
http://gerrit.cloudera.org:8080/#/c/9824/2/RELEASING.adoc@254
PS2, Line 254: # Prepare and sign the python source distribution.
Should these steps be done within a virtualenv?
--
To view, visit http://gerrit.cloudera.org:8080/9824
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1cf643b196b9fc324ee78617e2e8fcf664248e14
Gerrit-Change-Number: 9824
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 27 Mar 2018 20:47:46 +0000
Gerrit-HasComments: Yes
[kudu-CR] Add python release steps to RELEASING.adoc
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9824 )
Change subject: Add python release steps to RELEASING.adoc
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/9824
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1cf643b196b9fc324ee78617e2e8fcf664248e14
Gerrit-Change-Number: 9824
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 27 Mar 2018 21:23:44 +0000
Gerrit-HasComments: No