[GitHub] spark pull request: [SPARK-8603] [sparkR] In windows, Incorrect fi...

[JoshRosen <gi...@git.apache.org>]

Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7025#discussion_r49657198
  
    --- Diff: R/pkg/R/client.R ---
    @@ -42,6 +42,19 @@ determineSparkSubmitBin <- function() {
       }
       sparkSubmitBinName
     }
    +# R supports both file separator in the file path (Unix : / and Windows: \) irrespective of the operating system
    +# but when passing file path to Java or script program, it has to be converted according to operating system
    +
    +determinefileSeperator <- function() {
    +  if (.Platform$OS.type == "unix") {
    --- End diff --
    
    Is anything which is not Unix guaranteed to be Windows? It seems like Windows is actually the special case here, so can we check its platform directly rather than assuming "not unix" is Windows?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org