You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Budnik <ab...@mesosphere.com> on 2018/02/05 15:53:18 UTC
Review Request 65505: Restored `WaitAfterDestroy` test for a nested
container.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65505/
-----------------------------------------------------------
Review request for mesos, Jie Yu, Joseph Wu, and Kevin Klues.
Repository: mesos
Description
-------
This test was removed in fd4b9af147, but it's important to check that
after termination of a nested container, its termination status is
available. This property is used in default executor.
Diffs
-----
src/tests/containerizer/nested_mesos_containerizer_tests.cpp 796bc401d4f922e7a6bd9e5391003cddd4331c95
Diff: https://reviews.apache.org/r/65505/diff/1/
Testing
-------
internal CI
Thanks,
Andrei Budnik
Re: Review Request 65505: Restored `WaitAfterDestroy` test for a
nested container.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65505/#review196811
-----------------------------------------------------------
PASS: Mesos patch 65505 was successfully built and tested.
Reviews applied: `['65505']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65505
- Mesos Reviewbot Windows
On Feb. 5, 2018, 3:53 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65505/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2018, 3:53 p.m.)
>
>
> Review request for mesos, Jie Yu, Joseph Wu, and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test was removed in fd4b9af147, but it's important to check that
> after termination of a nested container, its termination status is
> available. This property is used in default executor.
>
>
> Diffs
> -----
>
> src/tests/containerizer/nested_mesos_containerizer_tests.cpp 796bc401d4f922e7a6bd9e5391003cddd4331c95
>
>
> Diff: https://reviews.apache.org/r/65505/diff/1/
>
>
> Testing
> -------
>
> internal CI
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 65505: Restored `WaitAfterDestroy` test for a
nested container.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65505/#review203739
-----------------------------------------------------------
Ship it!
Ship It!
- Qian Zhang
On April 27, 2018, 1 a.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65505/
> -----------------------------------------------------------
>
> (Updated April 27, 2018, 1 a.m.)
>
>
> Review request for mesos, Greg Mann, Jie Yu, Joseph Wu, Kevin Klues, and Qian Zhang.
>
>
> Bugs: MESOS-8734
> https://issues.apache.org/jira/browse/MESOS-8734
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test was removed in fd4b9af147, but it's important to check that
> after termination of a nested container, its termination status is
> available. This property is used in default executor.
>
>
> Diffs
> -----
>
> src/tests/containerizer/nested_mesos_containerizer_tests.cpp 661be81d6036113295876546f565264b843b704d
>
>
> Diff: https://reviews.apache.org/r/65505/diff/4/
>
>
> Testing
> -------
>
> internal CI
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 65505: Restored `WaitAfterDestroy` test for a
nested container.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65505/#review203565
-----------------------------------------------------------
src/tests/containerizer/nested_mesos_containerizer_tests.cpp
Lines 2635 (patched)
<https://reviews.apache.org/r/65505/#comment285850>
Can you please elaborate a bit on why it does a destroy?
- Qian Zhang
On April 27, 2018, 1 a.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65505/
> -----------------------------------------------------------
>
> (Updated April 27, 2018, 1 a.m.)
>
>
> Review request for mesos, Greg Mann, Jie Yu, Joseph Wu, Kevin Klues, and Qian Zhang.
>
>
> Bugs: MESOS-8734
> https://issues.apache.org/jira/browse/MESOS-8734
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test was removed in fd4b9af147, but it's important to check that
> after termination of a nested container, its termination status is
> available. This property is used in default executor.
>
>
> Diffs
> -----
>
> src/tests/containerizer/nested_mesos_containerizer_tests.cpp 661be81d6036113295876546f565264b843b704d
>
>
> Diff: https://reviews.apache.org/r/65505/diff/3/
>
>
> Testing
> -------
>
> internal CI
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 65505: Restored `WaitAfterDestroy` test for a
nested container.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65505/#review202036
-----------------------------------------------------------
Patch looks great!
Reviews applied: [65505]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 26, 2018, 5 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65505/
> -----------------------------------------------------------
>
> (Updated April 26, 2018, 5 p.m.)
>
>
> Review request for mesos, Greg Mann, Jie Yu, Joseph Wu, and Kevin Klues.
>
>
> Bugs: MESOS-8734
> https://issues.apache.org/jira/browse/MESOS-8734
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test was removed in fd4b9af147, but it's important to check that
> after termination of a nested container, its termination status is
> available. This property is used in default executor.
>
>
> Diffs
> -----
>
> src/tests/containerizer/nested_mesos_containerizer_tests.cpp 661be81d6036113295876546f565264b843b704d
>
>
> Diff: https://reviews.apache.org/r/65505/diff/2/
>
>
> Testing
> -------
>
> internal CI
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 65505: Restored `WaitAfterDestroy` test for a
nested container.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65505/#review202022
-----------------------------------------------------------
PASS: Mesos patch 65505 was successfully built and tested.
Reviews applied: `['65505']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65505
- Mesos Reviewbot Windows
On April 26, 2018, 10 a.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65505/
> -----------------------------------------------------------
>
> (Updated April 26, 2018, 10 a.m.)
>
>
> Review request for mesos, Greg Mann, Jie Yu, Joseph Wu, and Kevin Klues.
>
>
> Bugs: MESOS-8734
> https://issues.apache.org/jira/browse/MESOS-8734
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test was removed in fd4b9af147, but it's important to check that
> after termination of a nested container, its termination status is
> available. This property is used in default executor.
>
>
> Diffs
> -----
>
> src/tests/containerizer/nested_mesos_containerizer_tests.cpp 661be81d6036113295876546f565264b843b704d
>
>
> Diff: https://reviews.apache.org/r/65505/diff/2/
>
>
> Testing
> -------
>
> internal CI
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 65505: Restored `WaitAfterDestroy` test for a
nested container.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65505/#review203145
-----------------------------------------------------------
Patch looks great!
Reviews applied: [66668, 66670, 66671, 66817, 67128, 67130, 65505]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 26, 2018, 5 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65505/
> -----------------------------------------------------------
>
> (Updated April 26, 2018, 5 p.m.)
>
>
> Review request for mesos, Greg Mann, Jie Yu, Joseph Wu, Kevin Klues, and Qian Zhang.
>
>
> Bugs: MESOS-8734
> https://issues.apache.org/jira/browse/MESOS-8734
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test was removed in fd4b9af147, but it's important to check that
> after termination of a nested container, its termination status is
> available. This property is used in default executor.
>
>
> Diffs
> -----
>
> src/tests/containerizer/nested_mesos_containerizer_tests.cpp 661be81d6036113295876546f565264b843b704d
>
>
> Diff: https://reviews.apache.org/r/65505/diff/3/
>
>
> Testing
> -------
>
> internal CI
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 65505: Restored `WaitAfterDestroy` test for a
nested container.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65505/#review203125
-----------------------------------------------------------
PASS: Mesos patch 65505 was successfully built and tested.
Reviews applied: `['66668', '66670', '66671', '66817', '67128', '67130', '65505']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65505
- Mesos Reviewbot Windows
On April 26, 2018, 5 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65505/
> -----------------------------------------------------------
>
> (Updated April 26, 2018, 5 p.m.)
>
>
> Review request for mesos, Greg Mann, Jie Yu, Joseph Wu, Kevin Klues, and Qian Zhang.
>
>
> Bugs: MESOS-8734
> https://issues.apache.org/jira/browse/MESOS-8734
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test was removed in fd4b9af147, but it's important to check that
> after termination of a nested container, its termination status is
> available. This property is used in default executor.
>
>
> Diffs
> -----
>
> src/tests/containerizer/nested_mesos_containerizer_tests.cpp 661be81d6036113295876546f565264b843b704d
>
>
> Diff: https://reviews.apache.org/r/65505/diff/3/
>
>
> Testing
> -------
>
> internal CI
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 65505: Restored `WaitAfterDestroy` test for a
nested container.
Posted by Andrei Budnik <ab...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65505/
-----------------------------------------------------------
(Updated April 26, 2018, 5 p.m.)
Review request for mesos, Jie Yu, Joseph Wu, and Kevin Klues.
Changes
-------
rebased with the current master
Repository: mesos
Description
-------
This test was removed in fd4b9af147, but it's important to check that
after termination of a nested container, its termination status is
available. This property is used in default executor.
Diffs (updated)
-----
src/tests/containerizer/nested_mesos_containerizer_tests.cpp 661be81d6036113295876546f565264b843b704d
Diff: https://reviews.apache.org/r/65505/diff/2/
Changes: https://reviews.apache.org/r/65505/diff/1-2/
Testing
-------
internal CI
Thanks,
Andrei Budnik