You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/27 19:56:14 UTC

[GitHub] HyukjinKwon opened a new pull request #23911: [SPARK-26895][CORE][FOLLOW-UP] Uninitializing log after `prepareSubmitEnvironment` in SparkSubmit

HyukjinKwon opened a new pull request #23911: [SPARK-26895][CORE][FOLLOW-UP] Uninitializing log after `prepareSubmitEnvironment` in SparkSubmit
URL: https://github.com/apache/spark/pull/23911
 
 
   ## What changes were proposed in this pull request?
   
   Currently, if I run `spark-shell` in my local, it started to show the logs as below:
   
   ```
   $ ./bin/spark-shell
   ...
   19/02/28 04:42:43 INFO SecurityManager: Changing view acls to: hkwon
   19/02/28 04:42:43 INFO SecurityManager: Changing modify acls to: hkwon
   19/02/28 04:42:43 INFO SecurityManager: Changing view acls groups to:
   19/02/28 04:42:43 INFO SecurityManager: Changing modify acls groups to:
   19/02/28 04:42:43 INFO SecurityManager: SecurityManager: authentication disabled; ui acls disabled; users  with view permissions: Set(hkwon); groups with view permissions: Set(); users  with modify permissions: Set(hkwon); groups with modify permissions: Set()
   19/02/28 04:42:43 INFO SignalUtils: Registered signal handler for INT
   19/02/28 04:42:48 INFO SparkContext: Running Spark version 3.0.0-SNAPSHOT
   19/02/28 04:42:48 INFO SparkContext: Submitted application: Spark shell
   19/02/28 04:42:48 INFO SecurityManager: Changing view acls to: hkwon
   ```
   
   Seems to be the cause is https://github.com/apache/spark/pull/23806 and `prepareSubmitEnvironment` looks actually reinitializing the logging again.
   
   This PR proposes to uninitializing log later after `prepareSubmitEnvironment`.
   
   ## How was this patch tested?
   
   Manually tested.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org