You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/15 08:24:06 UTC

[GitHub] [airflow] aksakalli commented on a change in pull request #10064: Add ingress to the helm chart

aksakalli commented on a change in pull request #10064:
URL: https://github.com/apache/airflow/pull/10064#discussion_r470953806



##########
File path: chart/values.yaml
##########
@@ -42,6 +42,59 @@ tolerations: []
 # Add common labels to all objects and pods defined in this chart.
 labels: {}
 
+# Ingress configuration
+ingress:
+  # Enable ingress resource
+  enabled: false

Review comment:
       There is no option to disable `flower` if you use `CeleryExecutor` (unlike the [stable/helm](https://github.com/helm/charts/blob/8736171868dd9ba8e73584f3fc486ee7e341718b/stable/airflow/templates/ingress-flower.yaml#L1)). I don't think it is common that someone would like to deploy it with an ingress record for `webserver` but not for `flower`. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org