You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/15 04:07:17 UTC

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #37516: [MINOR][CORE] Fix comment & code style in HadoopFSUtils

HyukjinKwon commented on code in PR #37516:
URL: https://github.com/apache/spark/pull/37516#discussion_r945413554


##########
core/src/main/scala/org/apache/spark/util/HadoopFSUtils.scala:
##########
@@ -57,14 +57,14 @@ private[spark] object HadoopFSUtils extends Logging {
    * @return for each input path, the set of discovered files for the path
    */
   def parallelListLeafFiles(
-    sc: SparkContext,
-    paths: Seq[Path],
-    hadoopConf: Configuration,
-    filter: PathFilter,
-    ignoreMissingFiles: Boolean,
-    ignoreLocality: Boolean,
-    parallelismThreshold: Int,
-    parallelismMax: Int): Seq[(Path, Seq[FileStatus])] = {
+      sc: SparkContext,
+      paths: Seq[Path],
+      hadoopConf: Configuration,
+      filter: PathFilter,
+      ignoreMissingFiles: Boolean,
+      ignoreLocality: Boolean,
+      parallelismThreshold: Int,
+      parallelismMax: Int): Seq[(Path, Seq[FileStatus])] = {

Review Comment:
   Let's don't fix the style arbitrarily. You would fix some styles when you fix other codes around. For example it makes backporting harder. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org