You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@drill.apache.org by "Steven Phillips (JIRA)" <ji...@apache.org> on 2015/04/14 01:58:12 UTC

[jira] [Commented] (DRILL-2774) Updated drill-patch-review.py to use git-format-patch

    [ https://issues.apache.org/jira/browse/DRILL-2774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14493313#comment-14493313 ] 

Steven Phillips commented on DRILL-2774:
----------------------------------------

Created reviewboard 

> Updated drill-patch-review.py to use git-format-patch
> -----------------------------------------------------
>
>                 Key: DRILL-2774
>                 URL: https://issues.apache.org/jira/browse/DRILL-2774
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Tools, Build & Test
>            Reporter: Steven Phillips
>            Assignee: Steven Phillips
>            Priority: Minor
>             Fix For: 0.9.0
>
>         Attachments: DRILL-2774.patch
>
>
> The tool currently uses git diff to generate the patches, which does not preserve commit information, and which is required for submitting patches in the Drill community.
> This doesn't work properly when there are multiple commits, so as part of this change, we enforce the requirement that the branch used to create the patch is exactly one commit ahead and zero behind the remote branch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)