You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/05/10 13:17:44 UTC

[GitHub] [airflow] vikramcse opened a new pull request #15760: Improve test coverage of task_command.py FIXES: #15524

vikramcse opened a new pull request #15760:
URL: https://github.com/apache/airflow/pull/15760


   improving test coverage of the tasks from task_command.py file


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #15760: Improve test coverage of task_command.py

Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #15760:
URL: https://github.com/apache/airflow/pull/15760


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #15760: Improve test coverage of task_command.py FIXES: #15524

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15760:
URL: https://github.com/apache/airflow/pull/15760#issuecomment-836743450


   [The Workflow run](https://github.com/apache/airflow/actions/runs/828225490) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] vikramcse commented on pull request #15760: Improve test coverage of task_command.py FIXES: #15524

Posted by GitBox <gi...@apache.org>.
vikramcse commented on pull request #15760:
URL: https://github.com/apache/airflow/pull/15760#issuecomment-836692551


   Hello, 
   I am not able to figure out how the `failed_deps` functionality works. 
   for writing test for the task, I want to understand how to reproduce the task.
   It will be helpful for me, if I get some suggestions
   thanks :) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #15760: Improve test coverage of task_command.py

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #15760:
URL: https://github.com/apache/airflow/pull/15760#issuecomment-841001482


   Should be "good enough" for now @vikramcse ! Thanks for taking care about it . 
   
   We can treat the  ``failed_deps`` separately.
   
   Basically how to test it - I think we do not really need to test it thoroughly, We just need to refer one of the example DAGs and run the test for it to return any value. The "get_failed_dep_statuses" is already tested in Unit test (via `test_respects_prev_dagrun_dep`) and I think the CLI tests are more of a "smoke" tests that test if given command can be run and not fail due to imports etc.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #15760: Improve test coverage of task_command.py FIXES: #15524

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15760:
URL: https://github.com/apache/airflow/pull/15760#issuecomment-836744390


   [The Workflow run](https://github.com/apache/airflow/actions/runs/828262569) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org