You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/23 13:54:25 UTC
[GitHub] [flink] alpinegizmo opened a new pull request #11885: [FLINK-17352][docs] Fix doc links using site.baseurl w/ link tag
alpinegizmo opened a new pull request #11885:
URL: https://github.com/apache/flink/pull/11885
## What is the purpose of the change
There are 100+ broken links in the docs, due to misuse of the `{% link %}` liquid tag. This tag includes site.baseurl automatically, so specifying
`{{ site.baseurl }}{% link foo.md %}` includes the baseurl twice. Since the baseurl in development is empty, it's easy to make a mess without realizing it.
## Brief change log
Removed site.baseurl everywhere it could be found in combination with the link tag.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on issue #11885: [FLINK-17352][docs] Fix doc links using site.baseurl w/ link tag
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11885:
URL: https://github.com/apache/flink/pull/11885#issuecomment-618410217
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f366d99cb42e5464f56a13f7cf0b8f83bf4dcb6b",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161639150",
"triggerID" : "f366d99cb42e5464f56a13f7cf0b8f83bf4dcb6b",
"triggerType" : "PUSH"
}, {
"hash" : "f366d99cb42e5464f56a13f7cf0b8f83bf4dcb6b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=134",
"triggerID" : "f366d99cb42e5464f56a13f7cf0b8f83bf4dcb6b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f366d99cb42e5464f56a13f7cf0b8f83bf4dcb6b Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/161639150) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=134)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on issue #11885: [FLINK-17352][docs] Fix doc links using site.baseurl w/ link tag
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11885:
URL: https://github.com/apache/flink/pull/11885#issuecomment-618410217
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f366d99cb42e5464f56a13f7cf0b8f83bf4dcb6b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f366d99cb42e5464f56a13f7cf0b8f83bf4dcb6b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f366d99cb42e5464f56a13f7cf0b8f83bf4dcb6b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sjwiesman commented on issue #11885: [FLINK-17352][docs] Fix doc links using site.baseurl w/ link tag
Posted by GitBox <gi...@apache.org>.
sjwiesman commented on issue #11885:
URL: https://github.com/apache/flink/pull/11885#issuecomment-618449395
I fixed what I could, many of the links are on pages that have already been translated. I've opened a follow up ticket.
https://issues.apache.org/jira/browse/FLINK-17353
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sjwiesman edited a comment on issue #11885: [FLINK-17352][docs] Fix doc links using site.baseurl w/ link tag
Posted by GitBox <gi...@apache.org>.
sjwiesman edited a comment on issue #11885:
URL: https://github.com/apache/flink/pull/11885#issuecomment-618436232
@alpinegizmo I found a number of broken links still within the docs. I'll fix these while merging.
```
http://localhost:4000/concepts/stream-processing.html:
Remote file does not exist -- broken link!!!
--
http://localhost:4000/concepts/programming-model.html:
Remote file does not exist -- broken link!!!
--
http://localhost:4000/concepts/runtime.html:
Remote file does not exist -- broken link!!!
--
http://localhost:4000/internals/stream_checkpointing.html:
Remote file does not exist -- broken link!!!
--
http://localhost:4000/zh/concepts/flink-architecture.html:
Remote file does not exist -- broken link!!!
--
http://localhost:4000/dev/best_practices.html:
Remote file does not exist -- broken link!!!
--
http://localhost:4000/ops/memory/config.html:
Remote file does not exist -- broken link!!!
--
http://localhost:4000/zh/concepts/programming-model.html:
Remote file does not exist -- broken link!!!
--
http://localhost:4000/zh/concepts/runtime.html:
Remote file does not exist -- broken link!!!
--
http://localhost:4000/dev/dev/table/python/installation.html:
Remote file does not exist -- broken link!!!
--
http://localhost:4000/fig/times_clocks.svg:
Remote file does not exist -- broken link!!!
--
http://localhost:4000/zh/internals/stream_checkpointing.html:
Remote file does not exist -- broken link!!!
--
http://localhost:4000/zh/dev/table/sql.html:
Remote file does not exist -- broken link!!!
--
http://localhost:4000/zh/ops/memory/config.html:
Remote file does not exist -- broken link!!!
--
http://localhost:4000/s3.zh.mdops/deployment/hadoop.html:
Remote file does not exist -- broken link!!!
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on issue #11885: [FLINK-17352][docs] Fix doc links using site.baseurl w/ link tag
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11885:
URL: https://github.com/apache/flink/pull/11885#issuecomment-618403651
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit f366d99cb42e5464f56a13f7cf0b8f83bf4dcb6b (Thu Apr 23 13:47:16 UTC 2020)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sjwiesman commented on issue #11885: [FLINK-17352][docs] Fix doc links using site.baseurl w/ link tag
Posted by GitBox <gi...@apache.org>.
sjwiesman commented on issue #11885:
URL: https://github.com/apache/flink/pull/11885#issuecomment-618436232
@alpinegizmo I found a number of broken links still within the docs.
```
http://localhost:4000/concepts/stream-processing.html:
Remote file does not exist -- broken link!!!
--
http://localhost:4000/concepts/programming-model.html:
Remote file does not exist -- broken link!!!
--
http://localhost:4000/concepts/runtime.html:
Remote file does not exist -- broken link!!!
--
http://localhost:4000/internals/stream_checkpointing.html:
Remote file does not exist -- broken link!!!
--
http://localhost:4000/zh/concepts/flink-architecture.html:
Remote file does not exist -- broken link!!!
--
http://localhost:4000/dev/best_practices.html:
Remote file does not exist -- broken link!!!
--
http://localhost:4000/ops/memory/config.html:
Remote file does not exist -- broken link!!!
--
http://localhost:4000/zh/concepts/programming-model.html:
Remote file does not exist -- broken link!!!
--
http://localhost:4000/zh/concepts/runtime.html:
Remote file does not exist -- broken link!!!
--
http://localhost:4000/dev/dev/table/python/installation.html:
Remote file does not exist -- broken link!!!
--
http://localhost:4000/fig/times_clocks.svg:
Remote file does not exist -- broken link!!!
--
http://localhost:4000/zh/internals/stream_checkpointing.html:
Remote file does not exist -- broken link!!!
--
http://localhost:4000/zh/dev/table/sql.html:
Remote file does not exist -- broken link!!!
--
http://localhost:4000/zh/ops/memory/config.html:
Remote file does not exist -- broken link!!!
--
http://localhost:4000/s3.zh.mdops/deployment/hadoop.html:
Remote file does not exist -- broken link!!!
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org