You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/12/29 10:48:12 UTC

[GitHub] [incubator-dolphinscheduler] chengshiwen opened a new pull request #4339: [FIx-4338][UI] Fix invalid date problem in IE

chengshiwen opened a new pull request #4339:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4339


   ## *Tips*
   - *Thanks very much for contributing to Apache DolphinScheduler.*
   - *Please review https://dolphinscheduler.apache.org/en-us/community/index.html before opening a pull request.*
   
   ## What is the purpose of the pull request
   
   Fix invalid date problem in IE
   This closes #4338
   
   ## Brief change log
   
   *(for example:)*
     - *Modify formatDate in dolphinscheduler-ui/src/js/module/filter/filter.js*
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
     - *Manually verified the change by testing locally.*
   
   After fix:
   ![image](https://user-images.githubusercontent.com/4902714/103278389-561e0800-4a06-11eb-8f3d-cf27ba51d50c.png)
   ![image](https://user-images.githubusercontent.com/4902714/103278394-59b18f00-4a06-11eb-9176-7361944ad3be.png)
   ![image](https://user-images.githubusercontent.com/4902714/103278400-5d451600-4a06-11eb-996b-4eb0bf3cdada.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] codecov-io commented on pull request #4339: [FIx-4338][UI] Fix invalid date problem in IE

Posted by GitBox <gi...@apache.org>.

codecov-io commented on pull request #4339:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4339#issuecomment-752316466


   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4339?src=pr&el=h1) Report
   > Merging [#4339](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4339?src=pr&el=desc) (394e55e) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/806e8d9b6058d31dd4591583f2e81b8f6cd7162a?el=desc) (806e8d9) will **decrease** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4339/graphs/tree.svg?width=650&height=150&src=pr&token=bv9iXXRLi9)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4339?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##                dev    #4339      +/-   ##
   ============================================
   - Coverage     43.22%   43.21%   -0.01%     
   + Complexity     3184     3183       -1     
   ============================================
     Files           471      471              
     Lines         21732    21732              
     Branches       2626     2626              
   ============================================
   - Hits           9393     9391       -2     
   - Misses        11442    11444       +2     
     Partials        897      897              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4339?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...inscheduler/service/zk/CuratorZookeeperClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4339/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvemsvQ3VyYXRvclpvb2tlZXBlckNsaWVudC5qYXZh) | `60.97% <0.00%> (-4.88%)` | `7.00% <0.00%> (-1.00%)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4339?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4339?src=pr&el=footer). Last update [806e8d9...394e55e](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4339?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] xingchun-chen merged pull request #4339: [FIx-4338][UI] Fix invalid date problem in IE

Posted by GitBox <gi...@apache.org>.

xingchun-chen merged pull request #4339:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4339


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] chengshiwen commented on pull request #4339: [FIx-4338][UI] Fix invalid date problem in IE

Posted by GitBox <gi...@apache.org>.

chengshiwen commented on pull request #4339:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4339#issuecomment-752036494


   The unit test error is just from `dolphinscheduler-remote`:
   
   ![image](https://user-images.githubusercontent.com/4902714/103279319-78188a00-4a08-11eb-8620-c8e16a79085f.png)
   ![image](https://user-images.githubusercontent.com/4902714/103279288-6a630480-4a08-11eb-9709-754db29eec4e.png)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #4339: [FIx-4338][UI] Fix invalid date problem in IE

Posted by GitBox <gi...@apache.org>.

sonarcloud[bot] commented on pull request #4339:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4339#issuecomment-752316896


   Kudos, SonarCloud Quality Gate passed!
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4339&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4339&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4339&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4339&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4339&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4339&resolved=false&types=VULNERABILITY)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=4339&resolved=false&types=SECURITY_HOTSPOT) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=4339&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=4339&resolved=false&types=SECURITY_HOTSPOT)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4339&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4339&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4339&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=4339&metric=coverage&view=list) No Coverage information  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=4339&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=4339&metric=new_duplicated_lines_density&view=list)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org