You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "1996fanrui (via GitHub)" <gi...@apache.org> on 2023/06/30 03:16:21 UTC

[GitHub] [flink] 1996fanrui opened a new pull request, #22912: [FLINK-32495][connectors/common] Fix the bug that the shared thread factory causes the source alignment unit test to fail

1996fanrui opened a new pull request, #22912:
URL: https://github.com/apache/flink/pull/22912

   ## What is the purpose of the change
   
   SourceCoordinatorAlignmentTest.testWatermarkAlignmentWithTwoGroups fails.
   
   I analyzed this CI :  https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=50668&view=logs&j=a57e0635-3fad-5b08-57c7-a4142d7d6fa9&t=2ef0effc-1da1-50e5-c2bd-aab434b1c5b7&l=9089
   
   Root cause:
   
   - The CoordinatorExecutorThreadFactory cannot new multiple threads. And too many callers will check `coordinatorThreadFactory.isCurrentThreadCoordinatorThread()`, such as: SourceCoordinatorContext.attemptReady.
   - The CoordinatorExecutorThreadFactory is shared at [SourceCoordinatorTestBase](https://github.com/apache/flink/blob/21eba4ca4cb235a2189c94cdbf3abcec5cde1e6e/flink-runtime/src/test/java/org/apache/flink/runtime/source/coordinator/SourceCoordinatorTestBase.java#L68)
   - It will be used at multiple source coordinator, and the second source coordinator will overwrite the CoordinatorExecutorThreadFactory#t, so the check will fail for the first source.
   
   ## Brief change log
   
   Don't share the CoordinatorExecutorThreadFactory.
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): ( no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: ( no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #22912: [FLINK-32495][connectors/common] Fix the bug that the shared thread factory causes the source alignment unit test to fail

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #22912:
URL: https://github.com/apache/flink/pull/22912#issuecomment-1614061350

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c992b37ae080d255484f893e935475cabf59add5",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c992b37ae080d255484f893e935475cabf59add5",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c992b37ae080d255484f893e935475cabf59add5 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] 1996fanrui commented on pull request #22912: [FLINK-32495][connectors/common] Fix the bug that the shared thread factory causes the source alignment unit test to fail

Posted by "1996fanrui (via GitHub)" <gi...@apache.org>.
1996fanrui commented on PR #22912:
URL: https://github.com/apache/flink/pull/22912#issuecomment-1614432315

   Thanks to @RocMarshal for the quick review, merging.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] 1996fanrui merged pull request #22912: [FLINK-32495][connectors/common] Fix the bug that the shared thread factory causes the source alignment unit test to fail

Posted by "1996fanrui (via GitHub)" <gi...@apache.org>.
1996fanrui merged PR #22912:
URL: https://github.com/apache/flink/pull/22912


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org