[GitHub] [solr] janhoy commented on a change in pull request #368: SOLR-15717:fix resource leak due to Files.find

[GitBox <gi...@apache.org>]

janhoy commented on a change in pull request #368:
URL: https://github.com/apache/solr/pull/368#discussion_r736330849



##########
File path: solr/core/src/java/org/apache/solr/handler/IndexFetcher.java
##########
@@ -1304,8 +1305,8 @@ private boolean moveIndexFiles(Directory tmpIdxDir, Directory indexDir) {
    * TODO: return the stream directly

Review comment:
       Please remove this TODO, as we'll obviously not want that?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org