[GitHub] fabianmenges commented on a change in pull request #3436: Adding hook for external password store for databases

[gi...@git.apache.org]

fabianmenges commented on a change in pull request #3436: Adding hook for external password store for databases
URL: https://github.com/apache/incubator-superset/pull/3436#discussion_r138504641
 
 

 ##########
 File path: tests/core_tests.py
 ##########
 @@ -296,6 +297,19 @@ def test_testconn(self):
         assert response.status_code == 200
         assert response.headers['Content-Type'] == 'application/json'
 
+    def test_custom_password_store(self):
+        database = self.get_main_database(db.session)
+        conn_pre = sqla.engine.url.make_url(database.sqlalchemy_uri_decrypted)
+
+        def custom_password_store(uri):
+            return "password_store_test"
+
+        database.custom_password_store = custom_password_store
+        conn = sqla.engine.url.make_url(database.sqlalchemy_uri_decrypted)
+        if conn_pre.password:
 
 Review comment:
   Sqlite does not support passwords, so this test would fail otherwise.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services