You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/04/06 08:05:46 UTC
[GitHub] [rocketmq] MatrixHB opened a new pull request, #4121: [ISSUE #4109] add permission validation on broker side for ordinary topic
MatrixHB opened a new pull request, #4121:
URL: https://github.com/apache/rocketmq/pull/4121
to solve the problem described in [ISSUE #4109](https://github.com/apache/rocketmq/issues/4109)
This change will cause the broker to throw a "NO_PERMISSION" exception. If the producer use SYNC mode, it will retry sending to another broker, seeing [DefaultMQProducerImpl#sendDefaultImpl](https://github.com/apache/rocketmq/blob/develop/client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java#L562-L627) so the SYNC mode will not be affected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] dongeforever commented on pull request #4121: [ISSUE #4109] add permission validation on broker side for ordinary topic
Posted by GitBox <gi...@apache.org>.
dongeforever commented on PR #4121:
URL: https://github.com/apache/rocketmq/pull/4121#issuecomment-1090061646
Adding the perm check for ordinary topic, the client will get exceptions and cannot failover during the matadata discovery time, which is up to 30 seconds.
For ordinary topics, the original design expects the client to discover the new topic route and send only to the writable brokers, which introduces no exceptions and makes the wipe-perm process more smoothly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #4121: [ISSUE #4109] add permission validation on broker side for ordinary topic
Posted by GitBox <gi...@apache.org>.
coveralls commented on PR #4121:
URL: https://github.com/apache/rocketmq/pull/4121#issuecomment-1090024380
[](https://coveralls.io/builds/48041665)
Coverage decreased (-0.2%) to 51.728% when pulling **9e9c160996eef8b87c5fc709d4c9504d792fdaf3 on MatrixHB:fix_broker_permission** into **e7c87fa1cee96b48993fae0eb2de3974106e9e92 on apache:develop**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #4121: [ISSUE #4109] add permission validation on broker side for ordinary topic
Posted by GitBox <gi...@apache.org>.
coveralls commented on PR #4121:
URL: https://github.com/apache/rocketmq/pull/4121#issuecomment-1090024389
[](https://coveralls.io/builds/48041665)
Coverage decreased (-0.2%) to 51.728% when pulling **9e9c160996eef8b87c5fc709d4c9504d792fdaf3 on MatrixHB:fix_broker_permission** into **e7c87fa1cee96b48993fae0eb2de3974106e9e92 on apache:develop**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] MatrixHB commented on pull request #4121: [ISSUE #4109] add permission validation on broker side for ordinary topic
Posted by GitBox <gi...@apache.org>.
MatrixHB commented on PR #4121:
URL: https://github.com/apache/rocketmq/pull/4121#issuecomment-1090075723
> Adding the perm check for ordinary topic, the client will get exceptions and cannot failover during the matadata discovery time, which is up to 30 seconds.
>
> For ordinary topics, the original design expects the client to discover the new topic route and send only to the writable brokers, which introduces no exceptions and makes the wipe-perm process more smoothly.
Thanks, this change is not so elegant actually. Maybe updating the client version is enough to solve this problem. Next time we meet this trouble we can discuss this again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] MatrixHB closed pull request #4121: [ISSUE #4109] add permission validation on broker side for ordinary topic
Posted by GitBox <gi...@apache.org>.
MatrixHB closed pull request #4121: [ISSUE #4109] add permission validation on broker side for ordinary topic
URL: https://github.com/apache/rocketmq/pull/4121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org