You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2019/11/13 11:53:36 UTC

[GitHub] [nifi] bartektartanus opened a new pull request #3885: NIFI-6836 Increased topic list length in ConsumeKafka and added validator

bartektartanus opened a new pull request #3885: NIFI-6836 Increased topic list length in ConsumeKafka and added validator
URL: https://github.com/apache/nifi/pull/3885
 
 
   #### Description of PR
   
   NIFI-6836 - this PR increases the topic length limit from 100 to 1000 and also adds validator to warn the user about it. 
   
   I've submitted this issue few days ago and prepared initial version of PR - fixed only for `KafkaConsumer1_0`. This bug is in every Kafka Consumer, from 0_10 to 2_0. I can also make changes in all files, but maybe some refactoring should be done? Some `AbstractKafkaConsumer` with all common properties? Or maybe current approach is intended as you do want to mix code between different versions of Kafka Consumer?
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
        in the commit message?
   
   - [x] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [x] Has your PR been rebased against the latest commit within the target branch (typically `master`)?
   
   - [x] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
   
   ### For code changes:
   - [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
   - [x] Have you written or updated unit tests to verify your changes?
   - [ ] Have you verified that the full build is successful on both JDK 8 and JDK 11?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services