You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ms...@apache.org on 2018/02/27 17:24:05 UTC
svn commit: r1825473 - in
/pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools:
PDFText2HTML.java PDFToImage.java
Author: msahyoun
Date: Tue Feb 27 17:24:05 2018
New Revision: 1825473
URL: http://svn.apache.org/viewvc?rev=1825473&view=rev
Log:
PDFBOX-4134: use Float.compare to compare float(s)
Modified:
pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/PDFText2HTML.java
pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/PDFToImage.java
Modified: pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/PDFText2HTML.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/PDFText2HTML.java?rev=1825473&r1=1825472&r2=1825473&view=diff
==============================================================================
--- pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/PDFText2HTML.java (original)
+++ pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/PDFText2HTML.java Tue Feb 27 17:24:05 2018
@@ -118,7 +118,7 @@ public class PDFText2HTML extends PDFTex
float currentFontSize = position.getFontSize();
//If we're past 64 chars we will assume that we're past the title
//64 is arbitrary
- if (currentFontSize != lastFontSize || titleText.length() > 64)
+ if (Float.compare(currentFontSize, lastFontSize) != 0 || titleText.length() > 64)
{
if (titleText.length() > 0)
{
Modified: pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/PDFToImage.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/PDFToImage.java?rev=1825473&r1=1825472&r2=1825473&view=diff
==============================================================================
--- pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/PDFToImage.java (original)
+++ pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/PDFToImage.java Tue Feb 27 17:24:05 2018
@@ -220,8 +220,10 @@ public final class PDFToImage
//if a CropBox has been specified, update the CropBox:
//changeCropBoxes(PDDocument document,float a, float b, float c,float d)
- if ( cropBoxLowerLeftX!=0 || cropBoxLowerLeftY!=0
- || cropBoxUpperRightX!=0 || cropBoxUpperRightY!=0 )
+ if (Float.compare(cropBoxLowerLeftX, 0) !=0 ||
+ Float.compare(cropBoxLowerLeftY, 0) !=0 ||
+ Float.compare(cropBoxUpperRightX, 0) !=0 ||
+ Float.compare(cropBoxUpperRightY, 0) !=0 )
{
changeCropBox(document,
cropBoxLowerLeftX, cropBoxLowerLeftY,