[jira] [Commented] (GEODE-8873) MessageDispatcher logs Exception stack trace when stopped

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-8873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17273874#comment-17273874 ] 

ASF GitHub Bot commented on GEODE-8873:
---------------------------------------

DonalEvans opened a new pull request #5969:
URL: https://github.com/apache/geode/pull/5969


   - For benign exceptions encountered after stopping the MessageDispatcher, do not log the entire Exception stack trace at info level
   
   Authored-by: Donal Evans <do...@vmware.com>
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [x] Is your initial contribution a single, squashed commit?
   
   - [x] Does `gradlew build` run cleanly?
   
   - [N/A] Have you written or updated unit tests to verify your changes?
   
   - [N/A] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> MessageDispatcher logs Exception stack trace when stopped
> ---------------------------------------------------------
>
>                 Key: GEODE-8873
>                 URL: https://issues.apache.org/jira/browse/GEODE-8873
>             Project: Geode
>          Issue Type: Improvement
>          Components: logging
>    Affects Versions: 1.12.0, 1.13.1, 1.14.0
>            Reporter: Donal Evans
>            Assignee: Donal Evans
>            Priority: Major
>
> This message is logged when there are still messages in the queue when the cache server thread receives the stop signal or client leaving signal and tries to clean up the messages in the queue but encounters an exception. In the case of a {{RegionDestroyedException}} or "Broken Pipe" {{IOException}}, a brief explanation of the cause is logged, but for any other exception encountered when attempting to send messages from the queue results in a full stack trace being logged, even though the log level is only {{info}}.
> The logging should be changed to only log the exception message, not a full stack trace.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)