svn commit: r1420902 - /subversion/trunk/subversion/libsvn_ra_svn/cyrus_auth.c

[st...@apache.org]

Author: stsp
Date: Wed Dec 12 18:23:42 2012
New Revision: 1420902

URL: http://svn.apache.org/viewvc?rev=1420902&view=rev
Log:
* subversion/libsvn_ra_svn/cyrus_auth.c
  (svn_ra_svn__sasl_common_init): Wrap the call to svn_mutex__init() in
   the SVN_ERR() macro, instead of returning its return value directly.
   This avoids a 'will never be executed' warning when compiling with
   threaded APR. The 'return SVN_NO_ERROR' at the bottom of the function
   won't ever be run if we unconditionally return where svn_mutex__init()
   is called. And this also fixes error tracing in maintainer builds.

Modified:
    subversion/trunk/subversion/libsvn_ra_svn/cyrus_auth.c

Modified: subversion/trunk/subversion/libsvn_ra_svn/cyrus_auth.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_svn/cyrus_auth.c?rev=1420902&r1=1420901&r2=1420902&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_svn/cyrus_auth.c (original)
+++ subversion/trunk/subversion/libsvn_ra_svn/cyrus_auth.c Wed Dec 12 18:23:42 2012
@@ -179,7 +179,7 @@ svn_ra_svn__sasl_common_init(apr_pool_t 
                  sasl_mutex_unlock_cb,
                  sasl_mutex_free_cb);
   free_mutexes = apr_array_make(sasl_pool, 0, sizeof(svn_mutex__t *));
-  return svn_mutex__init(&array_mutex, TRUE, sasl_pool);
+  SVN_ERR(svn_mutex__init(&array_mutex, TRUE, sasl_pool));
 
 #endif /* APR_HAS_THREADS */