You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dubbo.apache.org by al...@apache.org on 2019/08/14 05:03:57 UTC
[dubbo-go] branch develop updated: Rem: version;
Mod: translate chinese to english
This is an automated email from the ASF dual-hosted git repository.
alexstocks pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/dubbo-go.git
The following commit(s) were added to refs/heads/develop by this push:
new a560c3c Rem: version; Mod: translate chinese to english
a560c3c is described below
commit a560c3c5e7151e1e9047cc8d074314fb51847891
Author: AlexStocks <al...@foxmail.com>
AuthorDate: Wed Aug 14 13:03:41 2019 +0800
Rem: version;
Mod: translate chinese to english
---
registry/zookeeper/registry.go | 8 +++++---
version/version.go | 24 ------------------------
2 files changed, 5 insertions(+), 27 deletions(-)
diff --git a/registry/zookeeper/registry.go b/registry/zookeeper/registry.go
index 9ce3ee5..003ee29 100644
--- a/registry/zookeeper/registry.go
+++ b/registry/zookeeper/registry.go
@@ -232,8 +232,9 @@ func (r *zkRegistry) Register(conf common.URL) error {
// Check if the service has been registered
r.cltLock.Lock()
- // 注意此处与consumerZookeeperRegistry的差异,consumer用的是conf.Path,
- // 因为consumer要提供watch功能给selector使用, provider允许注册同一个service的多个group or version
+ // Note the difference between consumer and consumerZookeeperRegistry (consumer use conf.Path).
+ // Because the consumer wants to provide monitoring functions for the selector,
+ // the provider allows multiple groups or versions of the same service to be registered.
_, ok = r.services[conf.Key()]
r.cltLock.Unlock()
if ok {
@@ -298,7 +299,8 @@ func (r *zkRegistry) register(c common.URL) error {
}
params.Add("anyhost", "true")
- // dubbo java consumer来启动找provider url时,因为category不匹配,会找不到provider,导致consumer启动不了,所以使用consumers&providers
+ // Dubbo java consumer to start looking for the provider url,because the category does not match,
+ // the provider will not find, causing the consumer can not start, so we use consumers.
// DubboRole = [...]string{"consumer", "", "", "provider"}
// params.Add("category", (RoleType(PROVIDER)).Role())
params.Add("category", (common.RoleType(common.PROVIDER)).String())
diff --git a/version/version.go b/version/version.go
deleted file mode 100644
index b9a076e..0000000
--- a/version/version.go
+++ /dev/null
@@ -1,24 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package version
-
-const (
- Version = "2.6.0"
- Name = "dubbogo"
- DATE = "2019/05/06"
-)