You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Gilles Sadowski (Jira)" <ji...@apache.org> on 2021/04/22 09:08:00 UTC

[jira] [Comment Edited] (NUMBERS-77) Move utilities from "Commons Geometry"

    [ https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17327190#comment-17327190 ] 

Gilles Sadowski edited comment on NUMBERS-77 at 4/22/21, 9:07 AM:
------------------------------------------------------------------

I think that the {{sign(double a)}} method should be removed from the API, being just syntactic sugar for {{compare(a, 0d)}}.

Or maybe {{signum(double a)}} was actually intended (?), in which case the return type should also be changed.


was (Author: erans):
I think that the {{sign(double a)}} method should be removed from the API, being just syntactic sugar for {{compare(a, 0d)}}.

> Move utilities from "Commons Geometry"
> --------------------------------------
>
>                 Key: NUMBERS-77
>                 URL: https://issues.apache.org/jira/browse/NUMBERS-77
>             Project: Commons Numbers
>          Issue Type: Task
>            Reporter: Gilles Sadowski
>            Priority: Major
>             Fix For: 1.1
>
>         Attachments: NUMBERS-77.diff
>
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> "Commons Geometry" defines utilities that would be a better fit in this component.
> Duplication of general-purpose codes should be avoided, in order to benefit from consolidated usage (bug reporting, performance enhancements, ...).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)