[GitHub] [nifi-minifi] kevdoran commented on a change in pull request #168: MINIFI-512 Change bootstrap port command handling

[GitBox <gi...@apache.org>]

kevdoran commented on a change in pull request #168: MINIFI-512 Change bootstrap port command handling
URL: https://github.com/apache/nifi-minifi/pull/168#discussion_r323709034
 
 

 ##########
 File path: minifi-bootstrap/src/main/java/org/apache/nifi/minifi/bootstrap/RunMiNiFi.java
 ##########
 @@ -1562,6 +1564,12 @@ void setAutoRestartNiFi(final boolean restart) {
     }
 
     void setMiNiFiCommandControlPort(final int port, final String secretKey) throws IOException {
+
+        if (this.secretKey != null && this.ccPort != UNINITIALIZED_CC_PORT) {
 
 Review comment:
   Thanks for taking a look @jzonthemtn. These two values always have to be set together. I made it `&&` in case (in the future, I do not see this possibility in the current code) the bootstrap process ever got into a bad state where it was partially initialized, we would probably still want to allow processing this command again to attempt to retry to get it fully initialized. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services