You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Kay Kay (JIRA)" <ji...@apache.org> on 2010/03/26 20:32:27 UTC
[jira] Created: (ZOOKEEPER-729) zkCli.sh -rmr /node
zkCli.sh -rmr /node
-------------------
Key: ZOOKEEPER-729
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729
Project: Zookeeper
Issue Type: New Feature
Reporter: Kay Kay
Recursively delete a given znode in zookeeper, from the command-line.
New operation "rmr" added to zkclient.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-729) Recursively delete a znode -
zkCli.sh rmr /node
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856222#action_12856222 ]
Kay Kay commented on ZOOKEEPER-729:
-----------------------------------
The build seems to have failed, although the tests seem to have passed.
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/51/testReport/org.apache.zookeeper/ZooKeeperTest/ .
Any idea why the build failed ?
> Recursively delete a znode - zkCli.sh rmr /node
> ------------------------------------------------
>
> Key: ZOOKEEPER-729
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729
> Project: Zookeeper
> Issue Type: New Feature
> Components: java client
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch
>
>
> Recursively delete a given znode in zookeeper, from the command-line.
> New operation "rmr" added to zkclient.
> $ ./zkCli.sh rmr /node
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ZOOKEEPER-729) Recursively delete a znode -
zkCli.sh rmr /node
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kay Kay updated ZOOKEEPER-729:
------------------------------
Status: Open (was: Patch Available)
> Recursively delete a znode - zkCli.sh rmr /node
> ------------------------------------------------
>
> Key: ZOOKEEPER-729
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729
> Project: Zookeeper
> Issue Type: New Feature
> Components: java client
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-729.patch, ZOOKEEPER-729.patch
>
>
> Recursively delete a given znode in zookeeper, from the command-line.
> New operation "rmr" added to zkclient.
> $ ./zkCli.sh rmr /node
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-729) Recursively delete a znode -
zkCli.sh rmr /node
Posted by "Henry Robinson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857015#action_12857015 ]
Henry Robinson commented on ZOOKEEPER-729:
------------------------------------------
Hudson can't post messages to JIRA currently, but as Kay says the build looked good. So I'm +1 on this patch, and will commit it later today unless anyone shouts at this breach of protocol :)
> Recursively delete a znode - zkCli.sh rmr /node
> ------------------------------------------------
>
> Key: ZOOKEEPER-729
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729
> Project: Zookeeper
> Issue Type: New Feature
> Components: java client
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch
>
>
> Recursively delete a given znode in zookeeper, from the command-line.
> New operation "rmr" added to zkclient.
> $ ./zkCli.sh rmr /node
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ZOOKEEPER-729) Recursively delete a znode -
zkCli.sh rmr /node
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855252#action_12855252 ]
Patrick Hunt commented on ZOOKEEPER-729:
----------------------------------------
Sorry Kay, we're trying to catchup with some things after the release... No excuses though. ;-) Thanks Henry for picking this up,
esp the focus on testing. We're always looking for ppl interested in eventually becoming committers, this requires some
significant contributions, esp with a focus on working with the community (doing great here) and focus on quality (testing).
Take a look at this example of testing ZooKeeperMain code, you can probably base your own (maybe general
ZooKeeperMainTest) off this:
src/java/test/org/apache/zookeeper/test/ZooKeeperQuotaTest.java
> Recursively delete a znode - zkCli.sh rmr /node
> ------------------------------------------------
>
> Key: ZOOKEEPER-729
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729
> Project: Zookeeper
> Issue Type: New Feature
> Components: java client
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-729.patch, ZOOKEEPER-729.patch
>
>
> Recursively delete a given znode in zookeeper, from the command-line.
> New operation "rmr" added to zkclient.
> $ ./zkCli.sh rmr /node
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-729) Recursively delete a znode -
zkCli.sh rmr /node
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856230#action_12856230 ]
Patrick Hunt commented on ZOOKEEPER-729:
----------------------------------------
[exec] -1 javadoc. The javadoc tool appears to have generated 1 warning messages.
Also, there's all kinds of fallout because of the security breach from friday. afaict infra ops is still making changes.
I'll ping Giri again (may be a known issue).
but it seems that hudson is unable to update JIRA. so Something is still borked regardless.
> Recursively delete a znode - zkCli.sh rmr /node
> ------------------------------------------------
>
> Key: ZOOKEEPER-729
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729
> Project: Zookeeper
> Issue Type: New Feature
> Components: java client
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch
>
>
> Recursively delete a given znode in zookeeper, from the command-line.
> New operation "rmr" added to zkclient.
> $ ./zkCli.sh rmr /node
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ZOOKEEPER-729) zkCli.sh -rmr /node
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-729:
-----------------------------------
Component/s: java client
c client
Description:
Recursively delete a given znode in zookeeper, from the command-line.
New operation "rmr" added to zkclient.
was:
Recursively delete a given znode in zookeeper, from the command-line.
New operation "rmr" added to zkclient.
usage:
$ zkCli.sh rmr /node
Fix Version/s: (was: 3.3.1)
Assignee: Kay Kay
Summary: zkCli.sh -rmr /node (was: Recursively Delete a znode )
Thanks Kay, since this is a new feature and not a fix I'm marking for just 3.4.0
It would be great if you could include this change in the c client as well. Would you mind updating
the patch for that as well?
You added a new "rmr" command, rather could you just add a "-r" option to the delete command (see create for
similar command line options on a command)
I see that you are using sync operations, did you consider using async? It would be much faster and would be a
great example for users.
> zkCli.sh -rmr /node
> -------------------
>
> Key: ZOOKEEPER-729
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729
> Project: Zookeeper
> Issue Type: New Feature
> Components: c client, java client
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-729.patch
>
>
> Recursively delete a given znode in zookeeper, from the command-line.
> New operation "rmr" added to zkclient.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-729) Recursively delete a znode -
zkCli.sh rmr /node
Posted by "Henry Robinson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855251#action_12855251 ]
Henry Robinson commented on ZOOKEEPER-729:
------------------------------------------
Patch looks pretty good! A few nits:
1. Your tab level seems to be set to two spaces, but the standard is to use four tabs per space
2. I would change the LOG levels to DEBUG instead of INFO.
3. Consider calling listSubTree listSubTreeBFS? I agree about making the strategy explicit, I feel this is the best way to do it.
4. You should be explicit in the listSubTree comment that this is *not* an atomic snapshot and does not necessarily represent the state of the sub-tree as it ever was - particularly given that this is a public method.
5. Similarly, explicitly note in the comments that you are deleting all nodes regardless of their version.
6. Did you decide against including a -r option for delete? I'm +1 on that idea rather than rmr, but don't feel that strongly.
7. I would remove the TODO comments - I'm not a huge fan of them (anymore :) ). There is no separator constant, the BFS thing should be taken care of by renaming and we must make a decision about dealing with the async requests - my take is just to do what you are doing and just run through the entire tree.
Finally - we need a test for this! I know there's not a lot of coverage of ZooKeeper, which is not your fault - but I'm intending to be fairly militant about tests :) Check out e.g. ACLRootTest for a structure to get a server up and running and a client to connect to it. A couple of tests which verify the behaviour of both variants would be great. Ideally, we'd be able to test the behaviour when a create interleaves with a recursive delete, but that might still be hard to do without mocking up some of the code.
I'll be happy to commit this once these are sorted out, thanks for your patience.
> Recursively delete a znode - zkCli.sh rmr /node
> ------------------------------------------------
>
> Key: ZOOKEEPER-729
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729
> Project: Zookeeper
> Issue Type: New Feature
> Components: java client
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-729.patch, ZOOKEEPER-729.patch
>
>
> Recursively delete a given znode in zookeeper, from the command-line.
> New operation "rmr" added to zkclient.
> $ ./zkCli.sh rmr /node
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-729) Recursively delete a znode -
zkCli.sh rmr /node
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-729:
-----------------------------------
Status: Open (was: Patch Available)
> Recursively delete a znode - zkCli.sh rmr /node
> ------------------------------------------------
>
> Key: ZOOKEEPER-729
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729
> Project: Zookeeper
> Issue Type: New Feature
> Components: java client
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-729.patch, ZOOKEEPER-729.patch
>
>
> Recursively delete a given znode in zookeeper, from the command-line.
> New operation "rmr" added to zkclient.
> $ ./zkCli.sh rmr /node
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-729) zkCli.sh -rmr /node
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850375#action_12850375 ]
Kay Kay commented on ZOOKEEPER-729:
-----------------------------------
{quote}
It would be great if you could include this change in the c client as well. Would you mind updating
the patch for that as well?
{quote}
Would it be ok if we have a separate jira to track it. I can update the same, but the motivation for me was , when we reset a katta cluster , I wanted to have a single command to deal with resets. For consistency purposes, I can have a look at the C client as well.
{quote}
You added a new "rmr" command, rather could you just add a "-r" option to the delete command (see create for
similar command line options on a command)
{quote}
makes sense. that was an inspiration from hdfs, to avoid keystrokes, as you might have figured out already ;)
{quote}
I see that you are using sync operations, did you consider using async? It would be much faster and would be a
great example for users {quote}
I wanted to delete the nodes in order, the leaves and then the root, and was not sure what effect async will have , in that, w.r.t race conditions. Also I was testing from the cmd line and wanted to be sure that when the command returns, every child node has indeed been deleted.
Can you add some more hints ?
{quote}
1. You should get rid of the System.out.println lines - use LOG if you want to save something.
{quote}
Oops. Saw, System.err elsewhere in ZookeeperMain and confused that to be the standard with Zookeeper .
{quote}
3. If delete fails due to a NoNode exception or similar, this operation aborts I think. I'm not sure whether that's a good idea or not, but it should be documented in the comments.
{quote}
I guess, aborting is ok, so we know what is happening. May be - there could be another parameter to indicate if we are continuing / aborting.
{quote}
Something I wanted to flag up - this algorithm is not wait-free because if another process is continually adding child nodes in the right place, this will never finish.
{quote}
This is true. As I had mentioned in the assumptions - this is mostly to be used as a 1-step reset for apps, and the client apps are assumed to have been brought down completely.
May be- for now - indicating the information in the comments would do ?
> zkCli.sh -rmr /node
> -------------------
>
> Key: ZOOKEEPER-729
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729
> Project: Zookeeper
> Issue Type: New Feature
> Components: c client, java client
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-729.patch
>
>
> Recursively delete a given znode in zookeeper, from the command-line.
> New operation "rmr" added to zkclient.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-729) Recursively delete a znode -
zkCli.sh rmr /node
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kay Kay updated ZOOKEEPER-729:
------------------------------
Status: Open (was: Patch Available)
> Recursively delete a znode - zkCli.sh rmr /node
> ------------------------------------------------
>
> Key: ZOOKEEPER-729
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729
> Project: Zookeeper
> Issue Type: New Feature
> Components: java client
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch
>
>
> Recursively delete a given znode in zookeeper, from the command-line.
> New operation "rmr" added to zkclient.
> $ ./zkCli.sh rmr /node
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ZOOKEEPER-729) zkCli.sh -rmr /node
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850394#action_12850394 ]
Kay Kay commented on ZOOKEEPER-729:
-----------------------------------
With respect to the command line argument, out of curiosity , can we have something based on args4j or something similar to that for better flexibility of commands.
Tried to fit 'delete -r' in the picture, but already $2 is reserved for the number of watchers. So, checking for $3 to be '-r' and making a decision , seems a little bit round-about since we will be ignoring $2 , for the number of watchers in the recursive delete scenario ( it is -1, ). Hence left that part as before.
> zkCli.sh -rmr /node
> -------------------
>
> Key: ZOOKEEPER-729
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729
> Project: Zookeeper
> Issue Type: New Feature
> Components: java client
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-729.patch, ZOOKEEPER-729.patch
>
>
> Recursively delete a given znode in zookeeper, from the command-line.
> New operation "rmr" added to zkclient.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-729) zkCli.sh -rmr /node
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850425#action_12850425 ]
Kay Kay commented on ZOOKEEPER-729:
-----------------------------------
| Is there some way to package it up such that the user doesn't have to type lots of classpath jars?
A quick look at the examples, says that it is very light-weight , with not much dependencies. But because you have started publishing mvn artifacts with 3.3.0 , clients of zk should not be having a problem about the number, say.
|, just an issue of carrying around extra baggage.
true. i brought this up, because for extending the command-line functionality and grouping options, it would make it simpler, without worrying about the position of the args and give a getopt-like feel .
> zkCli.sh -rmr /node
> -------------------
>
> Key: ZOOKEEPER-729
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729
> Project: Zookeeper
> Issue Type: New Feature
> Components: java client
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-729.patch, ZOOKEEPER-729.patch
>
>
> Recursively delete a given znode in zookeeper, from the command-line.
> New operation "rmr" added to zkclient.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-729) Recursively delete a znode -
zkCli.sh rmr /node
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kay Kay updated ZOOKEEPER-729:
------------------------------
Description:
Recursively delete a given znode in zookeeper, from the command-line.
New operation "rmr" added to zkclient.
$ ./zkCli.sh rmr /node
was:
Recursively delete a given znode in zookeeper, from the command-line.
New operation "rmr" added to zkclient.
Summary: Recursively delete a znode - zkCli.sh rmr /node (was: zkCli.sh -rmr /node)
> Recursively delete a znode - zkCli.sh rmr /node
> ------------------------------------------------
>
> Key: ZOOKEEPER-729
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729
> Project: Zookeeper
> Issue Type: New Feature
> Components: java client
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-729.patch, ZOOKEEPER-729.patch
>
>
> Recursively delete a given znode in zookeeper, from the command-line.
> New operation "rmr" added to zkclient.
> $ ./zkCli.sh rmr /node
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-729) Recursively delete a znode -
zkCli.sh rmr /node
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kay Kay updated ZOOKEEPER-729:
------------------------------
Attachment: ZOOKEEPER-729.patch
> Recursively delete a znode - zkCli.sh rmr /node
> ------------------------------------------------
>
> Key: ZOOKEEPER-729
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729
> Project: Zookeeper
> Issue Type: New Feature
> Components: java client
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch
>
>
> Recursively delete a given znode in zookeeper, from the command-line.
> New operation "rmr" added to zkclient.
> $ ./zkCli.sh rmr /node
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ZOOKEEPER-729) Recursively delete a znode -
zkCli.sh rmr /node
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-729:
-----------------------------------
Status: Open (was: Patch Available)
> Recursively delete a znode - zkCli.sh rmr /node
> ------------------------------------------------
>
> Key: ZOOKEEPER-729
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729
> Project: Zookeeper
> Issue Type: New Feature
> Components: java client
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch
>
>
> Recursively delete a given znode in zookeeper, from the command-line.
> New operation "rmr" added to zkclient.
> $ ./zkCli.sh rmr /node
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ZOOKEEPER-729) Recursively delete a znode -
zkCli.sh rmr /node
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-729:
-----------------------------------
Status: Open (was: Patch Available)
> Recursively delete a znode - zkCli.sh rmr /node
> ------------------------------------------------
>
> Key: ZOOKEEPER-729
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729
> Project: Zookeeper
> Issue Type: New Feature
> Components: java client
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch
>
>
> Recursively delete a given znode in zookeeper, from the command-line.
> New operation "rmr" added to zkclient.
> $ ./zkCli.sh rmr /node
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ZOOKEEPER-729) Recursively delete a znode -
zkCli.sh rmr /node
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856195#action_12856195 ]
Kay Kay commented on ZOOKEEPER-729:
-----------------------------------
Patrick -Thanks for helping flipping the status. I did try to do that a couple of times ago, but hudson does not seem to pick up after the first patch !
> Recursively delete a znode - zkCli.sh rmr /node
> ------------------------------------------------
>
> Key: ZOOKEEPER-729
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729
> Project: Zookeeper
> Issue Type: New Feature
> Components: java client
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch
>
>
> Recursively delete a given znode in zookeeper, from the command-line.
> New operation "rmr" added to zkclient.
> $ ./zkCli.sh rmr /node
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ZOOKEEPER-729) zkCli.sh -rmr /node
Posted by "Henry Robinson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850359#action_12850359 ]
Henry Robinson commented on ZOOKEEPER-729:
------------------------------------------
Thanks for the patch, Kay!
I have a couple of review comments:
1. You should get rid of the System.out.println lines - use LOG if you want to save something.
2. It might be cleaner to use a LinkedList of nodes, always prepending to the front, then you can walk through it in order, but I don't mind which you do.
3. If delete fails due to a NoNode exception or similar, this operation aborts I think. I'm not sure whether that's a good idea or not, but it should be documented in the comments.
Something I wanted to flag up - this algorithm is not wait-free because if another process is continually adding child nodes in the right place, this will never finish. It is, however, obstruction-free. ISTR that ZooKeeper's wait-freedom was a significant feature in one of Flavio's presentations that I read. Are we ok relaxing this restriction for the client libraries for an unlikely edge case?
(My vote is yes, we probably are, but this is not just an academic distinction - you can build systems predicated on wait-freedom that will fail if they are actually just obstruction-free).
> zkCli.sh -rmr /node
> -------------------
>
> Key: ZOOKEEPER-729
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729
> Project: Zookeeper
> Issue Type: New Feature
> Components: c client, java client
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-729.patch
>
>
> Recursively delete a given znode in zookeeper, from the command-line.
> New operation "rmr" added to zkclient.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-729) Recursively delete a znode -
zkCli.sh rmr /node
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856612#action_12856612 ]
Kay Kay commented on ZOOKEEPER-729:
-----------------------------------
fyi - build # 55 is green with the latest patch.
> Recursively delete a znode - zkCli.sh rmr /node
> ------------------------------------------------
>
> Key: ZOOKEEPER-729
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729
> Project: Zookeeper
> Issue Type: New Feature
> Components: java client
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch
>
>
> Recursively delete a given znode in zookeeper, from the command-line.
> New operation "rmr" added to zkclient.
> $ ./zkCli.sh rmr /node
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ZOOKEEPER-729) Recursively delete a znode -
zkCli.sh rmr /node
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857289#action_12857289 ]
Kay Kay commented on ZOOKEEPER-729:
-----------------------------------
Thanks Henry for committing this / Patrick for helping review this.
> Recursively delete a znode - zkCli.sh rmr /node
> ------------------------------------------------
>
> Key: ZOOKEEPER-729
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729
> Project: Zookeeper
> Issue Type: New Feature
> Components: java client
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch
>
>
> Recursively delete a given znode in zookeeper, from the command-line.
> New operation "rmr" added to zkclient.
> $ ./zkCli.sh rmr /node
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ZOOKEEPER-729) zkCli.sh -rmr /node
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kay Kay updated ZOOKEEPER-729:
------------------------------
Component/s: (was: c client)
> zkCli.sh -rmr /node
> -------------------
>
> Key: ZOOKEEPER-729
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729
> Project: Zookeeper
> Issue Type: New Feature
> Components: java client
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-729.patch, ZOOKEEPER-729.patch
>
>
> Recursively delete a given znode in zookeeper, from the command-line.
> New operation "rmr" added to zkclient.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-729) Recursively delete a znode -
zkCli.sh rmr /node
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855254#action_12855254 ]
Kay Kay commented on ZOOKEEPER-729:
-----------------------------------
Thanks Henry / Patrick for the review. Tests is something that I was looking to add, but could not find a template to start with. Will look into that a bit more over the w/e.
Henry: as far as the command args goes, please see the couple of my comments above. I don't have a preference with rmr / -r , but I believe some light-weight library would help us a lot here and in the future to be more flexible. Will take care of the rest in the next patch.
> Recursively delete a znode - zkCli.sh rmr /node
> ------------------------------------------------
>
> Key: ZOOKEEPER-729
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729
> Project: Zookeeper
> Issue Type: New Feature
> Components: java client
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-729.patch, ZOOKEEPER-729.patch
>
>
> Recursively delete a given znode in zookeeper, from the command-line.
> New operation "rmr" added to zkclient.
> $ ./zkCli.sh rmr /node
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-729) Recursively delete a znode -
zkCli.sh rmr /node
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kay Kay updated ZOOKEEPER-729:
------------------------------
Attachment: ZOOKEEPER-729.patch
Added javadoc to ZookeeperTest + license headers
> Recursively delete a znode - zkCli.sh rmr /node
> ------------------------------------------------
>
> Key: ZOOKEEPER-729
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729
> Project: Zookeeper
> Issue Type: New Feature
> Components: java client
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch
>
>
> Recursively delete a given znode in zookeeper, from the command-line.
> New operation "rmr" added to zkclient.
> $ ./zkCli.sh rmr /node
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ZOOKEEPER-729) Recursively delete a znode -
zkCli.sh rmr /node
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856232#action_12856232 ]
Kay Kay commented on ZOOKEEPER-729:
-----------------------------------
release audit warnings mentions about - ZookeeperTest .
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/51/artifact/trunk/patchprocess/releaseAuditDiffWarnings.txt .
New patch added - that hopefully addresses the issue.
> Recursively delete a znode - zkCli.sh rmr /node
> ------------------------------------------------
>
> Key: ZOOKEEPER-729
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729
> Project: Zookeeper
> Issue Type: New Feature
> Components: java client
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch
>
>
> Recursively delete a given znode in zookeeper, from the command-line.
> New operation "rmr" added to zkclient.
> $ ./zkCli.sh rmr /node
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ZOOKEEPER-729) Recursively delete a znode -
zkCli.sh rmr /node
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857012#action_12857012 ]
Kay Kay commented on ZOOKEEPER-729:
-----------------------------------
so - good to go here ?
> Recursively delete a znode - zkCli.sh rmr /node
> ------------------------------------------------
>
> Key: ZOOKEEPER-729
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729
> Project: Zookeeper
> Issue Type: New Feature
> Components: java client
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch
>
>
> Recursively delete a given znode in zookeeper, from the command-line.
> New operation "rmr" added to zkclient.
> $ ./zkCli.sh rmr /node
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ZOOKEEPER-729) Recursively delete a znode -
zkCli.sh rmr /node
Posted by "Henry Robinson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henry Robinson updated ZOOKEEPER-729:
-------------------------------------
Status: Resolved (was: Patch Available)
Resolution: Fixed
I just committed this (had to move the test file into java/, but otherwise committed as submitted) - thanks Kay!
> Recursively delete a znode - zkCli.sh rmr /node
> ------------------------------------------------
>
> Key: ZOOKEEPER-729
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729
> Project: Zookeeper
> Issue Type: New Feature
> Components: java client
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch
>
>
> Recursively delete a given znode in zookeeper, from the command-line.
> New operation "rmr" added to zkclient.
> $ ./zkCli.sh rmr /node
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ZOOKEEPER-729) Recursively delete a znode -
zkCli.sh rmr /node
Posted by "Henry Robinson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henry Robinson updated ZOOKEEPER-729:
-------------------------------------
Hadoop Flags: [Reviewed]
+1, patch looks good to me - waiting for HudsonBot to give us its verdict.
> Recursively delete a znode - zkCli.sh rmr /node
> ------------------------------------------------
>
> Key: ZOOKEEPER-729
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729
> Project: Zookeeper
> Issue Type: New Feature
> Components: java client
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch
>
>
> Recursively delete a given znode in zookeeper, from the command-line.
> New operation "rmr" added to zkclient.
> $ ./zkCli.sh rmr /node
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ZOOKEEPER-729) Recursively delete a znode -
zkCli.sh rmr /node
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856199#action_12856199 ]
Patrick Hunt commented on ZOOKEEPER-729:
----------------------------------------
It's not you Kay, Hudson has been borked, Giri only just recently got it back.
sometimes it seems to forget pending, it's running now:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/51/
> Recursively delete a znode - zkCli.sh rmr /node
> ------------------------------------------------
>
> Key: ZOOKEEPER-729
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729
> Project: Zookeeper
> Issue Type: New Feature
> Components: java client
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch
>
>
> Recursively delete a given znode in zookeeper, from the command-line.
> New operation "rmr" added to zkclient.
> $ ./zkCli.sh rmr /node
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ZOOKEEPER-729) zkCli.sh -rmr /node
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kay Kay updated ZOOKEEPER-729:
------------------------------
Fix Version/s: 3.3.1
Status: Patch Available (was: Open)
> zkCli.sh -rmr /node
> -------------------
>
> Key: ZOOKEEPER-729
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729
> Project: Zookeeper
> Issue Type: New Feature
> Reporter: Kay Kay
> Fix For: 3.3.1
>
> Attachments: ZOOKEEPER-729.patch
>
>
> Recursively delete a given znode in zookeeper, from the command-line.
> New operation "rmr" added to zkclient.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-729) Recursively delete a znode -
zkCli.sh rmr /node
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857020#action_12857020 ]
Patrick Hunt commented on ZOOKEEPER-729:
----------------------------------------
That's fine Henry, you might just run the findbugs and RAT directly to verify (it's in build.xml, looks ok to the naked eye though).
Great job Kay, Thanks!
> Recursively delete a znode - zkCli.sh rmr /node
> ------------------------------------------------
>
> Key: ZOOKEEPER-729
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729
> Project: Zookeeper
> Issue Type: New Feature
> Components: java client
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch
>
>
> Recursively delete a given znode in zookeeper, from the command-line.
> New operation "rmr" added to zkclient.
> $ ./zkCli.sh rmr /node
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ZOOKEEPER-729) Recursively delete a znode -
zkCli.sh rmr /node
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855243#action_12855243 ]
Kay Kay commented on ZOOKEEPER-729:
-----------------------------------
Can you help look into this before this gets out of sync with the trunk. Thanks.
> Recursively delete a znode - zkCli.sh rmr /node
> ------------------------------------------------
>
> Key: ZOOKEEPER-729
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729
> Project: Zookeeper
> Issue Type: New Feature
> Components: java client
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-729.patch, ZOOKEEPER-729.patch
>
>
> Recursively delete a given znode in zookeeper, from the command-line.
> New operation "rmr" added to zkclient.
> $ ./zkCli.sh rmr /node
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-729) zkCli.sh -rmr /node
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850387#action_12850387 ]
Patrick Hunt commented on ZOOKEEPER-729:
----------------------------------------
Given Henry's comments sync might be better, albeit slower. You could stop right away if you failed to delete a znode.
> zkCli.sh -rmr /node
> -------------------
>
> Key: ZOOKEEPER-729
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729
> Project: Zookeeper
> Issue Type: New Feature
> Components: c client, java client
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-729.patch
>
>
> Recursively delete a given znode in zookeeper, from the command-line.
> New operation "rmr" added to zkclient.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-729) zkCli.sh -rmr /node
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850344#action_12850344 ]
Hadoop QA commented on ZOOKEEPER-729:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12439903/ZOOKEEPER-729.patch
against trunk revision 925362.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/39/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/39/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/39/console
This message is automatically generated.
> zkCli.sh -rmr /node
> -------------------
>
> Key: ZOOKEEPER-729
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729
> Project: Zookeeper
> Issue Type: New Feature
> Components: c client, java client
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-729.patch
>
>
> Recursively delete a given znode in zookeeper, from the command-line.
> New operation "rmr" added to zkclient.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-729) Recursively delete a znode -
zkCli.sh rmr /node
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kay Kay updated ZOOKEEPER-729:
------------------------------
Attachment: ZOOKEEPER-729.patch
1 /2 . Fixed
3. Renamed the method with BFS suffix. Strategy of tree crawling can come in a subsequent patch, I guess and would be out of scope for this one.
4.5. comments added.
6. Left as it is .
7. TODO-s should be out.
ZooKeeperTest added with method - testDeleteRecursive() .
callback for async of delete recursive needs to be more meaningful than what it is now.
> Recursively delete a znode - zkCli.sh rmr /node
> ------------------------------------------------
>
> Key: ZOOKEEPER-729
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729
> Project: Zookeeper
> Issue Type: New Feature
> Components: java client
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch
>
>
> Recursively delete a given znode in zookeeper, from the command-line.
> New operation "rmr" added to zkclient.
> $ ./zkCli.sh rmr /node
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-729) Recursively delete a znode -
zkCli.sh rmr /node
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kay Kay updated ZOOKEEPER-729:
------------------------------
Status: Patch Available (was: Open)
> Recursively delete a znode - zkCli.sh rmr /node
> ------------------------------------------------
>
> Key: ZOOKEEPER-729
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729
> Project: Zookeeper
> Issue Type: New Feature
> Components: java client
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch
>
>
> Recursively delete a given znode in zookeeper, from the command-line.
> New operation "rmr" added to zkclient.
> $ ./zkCli.sh rmr /node
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ZOOKEEPER-729) Recursively delete a znode -
zkCli.sh rmr /node
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857268#action_12857268 ]
Hudson commented on ZOOKEEPER-729:
----------------------------------
Integrated in ZooKeeper-trunk #794 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/794/])
ZOOKEEPER-729. Java client API to recursively delete a subtree. (Kay Kay via henry)
> Recursively delete a znode - zkCli.sh rmr /node
> ------------------------------------------------
>
> Key: ZOOKEEPER-729
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729
> Project: Zookeeper
> Issue Type: New Feature
> Components: java client
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch
>
>
> Recursively delete a given znode in zookeeper, from the command-line.
> New operation "rmr" added to zkclient.
> $ ./zkCli.sh rmr /node
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ZOOKEEPER-729) Recursively delete a znode -
zkCli.sh rmr /node
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kay Kay updated ZOOKEEPER-729:
------------------------------
Attachment: (was: ZOOKEEPER-729.patch)
> Recursively delete a znode - zkCli.sh rmr /node
> ------------------------------------------------
>
> Key: ZOOKEEPER-729
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729
> Project: Zookeeper
> Issue Type: New Feature
> Components: java client
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch
>
>
> Recursively delete a given znode in zookeeper, from the command-line.
> New operation "rmr" added to zkclient.
> $ ./zkCli.sh rmr /node
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ZOOKEEPER-729) Recursively delete a znode -
zkCli.sh rmr /node
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kay Kay updated ZOOKEEPER-729:
------------------------------
Status: Patch Available (was: Open)
> Recursively delete a znode - zkCli.sh rmr /node
> ------------------------------------------------
>
> Key: ZOOKEEPER-729
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729
> Project: Zookeeper
> Issue Type: New Feature
> Components: java client
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-729.patch, ZOOKEEPER-729.patch
>
>
> Recursively delete a given znode in zookeeper, from the command-line.
> New operation "rmr" added to zkclient.
> $ ./zkCli.sh rmr /node
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-729) zkCli.sh -rmr /node
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850405#action_12850405 ]
Patrick Hunt commented on ZOOKEEPER-729:
----------------------------------------
Can you make it optional similar to jline? I suspect not... Is there some way to package it up such that the user
doesn't have to type lots of classpath jars?
https://args4j.dev.java.net/
the code is MIT license so that's ok, just an issue of carrying around extra baggage...
> zkCli.sh -rmr /node
> -------------------
>
> Key: ZOOKEEPER-729
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729
> Project: Zookeeper
> Issue Type: New Feature
> Components: java client
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-729.patch, ZOOKEEPER-729.patch
>
>
> Recursively delete a given znode in zookeeper, from the command-line.
> New operation "rmr" added to zkclient.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-729) zkCli.sh -rmr /node
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kay Kay updated ZOOKEEPER-729:
------------------------------
Attachment: ZOOKEEPER-729.patch
LOG is in, replacing System.out/.err for Zookeeper.
Comments added to delete functionality indicating the expected behavior in case one of the sub-node deletions fails with an exception.
new public method deleteRecursive() added , ( async method ).
> zkCli.sh -rmr /node
> -------------------
>
> Key: ZOOKEEPER-729
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729
> Project: Zookeeper
> Issue Type: New Feature
> Components: c client, java client
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-729.patch, ZOOKEEPER-729.patch
>
>
> Recursively delete a given znode in zookeeper, from the command-line.
> New operation "rmr" added to zkclient.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-729) Recursively delete a znode -
zkCli.sh rmr /node
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kay Kay updated ZOOKEEPER-729:
------------------------------
Status: Patch Available (was: Open)
> Recursively delete a znode - zkCli.sh rmr /node
> ------------------------------------------------
>
> Key: ZOOKEEPER-729
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729
> Project: Zookeeper
> Issue Type: New Feature
> Components: java client
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch
>
>
> Recursively delete a given znode in zookeeper, from the command-line.
> New operation "rmr" added to zkclient.
> $ ./zkCli.sh rmr /node
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ZOOKEEPER-729) Recursively delete a znode -
zkCli.sh rmr /node
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-729:
-----------------------------------
Status: Patch Available (was: Open)
FYI Kay, you want to "submit patch" link once you have a good patch, in order for hudson qabot to get triggered and trigger the addl review workflow (committer)
> Recursively delete a znode - zkCli.sh rmr /node
> ------------------------------------------------
>
> Key: ZOOKEEPER-729
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729
> Project: Zookeeper
> Issue Type: New Feature
> Components: java client
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch
>
>
> Recursively delete a given znode in zookeeper, from the command-line.
> New operation "rmr" added to zkclient.
> $ ./zkCli.sh rmr /node
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ZOOKEEPER-729) Recursively Delete a znode
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kay Kay updated ZOOKEEPER-729:
------------------------------
Description:
Recursively delete a given znode in zookeeper, from the command-line.
New operation "rmr" added to zkclient.
usage:
$ zkCli.sh rmr /node
was:
Recursively delete a given znode in zookeeper, from the command-line.
New operation "rmr" added to zkclient.
Summary: Recursively Delete a znode (was: zkCli.sh -rmr /node)
> Recursively Delete a znode
> ---------------------------
>
> Key: ZOOKEEPER-729
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729
> Project: Zookeeper
> Issue Type: New Feature
> Reporter: Kay Kay
> Fix For: 3.3.1, 3.4.0
>
> Attachments: ZOOKEEPER-729.patch
>
>
> Recursively delete a given znode in zookeeper, from the command-line.
> New operation "rmr" added to zkclient.
> usage:
> $ zkCli.sh rmr /node
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-729) Recursively delete a znode -
zkCli.sh rmr /node
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kay Kay updated ZOOKEEPER-729:
------------------------------
Status: Open (was: Patch Available)
> Recursively delete a znode - zkCli.sh rmr /node
> ------------------------------------------------
>
> Key: ZOOKEEPER-729
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729
> Project: Zookeeper
> Issue Type: New Feature
> Components: java client
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch
>
>
> Recursively delete a given znode in zookeeper, from the command-line.
> New operation "rmr" added to zkclient.
> $ ./zkCli.sh rmr /node
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ZOOKEEPER-729) Recursively delete a znode -
zkCli.sh rmr /node
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kay Kay updated ZOOKEEPER-729:
------------------------------
Attachment: ZOOKEEPER-729.patch
> Recursively delete a znode - zkCli.sh rmr /node
> ------------------------------------------------
>
> Key: ZOOKEEPER-729
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729
> Project: Zookeeper
> Issue Type: New Feature
> Components: java client
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch
>
>
> Recursively delete a given znode in zookeeper, from the command-line.
> New operation "rmr" added to zkclient.
> $ ./zkCli.sh rmr /node
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ZOOKEEPER-729) Recursively delete a znode -
zkCli.sh rmr /node
Posted by "Henry Robinson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856224#action_12856224 ]
Henry Robinson commented on ZOOKEEPER-729:
------------------------------------------
I *think* it's due to a documentation warning as there is a link target in one of the headers that doesn't exist.
> Recursively delete a znode - zkCli.sh rmr /node
> ------------------------------------------------
>
> Key: ZOOKEEPER-729
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729
> Project: Zookeeper
> Issue Type: New Feature
> Components: java client
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch
>
>
> Recursively delete a given znode in zookeeper, from the command-line.
> New operation "rmr" added to zkclient.
> $ ./zkCli.sh rmr /node
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ZOOKEEPER-729) zkCli.sh -rmr /node
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850385#action_12850385 ]
Patrick Hunt commented on ZOOKEEPER-729:
----------------------------------------
bq. Would it be ok if we have a separate jira to track it.
sure. link it to this one.
bq. that was an inspiration from hdfs
that's fine, I was just thinking to keep down the proliferation of cmds... (personally I would have modeled all the commands on unix fs commands...)
bq. not sure what effect async will have
In ZK all operations are ordered. So if a single client session calls async delete(/foo/a/b) then async delete(/foo/a), then async delete(/foo) it will be deleted in that same order, guaranteed. You will get callbacks with success/fail of each operation, so you
would need to wait for those to be sure. sync is fine, just saying async is faster which might be important if the tree is large...
bq. You should get rid of the System.out.println lines
I think we want to use system out for user interaction, LOG is for debugging (at least that's what we're doing in that class today.)
Typically in unix you don't message to the console for expected
phunt@valhalla:~$ touch foo
phunt@valhalla:~$ rm foo
phunt@valhalla:~$
just for error conditions. I'd put those printlns for delete into the LOG (success/debug information) and println only if the
user's operation failed to do what was expected.
> zkCli.sh -rmr /node
> -------------------
>
> Key: ZOOKEEPER-729
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729
> Project: Zookeeper
> Issue Type: New Feature
> Components: c client, java client
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-729.patch
>
>
> Recursively delete a given znode in zookeeper, from the command-line.
> New operation "rmr" added to zkclient.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-729) Recursively delete a znode -
zkCli.sh rmr /node
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-729:
-----------------------------------
Status: Patch Available (was: Open)
> Recursively delete a znode - zkCli.sh rmr /node
> ------------------------------------------------
>
> Key: ZOOKEEPER-729
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729
> Project: Zookeeper
> Issue Type: New Feature
> Components: java client
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch
>
>
> Recursively delete a given znode in zookeeper, from the command-line.
> New operation "rmr" added to zkclient.
> $ ./zkCli.sh rmr /node
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ZOOKEEPER-729) zkCli.sh -rmr /node
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kay Kay updated ZOOKEEPER-729:
------------------------------
Fix Version/s: 3.4.0
> zkCli.sh -rmr /node
> -------------------
>
> Key: ZOOKEEPER-729
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729
> Project: Zookeeper
> Issue Type: New Feature
> Reporter: Kay Kay
> Fix For: 3.3.1, 3.4.0
>
> Attachments: ZOOKEEPER-729.patch
>
>
> Recursively delete a given znode in zookeeper, from the command-line.
> New operation "rmr" added to zkclient.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-729) Recursively delete a znode -
zkCli.sh rmr /node
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-729:
-----------------------------------
Status: Patch Available (was: Open)
> Recursively delete a znode - zkCli.sh rmr /node
> ------------------------------------------------
>
> Key: ZOOKEEPER-729
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729
> Project: Zookeeper
> Issue Type: New Feature
> Components: java client
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch
>
>
> Recursively delete a given znode in zookeeper, from the command-line.
> New operation "rmr" added to zkclient.
> $ ./zkCli.sh rmr /node
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ZOOKEEPER-729) zkCli.sh -rmr /node
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kay Kay updated ZOOKEEPER-729:
------------------------------
Attachment: ZOOKEEPER-729.patch
Retrieve the entire tree on the client side and then start deleting from the leaves to the root.
assumptions:
the service performing the updates to the root znode is brought down completely and the recursive delete completes then .
No atomicity guaranteed.
An efficient version would involve modifying the .jute and sending the path to the server and deleting on the same. But then, for now - this works.
> zkCli.sh -rmr /node
> -------------------
>
> Key: ZOOKEEPER-729
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729
> Project: Zookeeper
> Issue Type: New Feature
> Reporter: Kay Kay
> Attachments: ZOOKEEPER-729.patch
>
>
> Recursively delete a given znode in zookeeper, from the command-line.
> New operation "rmr" added to zkclient.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.