You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/23 07:22:22 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #26965: [SQL]Support single quotes json parsing for get_json_object and json_tuple

HyukjinKwon commented on a change in pull request #26965: [SQL]Support single quotes json parsing for get_json_object and json_tuple
URL: https://github.com/apache/spark/pull/26965#discussion_r360789470
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
 ##########
 @@ -103,6 +103,7 @@ private[this] object SharedFactory {
   val jsonFactory = new JsonFactoryBuilder()
 
 Review comment:
   I think both functions were added mainly to support Hive compatibility, and I think that's why.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org