You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/10 04:39:22 UTC
[GitHub] [arrow-rs] kylebarron opened a new pull request #1414: Update zstd version for wasm support
kylebarron opened a new pull request #1414:
URL: https://github.com/apache/arrow-rs/pull/1414
# Which issue does this PR close?
Relevant to #180 but does not fully close it, as LZ4 still does not build on `wasm32-unknown-unknown`.
# Rationale for this change
zstd has released [version 0.11](https://github.com/gyscos/zstd-rs/releases/tag/v0.11.0) with Web Assembly (`wasm32-unknown-unknown`) support https://github.com/gyscos/zstd-rs/pull/139.
# What changes are included in this PR?
# Are there any user-facing changes?
None
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #1414: Set `default-features = false` for `zstd` in the parquet crate to support `wasm32-unknown-unknown`
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1414:
URL: https://github.com/apache/arrow-rs/pull/1414#issuecomment-1068833596
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1414?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1414](https://codecov.io/gh/apache/arrow-rs/pull/1414?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (835acb9) into [master](https://codecov.io/gh/apache/arrow-rs/commit/717216f2a296566b10d786a113ceea937e95a459?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (717216f) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #1414 +/- ##
=======================================
Coverage 82.67% 82.67%
=======================================
Files 185 185
Lines 53866 53866
=======================================
Hits 44535 44535
Misses 9331 9331
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/1414?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [arrow/src/array/transform/mod.rs](https://codecov.io/gh/apache/arrow-rs/pull/1414/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L3RyYW5zZm9ybS9tb2QucnM=) | `86.31% <0.00%> (-0.12%)` | :arrow_down: |
| [parquet\_derive/src/parquet\_field.rs](https://codecov.io/gh/apache/arrow-rs/pull/1414/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldF9kZXJpdmUvc3JjL3BhcnF1ZXRfZmllbGQucnM=) | `66.21% <0.00%> (+0.22%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1414?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1414?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [717216f...835acb9](https://codecov.io/gh/apache/arrow-rs/pull/1414?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] kylebarron commented on pull request #1414: Update zstd version in the parquet crate for wasm support
Posted by GitBox <gi...@apache.org>.
kylebarron commented on pull request #1414:
URL: https://github.com/apache/arrow-rs/pull/1414#issuecomment-1064274438
I did also have to add `default-features = false` for wasm support, though it looks like we weren't using any default features.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] kylebarron commented on pull request #1414: Update zstd version in the parquet crate for wasm support
Posted by GitBox <gi...@apache.org>.
kylebarron commented on pull request #1414:
URL: https://github.com/apache/arrow-rs/pull/1414#issuecomment-1068386304
I was made aware that bumping to `0.11.1` in `Cargo.toml` might not be necessary, as `cargo update` will choose `0.11.1` automatically. But regardless, wasm support still needs `default-features = false`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] kylebarron edited a comment on pull request #1414: Update zstd version in the parquet crate for wasm support
Posted by GitBox <gi...@apache.org>.
kylebarron edited a comment on pull request #1414:
URL: https://github.com/apache/arrow-rs/pull/1414#issuecomment-1064274438
I did also have to add `default-features = false` for wasm support; it seemed like the parquet crate wasn't using any default features.
Is the failing integration test CI run related to this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #1414: Update zstd version in the parquet crate for wasm support
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1414:
URL: https://github.com/apache/arrow-rs/pull/1414#issuecomment-1064105670
Related: https://github.com/apache/arrow-rs/pull/1415
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] kylebarron edited a comment on pull request #1414: Update zstd version in the parquet crate for wasm support
Posted by GitBox <gi...@apache.org>.
kylebarron edited a comment on pull request #1414:
URL: https://github.com/apache/arrow-rs/pull/1414#issuecomment-1064274438
I did also have to add `default-features = false` for wasm support; it seemed like the parquet crates wasn't using any default features.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #1414: Set `default-features = false` for `zstd` in the parquet crate to support `wasm32-unknown-unknown`
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1414:
URL: https://github.com/apache/arrow-rs/pull/1414#issuecomment-1068821778
> I was made aware that bumping to 0.11.1 in Cargo.toml might not be necessary, as cargo update will choose 0.11.1 automatically. But regardless, wasm support still needs default-features = false.
Putting `0.11.1` in Cargo.toml will ensure that at least `0.11.1` is used (not `0.11.0`, if there is such a thing). I think it is fine to leave in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] kylebarron commented on pull request #1414: Update zstd version in the parquet crate for wasm support
Posted by GitBox <gi...@apache.org>.
kylebarron commented on pull request #1414:
URL: https://github.com/apache/arrow-rs/pull/1414#issuecomment-1068234831
Version 0.11.0 is missing the shim header files for wasm support. I updated the `Cargo.toml`'s `include` array in https://github.com/gyscos/zstd-rs/pull/145 and that was included in 0.11.1.
Now the parquet crate builds with
```
cargo build --target wasm32-unknown-unknown --no-default-features --features zstd
```
(after adding `getrandom = { version = "0.2.3", features = ["js"] }`, needed for wasm, though usually marked as a dependency by a downstream package).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #1414: Set `default-features = false` for `zstd` in the parquet crate to support `wasm32-unknown-unknown`
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1414:
URL: https://github.com/apache/arrow-rs/pull/1414#issuecomment-1069069701
Thanks @kylebarron
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb merged pull request #1414: Set `default-features = false` for `zstd` in the parquet crate to support `wasm32-unknown-unknown`
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #1414:
URL: https://github.com/apache/arrow-rs/pull/1414
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org