[GitHub] [hbase] virajjasani commented on a change in pull request #4224: HBASE-26840 Fix NPE in the retry of logroller

[GitBox <gi...@apache.org>]

virajjasani commented on a change in pull request #4224:
URL: https://github.com/apache/hbase/pull/4224#discussion_r826665836



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/AbstractWALRoller.java
##########
@@ -223,8 +223,7 @@ public void run() {
               if (waitingTime < rollWaitTimeout && nAttempts < maxRollRetry) {
                 nAttempts++;
                 LOG.warn("Retry to roll log, nAttempts={}, waiting time={}ms, sleeping 1s to retry,"
-                    + " last excepiton= {}", nAttempts, waitingTime,
-                  ioe.getCause().getClass().getSimpleName());
+                    + " last excepiton= {}", nAttempts, waitingTime, ioe);

Review comment:
       nit: no need to add `{}` after `last excepiton`, keeping `ioe` as the last arg will print the whole Exception stacktrace.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org