[GitHub] [accumulo] keith-turner commented on a diff in pull request #3216: Moved CompactionCoordinator into Manager

["keith-turner (via GitHub)" <gi...@apache.org>]

keith-turner commented on code in PR #3216:
URL: https://github.com/apache/accumulo/pull/3216#discussion_r1218708684


##########
core/src/main/java/org/apache/accumulo/core/conf/cluster/ClusterConfigParser.java:
##########
@@ -95,10 +95,6 @@ public static void outputShellVariables(Map<String,String> config, PrintStream o
       }
     }
 
-    if (config.containsKey("compaction.coordinator")) {

Review Comment:
   I was wondering what would happen if this was still in the file.  Investigated and seems it would be ignored.  I opened #3452 to address this.  If that is merged then we can remove compaction.coordinator as a valid key when merging it to elasticity. 



##########
server/base/src/main/java/org/apache/accumulo/server/init/ZooKeeperInitializer.java:
##########
@@ -156,10 +156,6 @@ void initialize(final ServerContext context, final boolean clearInstanceName,
         ZooUtil.NodeExistsPolicy.FAIL);
     zoo.putPersistentData(zkInstanceRoot + WalStateManager.ZWALS, EMPTY_BYTE_ARRAY,
         ZooUtil.NodeExistsPolicy.FAIL);
-    zoo.putPersistentData(zkInstanceRoot + Constants.ZCOORDINATOR, EMPTY_BYTE_ARRAY,

Review Comment:
   These ZK nodes could be cleaned up by the 4.0  upgrade code.
   
   Also can `Constants.ZCOORDINATOR` and `Constants.ZCOORDINATOR_LOCK` be removed from the code?



##########
server/manager/src/main/java/org/apache/accumulo/manager/compaction/DeadCompactionDetector.java:
##########
@@ -74,7 +74,7 @@ private void detectDeadCompactions() {
 
     if (tabletCompactions.isEmpty()) {
       // Clear out dead compactions, tservers don't think anything is running
-      log.trace("Clearing the dead compaction map, no tablets have compactions running");
+      log.debug("Clearing the dead compaction map, no tablets have compactions running");

Review Comment:
   Did you intend to leave the log level changes?  Wondering it they were made for temporary debugging or if you wanted to commit them.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org