[GitHub] [ignite-3] sanpwc commented on a diff in pull request #1797: IGNITE-19042 Initialization of distribution zone meta storage keys on node start.

["sanpwc (via GitHub)" <gi...@apache.org>]

sanpwc commented on code in PR #1797:
URL: https://github.com/apache/ignite-3/pull/1797#discussion_r1139044086


##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java:
##########
@@ -873,25 +873,25 @@ private void initDataNodesFromVaultManager() {
                         try {
                             if (vaultEntry != null && vaultEntry.value() != null) {
                                 logicalTopology = fromBytes(vaultEntry.value());
+                            }
 
-                                // init keys and data nodes for default zone
-                                saveDataNodesAndUpdateTriggerKeysInMetaStorage(
-                                        DEFAULT_ZONE_ID,
-                                        appliedRevision,
-                                        logicalTopology
-                                );
+                            // init keys and data nodes for default zone
+                            saveDataNodesAndUpdateTriggerKeysInMetaStorage(
+                                    DEFAULT_ZONE_ID,
+                                    appliedRevision,
+                                    logicalTopology

Review Comment:
   Are we going to call saveDataNodesAndUpdateTriggerKeysInMetaStorage if vaultEntry == null or  vaultEntry.value() == null? If true
   a. Why?
   b. What we will use as logicalTopology?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org