[GitHub] [beam] TheNeuralBit commented on a change in pull request #17162: [BEAM-14157] Don't call requestObserver.onNext on closed windmill streams

[GitBox <gi...@apache.org>]

TheNeuralBit commented on a change in pull request #17162:
URL: https://github.com/apache/beam/pull/17162#discussion_r834455046



##########
File path: runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java
##########
@@ -848,7 +848,11 @@ public void run() {
           new TimerTask() {
             @Override
             public void run() {
-              refreshActiveWork();
+              try {
+                refreshActiveWork();
+              } catch (RuntimeException e) {
+                LOG.warn("Failed to refresh active work: ", e);

Review comment:
       Sorry I'm not that familiar with this code, could you help me understand the change? 
   
   I'm assuming that this `refreshActiveWork()` call ultimately calls `GrpcWindmiillServier.send()`, so we're catching the error here and logging it. This is an improvement because previously that situation caused stalled GetWork streams?
   
   Are there other places where we should be catching the `IllegalStateException`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org