You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org> on 2012/02/14 22:22:00 UTC

[jira] [Commented] (QPID-3841) Improve batching of writes for outbound messages.

    [ https://issues.apache.org/jira/browse/QPID-3841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208019#comment-13208019 ] 

jiraposter@reviews.apache.org commented on QPID-3841:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3897/
-----------------------------------------------------------

Review request for qpid, Andrew Stitcher, Alan Conway, and Gordon Sim.


Summary
-------

Patch provided by Gordon that improves the coalescing of outbound message buffers.


This addresses bug qpid-3841.
    https://issues.apache.org/jira/browse/qpid-3841


Diffs
-----

  /trunk/qpid/cpp/src/qpid/amqp_0_10/Connection.cpp 1230550 

Diff: https://reviews.apache.org/r/3897/diff


Testing
-------

unit test pass, including cluster tests.


Thanks,

Kenneth


                
> Improve batching of writes for outbound messages.
> -------------------------------------------------
>
>                 Key: QPID-3841
>                 URL: https://issues.apache.org/jira/browse/QPID-3841
>             Project: Qpid
>          Issue Type: Improvement
>          Components: C++ Broker
>    Affects Versions: 0.15
>            Reporter: Ken Giusti
>            Assignee: Ken Giusti
>            Priority: Minor
>             Fix For: 0.15
>
>
> A patch created by Gordon Sim will allow the connection to batch up outbound messages, resulting in less calls to the socket's write method (as more data is passed with each write).
> This results in a small performance improvement.  For example, given a broker with a single queue (flow control disabled), qpid-send filling it and qpid-receive draining it simultaineously with 300 byte messages:
> Pre-patch:
> qpid-send=    77581 msg/sec
> qpid-receive= 77345 msg/sec
> Post-patch:
> qpid-send=    84931 msg/sec
> qpid-receive= 84789 msg/sec

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org