[jira] [Resolved] (AMQ-5990) PooledConnectionFactory does not allow disabling JMX on GenericKeyObjectPool

["Christopher L. Shannon (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/AMQ-5990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christopher L. Shannon resolved AMQ-5990.
-----------------------------------------
       Resolution: Fixed
    Fix Version/s: 5.13.0

Based on the fact that we want to encapsulate the use of Commons Pool and not expose it, I turned of JMX by default and did not expose the configuration option.  There's already an open ticket for adding JMX statistics to the PooledConnectionFactory which should be turned on in the future: AMQ-4025

> PooledConnectionFactory does not allow disabling JMX on GenericKeyObjectPool
> ----------------------------------------------------------------------------
>
>                 Key: AMQ-5990
>                 URL: https://issues.apache.org/jira/browse/AMQ-5990
>             Project: ActiveMQ
>          Issue Type: Bug
>            Reporter: Aravind Chennuru
>            Assignee: Christopher L. Shannon
>             Fix For: 5.12.1, 5.13.0
>
>         Attachments: patchfile.txt
>
>
> initConnectionPool does not allow us to configure the GenericKeyObjectPool.
> Suggestion:
> PooledConnectionFactory
> {code}
> private GenericKeyedObjectPoolConfig config;
> public void setBasePoolConfig(final GenericKeyedObjectPoolConfig config) {
>         this.config = config;
> }
> public void initConnectionsPool() {
>      if (this.connectionsPool == null) {
>             this.connectionsPool = new GenericKeyedObjectPool<ConnectionKey, ConnectionPool>(blah, config==null?new GenericKeyedObjectPoolConfig():config);
>      }
> }
> protected ConnectionPool createConnectionPool(Connection connection) {
>         return new ConnectionPool(connection, config);
>     }
> {code}
> ConnectionPool
> {code}
> public ConnectionPool(Connection connection) {
>       this(connection, new GenericKeyedObjectPoolConfig());
> }
> public ConnectionPool(Connection connection, GenericKeyedObjectPoolConfig config) {
>       this.connection = wrap(connection);
>       this.sessionPool = new GenericKeyedObjectPool<SessionKey, SessionHolder>(blah, config==null?new GenericKeyedObjectPoolConfig():config);
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)