[GitHub] [camel-k] nicolaferraro commented on a change in pull request #621: Fix #602: error in set-version script

[GitBox <gi...@apache.org>]

nicolaferraro commented on a change in pull request #621: Fix #602: error in set-version script
URL: https://github.com/apache/camel-k/pull/621#discussion_r276248426
 
 

 ##########
 File path: script/set_version.sh
 ##########
 @@ -2,15 +2,15 @@
 
 set -e
 
-if [ "$#" -ne 1 ]; then
-    echo "usage: $0 version"
+if [ "$#" -lt 1 ] || [ "$#" -gt 2 ]; then
+    echo "usage: $0 version [image_name]"
     exit 1
 fi
 
 location=$(dirname $0)
 version=$1
 image_name=${2:-docker.io\/apache\/camel-k}
-sanitized_image_name=${image_name/\//\\\/}
 
 Review comment:
   Found it on stackoverflow :smile: : https://stackoverflow.com/questions/13210880/replace-one-substring-for-another-string-in-shell-script

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services