You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/03/29 02:47:34 UTC

[GitHub] [skywalking] zhaoyuguang commented on pull request #6632: Remove the close_before_method and close_after_method parameters of custom-enhance-plugin to avoid memory leaks

zhaoyuguang commented on pull request #6632:
URL: https://github.com/apache/skywalking/pull/6632#issuecomment-809028128


   It is true that these two parameters `close_before_method` `close_after_method` are not described in the documentation and unit tests. 
   These two parameters allow for before span and after span not to be done in the same method, but at the same time, they introduce the risk of `memory leak`.
   Removing this part of the code that is not described in the documentation reduces the risk of `memory leak`, LGTM 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org